upstream/mercurial-mirror Files · tests/test-abort-checkin.t

posix: always seek to EOF when opening a file in append mode...

posix: always seek to EOF when opening a file in append mode Python 3 already does this, so skip it there. Consider the program: #include <stdio.h> int main() { FILE *f = fopen("narf", "w"); fprintf(f, "narf\n"); fclose(f); f = fopen("narf", "a"); printf("%ld\n", ftell(f)); fprintf(f, "troz\n"); printf("%ld\n", ftell(f)); return 0; } on macOS, FreeBSD, and Linux with glibc, this program prints 5 10 but on musl libc (Alpine Linux and probably others) this prints 0 10 By my reading of https://pubs.opengroup.org/onlinepubs/009695399/functions/fopen.html this is technically correct, specifically: > Opening a file with append mode (a as the first character in the > mode argument) shall cause all subsequent writes to the file to be > forced to the then current end-of-file, regardless of intervening > calls to fseek(). in other words, the file position doesn't really matter in append-mode files, and we can't depend on it being at all meaningful unless we perform a seek() before tell() after open(..., 'a'). Experimentally after a .write() we can do a .tell() and it'll always be reasonable, but I'm unclear from reading the specification if that's a smart thing to rely on. This matches what we do on Windows and what Python 3 does for free, so let's just be consistent. Thanks to Yuya for the idea.

Pulkit Goyal - - Load All Authors

File last commit:

r36393:f798709e default


                r42778:97ada9b8

5.0.2 stable

Download file

             test-abort-checkin.t
        
                    37 lines
            
             | 873 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-abort-checkin.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Martin Geisler
    
tests: unify test-abort-checkin

              r11848
            
        $ cat > abortcommit.py <<EOF

        Pierre-Yves David
    
error: get Abort from 'error' instead of 'util'...

              r26587
            
        > from mercurial import error

        Martin Geisler
    
tests: unify test-abort-checkin

              r11848
            
        > def hook(**args):

        Pulkit Goyal
    
py3: add b'' prefixes in test-abort-checkin.t...

              r36393
            
        >     raise error.Abort(b"no commits allowed")

        Martin Geisler
    
tests: unify test-abort-checkin

              r11848
            
        > def reposetup(ui, repo):

        Pulkit Goyal
    
py3: add b'' prefixes in test-abort-checkin.t...

              r36393
            
        >     repo.ui.setconfig(b"hooks", b"pretxncommit.nocommits", hook)

        Martin Geisler
    
tests: unify test-abort-checkin

              r11848
            
        > EOF

        $ abspath=`pwd`/abortcommit.py

        Yuya Nishihara
    
tests: write hgrc of more than two lines by using shell heredoc...

              r23172
            
        $ cat <<EOF >> $HGRCPATH

        > [extensions]

        > mq =

        > abortcommit = $abspath

        > EOF

        Martin Geisler
    
tests: unify test-abort-checkin

              r11848
            
        $ hg init foo

        $ cd foo

        $ echo foo > foo

        $ hg add foo

      mq may keep a reference to the repository so __del__ will not be

      called and .hg/journal.dirstate will not be deleted:

        $ hg ci -m foo

        error: pretxncommit.nocommits hook failed: no commits allowed

        transaction abort!

        rollback completed

        abort: no commits allowed

        Matt Mackall
    
tests: add exit codes to unified tests

              r12316
            
        [255]

        Martin Geisler
    
tests: unify test-abort-checkin

              r11848
            
        $ hg ci -m foo

        error: pretxncommit.nocommits hook failed: no commits allowed

        transaction abort!

        rollback completed

        abort: no commits allowed

        Matt Mackall
    
tests: add exit codes to unified tests

              r12316
            
        [255]

        Mads Kiilerich
    
tests: add missing trailing 'cd ..'...

              r16913
            
        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Martin Geisler tests: unify test-abort-checkin	r11848	$ cat > abortcommit.py <<EOF
Pierre-Yves David error: get Abort from 'error' instead of 'util'...	r26587	> from mercurial import error
Martin Geisler tests: unify test-abort-checkin	r11848	> def hook(**args):
Pulkit Goyal py3: add b'' prefixes in test-abort-checkin.t...	r36393	> raise error.Abort(b"no commits allowed")
Martin Geisler tests: unify test-abort-checkin	r11848	> def reposetup(ui, repo):
Pulkit Goyal py3: add b'' prefixes in test-abort-checkin.t...	r36393	> repo.ui.setconfig(b"hooks", b"pretxncommit.nocommits", hook)
Martin Geisler tests: unify test-abort-checkin	r11848	> EOF
		$ abspath=`pwd`/abortcommit.py

Yuya Nishihara tests: write hgrc of more than two lines by using shell heredoc...	r23172	$ cat <<EOF >> $HGRCPATH
		> [extensions]
		> mq =
		> abortcommit = $abspath
		> EOF
Martin Geisler tests: unify test-abort-checkin	r11848
		$ hg init foo
		$ cd foo
		$ echo foo > foo
		$ hg add foo

		mq may keep a reference to the repository so __del__ will not be
		called and .hg/journal.dirstate will not be deleted:

		$ hg ci -m foo
		error: pretxncommit.nocommits hook failed: no commits allowed
		transaction abort!
		rollback completed
		abort: no commits allowed
Matt Mackall tests: add exit codes to unified tests	r12316	[255]
Martin Geisler tests: unify test-abort-checkin	r11848	$ hg ci -m foo
		error: pretxncommit.nocommits hook failed: no commits allowed
		transaction abort!
		rollback completed
		abort: no commits allowed
Matt Mackall tests: add exit codes to unified tests	r12316	[255]
Mads Kiilerich tests: add missing trailing 'cd ..'...	r16913
		$ cd ..