upstream/mercurial-mirror Files · tests/test-eolfilename.t

posix: always seek to EOF when opening a file in append mode...

posix: always seek to EOF when opening a file in append mode Python 3 already does this, so skip it there. Consider the program: #include <stdio.h> int main() { FILE *f = fopen("narf", "w"); fprintf(f, "narf\n"); fclose(f); f = fopen("narf", "a"); printf("%ld\n", ftell(f)); fprintf(f, "troz\n"); printf("%ld\n", ftell(f)); return 0; } on macOS, FreeBSD, and Linux with glibc, this program prints 5 10 but on musl libc (Alpine Linux and probably others) this prints 0 10 By my reading of https://pubs.opengroup.org/onlinepubs/009695399/functions/fopen.html this is technically correct, specifically: > Opening a file with append mode (a as the first character in the > mode argument) shall cause all subsequent writes to the file to be > forced to the then current end-of-file, regardless of intervening > calls to fseek(). in other words, the file position doesn't really matter in append-mode files, and we can't depend on it being at all meaningful unless we perform a seek() before tell() after open(..., 'a'). Experimentally after a .write() we can do a .tell() and it'll always be reasonable, but I'm unclear from reading the specification if that's a smart thing to rely on. This matches what we do on Windows and what Python 3 does for free, so let's just be consistent. Thanks to Yuya for the idea.

Yuya Nishihara - - Load All Authors

File last commit:

r38282:dbf31732 default


                r42778:97ada9b8

5.0.2 stable

Download file

             test-eolfilename.t
        
                    80 lines
            
             | 1.5 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-eolfilename.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Matt Mackall
    
tests: replace exit 80 with #require

              r22046
            
      #require eol-in-paths

        Matt Mackall
    
tests: unify test-eolfilename

              r12425
            
        Matt Mackall
    
urls: bulk-change BTS urls to new location

              r26420
            
      https://bz.mercurial-scm.org/352

        Matt Mackall
    
tests: unify test-eolfilename

              r12425
            
      test issue352

        $ hg init foo

        $ cd foo

        $ A=`printf 'he\rllo'`

        $ echo foo > "$A"

        $ hg add

        Mads Kiilerich
    
run-tests: allow test output lines to be terminated with \r in addition to \n...

              r17742
            
        adding he\r (no-eol) (esc)

        llo

        Matt Mackall
    
tests: unify test-eolfilename

              r12425
            
        abort: '\n' and '\r' disallowed in filenames: 'he\rllo'

        [255]

        $ hg ci -A -m m

        Mads Kiilerich
    
run-tests: allow test output lines to be terminated with \r in addition to \n...

              r17742
            
        adding he\r (no-eol) (esc)

        llo

        Matt Mackall
    
tests: unify test-eolfilename

              r12425
            
        abort: '\n' and '\r' disallowed in filenames: 'he\rllo'

        [255]

        $ rm "$A"

        $ echo foo > "hell

        > o"

        $ hg add

        adding hell

        o

        abort: '\n' and '\r' disallowed in filenames: 'hell\no'

        [255]

        $ hg ci -A -m m

        adding hell

        o

        abort: '\n' and '\r' disallowed in filenames: 'hell\no'

        [255]

        $ echo foo > "$A"

        Yuya Nishihara
    
debugwalk: show matcher output only if -v/--verbose...

              r38281
            
        $ hg debugwalk -v

        Yuya Nishihara
    
debugwalk: pretty-print nested matcher...

              r38282
            
        * matcher:

        <alwaysmatcher>

        Mads Kiilerich
    
run-tests: allow test output lines to be terminated with \r in addition to \n...

              r17742
            
        f  he\r (no-eol) (esc)

        llo  he\r (no-eol) (esc)

        llo

        Matt Mackall
    
tests: unify test-eolfilename

              r12425
            
        f  hell

        o  hell

        o

        Adrian Buehlmann
    
copy: do not copy file if name is disallowed anyway

              r13945
            
        $ echo bla > quickfox

        $ hg add quickfox

        $ hg ci -m 2

        $ A=`printf 'quick\rfox'`

        $ hg cp quickfox "$A"

        abort: '\n' and '\r' disallowed in filenames: 'quick\rfox'

        [255]

        $ hg mv quickfox "$A"

        abort: '\n' and '\r' disallowed in filenames: 'quick\rfox'

        [255]

        Matt Mackall
    
urls: bulk-change BTS urls to new location

              r26420
            
      https://bz.mercurial-scm.org/2036

        Matt Mackall
    
tests: unify test-eolfilename

              r12425
            
        $ cd ..

      test issue2039

        $ hg init bar

        $ cd bar

        Yuya Nishihara
    
tests: write hgrc of more than two lines by using shell heredoc...

              r23172
            
        $ cat <<EOF >> $HGRCPATH

        > [extensions]

        > color =

        > [color]

        > mode = ansi

        > EOF

        Matt Mackall
    
tests: unify test-eolfilename

              r12425
            
        $ A=`printf 'foo\nbar'`

        $ B=`printf 'foo\nbar.baz'`

        $ touch "$A"

        $ touch "$B"

        $ hg status --color=always

        Matt Mackall
    
status: use condwrite to avoid zero-width format string hack

              r17910
            
        \x1b[0;35;1;4m? \x1b[0m\x1b[0;35;1;4mfoo\x1b[0m (esc)

        Mads Kiilerich
    
tests: use (esc) for all non-ASCII test output

              r12942
            
        \x1b[0;35;1;4mbar\x1b[0m (esc)

        Matt Mackall
    
status: use condwrite to avoid zero-width format string hack

              r17910
            
        \x1b[0;35;1;4m? \x1b[0m\x1b[0;35;1;4mfoo\x1b[0m (esc)

        Mads Kiilerich
    
tests: use (esc) for all non-ASCII test output

              r12942
            
        \x1b[0;35;1;4mbar.baz\x1b[0m (esc)

        Mads Kiilerich
    
tests: add missing trailing 'cd ..'...

              r16913
            
        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Matt Mackall tests: replace exit 80 with #require	r22046	#require eol-in-paths
Matt Mackall tests: unify test-eolfilename	r12425
Matt Mackall urls: bulk-change BTS urls to new location	r26420	https://bz.mercurial-scm.org/352
Matt Mackall tests: unify test-eolfilename	r12425
		test issue352

		$ hg init foo
		$ cd foo
		$ A=`printf 'he\rllo'`
		$ echo foo > "$A"
		$ hg add
Mads Kiilerich run-tests: allow test output lines to be terminated with \r in addition to \n...	r17742	adding he\r (no-eol) (esc)
		llo
Matt Mackall tests: unify test-eolfilename	r12425	abort: '\n' and '\r' disallowed in filenames: 'he\rllo'
		[255]
		$ hg ci -A -m m
Mads Kiilerich run-tests: allow test output lines to be terminated with \r in addition to \n...	r17742	adding he\r (no-eol) (esc)
		llo
Matt Mackall tests: unify test-eolfilename	r12425	abort: '\n' and '\r' disallowed in filenames: 'he\rllo'
		[255]
		$ rm "$A"
		$ echo foo > "hell
		> o"
		$ hg add
		adding hell
		o
		abort: '\n' and '\r' disallowed in filenames: 'hell\no'
		[255]
		$ hg ci -A -m m
		adding hell
		o
		abort: '\n' and '\r' disallowed in filenames: 'hell\no'
		[255]
		$ echo foo > "$A"
Yuya Nishihara debugwalk: show matcher output only if -v/--verbose...	r38281	$ hg debugwalk -v
Yuya Nishihara debugwalk: pretty-print nested matcher...	r38282	* matcher:
		<alwaysmatcher>
Mads Kiilerich run-tests: allow test output lines to be terminated with \r in addition to \n...	r17742	f he\r (no-eol) (esc)
		llo he\r (no-eol) (esc)
		llo
Matt Mackall tests: unify test-eolfilename	r12425	f hell
		o hell
		o

Adrian Buehlmann copy: do not copy file if name is disallowed anyway	r13945	$ echo bla > quickfox
		$ hg add quickfox
		$ hg ci -m 2
		$ A=`printf 'quick\rfox'`
		$ hg cp quickfox "$A"
		abort: '\n' and '\r' disallowed in filenames: 'quick\rfox'
		[255]
		$ hg mv quickfox "$A"
		abort: '\n' and '\r' disallowed in filenames: 'quick\rfox'
		[255]

Matt Mackall urls: bulk-change BTS urls to new location	r26420	https://bz.mercurial-scm.org/2036
Matt Mackall tests: unify test-eolfilename	r12425
		$ cd ..

		test issue2039

		$ hg init bar
		$ cd bar
Yuya Nishihara tests: write hgrc of more than two lines by using shell heredoc...	r23172	$ cat <<EOF >> $HGRCPATH
		> [extensions]
		> color =
		> [color]
		> mode = ansi
		> EOF
Matt Mackall tests: unify test-eolfilename	r12425	$ A=`printf 'foo\nbar'`
		$ B=`printf 'foo\nbar.baz'`
		$ touch "$A"
		$ touch "$B"
		$ hg status --color=always
Matt Mackall status: use condwrite to avoid zero-width format string hack	r17910	\x1b[0;35;1;4m? \x1b[0m\x1b[0;35;1;4mfoo\x1b[0m (esc)
Mads Kiilerich tests: use (esc) for all non-ASCII test output	r12942	\x1b[0;35;1;4mbar\x1b[0m (esc)
Matt Mackall status: use condwrite to avoid zero-width format string hack	r17910	\x1b[0;35;1;4m? \x1b[0m\x1b[0;35;1;4mfoo\x1b[0m (esc)
Mads Kiilerich tests: use (esc) for all non-ASCII test output	r12942	\x1b[0;35;1;4mbar.baz\x1b[0m (esc)
Mads Kiilerich tests: add missing trailing 'cd ..'...	r16913
		$ cd ..