upstream/mercurial-mirror Files · tests/test-extra-filelog-entry.t

posix: always seek to EOF when opening a file in append mode...

posix: always seek to EOF when opening a file in append mode Python 3 already does this, so skip it there. Consider the program: #include <stdio.h> int main() { FILE *f = fopen("narf", "w"); fprintf(f, "narf\n"); fclose(f); f = fopen("narf", "a"); printf("%ld\n", ftell(f)); fprintf(f, "troz\n"); printf("%ld\n", ftell(f)); return 0; } on macOS, FreeBSD, and Linux with glibc, this program prints 5 10 but on musl libc (Alpine Linux and probably others) this prints 0 10 By my reading of https://pubs.opengroup.org/onlinepubs/009695399/functions/fopen.html this is technically correct, specifically: > Opening a file with append mode (a as the first character in the > mode argument) shall cause all subsequent writes to the file to be > forced to the then current end-of-file, regardless of intervening > calls to fseek(). in other words, the file position doesn't really matter in append-mode files, and we can't depend on it being at all meaningful unless we perform a seek() before tell() after open(..., 'a'). Experimentally after a .write() we can do a .tell() and it'll always be reasonable, but I'm unclear from reading the specification if that's a smart thing to rely on. This matches what we do on Windows and what Python 3 does for free, so let's just be consistent. Thanks to Yuya for the idea.

Gregory Szorc - - Load All Authors

File last commit:

r37301:d4e62df1 default


                r42778:97ada9b8

5.0.2 stable

Download file

             test-extra-filelog-entry.t
        
                    21 lines
            
             | 388 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-extra-filelog-entry.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Martin Geisler
    
tests: added a short description to issue numbers...

              r12399
            
      Issue351: mq: qrefresh can create extra revlog entry

        Adrian Buehlmann
    
tests: unify test-extra-filelog-entry

              r12305
            
        $ echo "[extensions]" >> $HGRCPATH

        $ echo "mq=" >> $HGRCPATH

        $ hg init

        $ hg qinit

        $ echo b > b

        $ hg ci -A -m foo

        adding b

        $ echo cc > b

        $ hg qnew -f foo.diff

        $ echo b > b

        $ hg qrefresh

        Sune Foldager
    
tests: fix deprecated use of hg debugdata/debugindex...

              r14182
            
        $ hg debugindex b

        Gregory Szorc
    
debugcommands: drop offset and length from debugindex by default...

              r37301
            
           rev linkrev nodeid       p1           p2

             0       0 1e88685f5dde 000000000000 000000000000

        Adrian Buehlmann
    
tests: unify test-extra-filelog-entry

              r12305

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Martin Geisler tests: added a short description to issue numbers...	r12399	Issue351: mq: qrefresh can create extra revlog entry
Adrian Buehlmann tests: unify test-extra-filelog-entry	r12305
		$ echo "[extensions]" >> $HGRCPATH
		$ echo "mq=" >> $HGRCPATH

		$ hg init
		$ hg qinit

		$ echo b > b
		$ hg ci -A -m foo
		adding b

		$ echo cc > b
		$ hg qnew -f foo.diff
		$ echo b > b
		$ hg qrefresh

Sune Foldager tests: fix deprecated use of hg debugdata/debugindex...	r14182	$ hg debugindex b
Gregory Szorc debugcommands: drop offset and length from debugindex by default...	r37301	rev linkrev nodeid p1 p2
		0 0 1e88685f5dde 000000000000 000000000000
Adrian Buehlmann tests: unify test-extra-filelog-entry	r12305