##// END OF EJS Templates
posix: always seek to EOF when opening a file in append mode...
posix: always seek to EOF when opening a file in append mode Python 3 already does this, so skip it there. Consider the program: #include <stdio.h> int main() { FILE *f = fopen("narf", "w"); fprintf(f, "narf\n"); fclose(f); f = fopen("narf", "a"); printf("%ld\n", ftell(f)); fprintf(f, "troz\n"); printf("%ld\n", ftell(f)); return 0; } on macOS, FreeBSD, and Linux with glibc, this program prints 5 10 but on musl libc (Alpine Linux and probably others) this prints 0 10 By my reading of https://pubs.opengroup.org/onlinepubs/009695399/functions/fopen.html this is technically correct, specifically: > Opening a file with append mode (a as the first character in the > mode argument) shall cause all subsequent writes to the file to be > forced to the then current end-of-file, regardless of intervening > calls to fseek(). in other words, the file position doesn't really matter in append-mode files, and we can't depend on it being at all meaningful unless we perform a seek() before tell() after open(..., 'a'). Experimentally after a .write() we can do a .tell() and it'll always be reasonable, but I'm unclear from reading the specification if that's a smart thing to rely on. This matches what we do on Windows and what Python 3 does for free, so let's just be consistent. Thanks to Yuya for the idea.

File last commit:

r41321:cf8677cd default
r42778:97ada9b8 5.0.2 stable
Show More
test-sshserver.py
59 lines | 1.6 KiB | text/x-python | PythonLexer
/ tests / test-sshserver.py
Siddharth Agarwal
sshserver: add a couple of tests for argument parsing...
r35770 from __future__ import absolute_import, print_function
import io
import unittest
import silenttestrunner
from mercurial import (
Gregory Szorc
wireprotoserver: move sshserver into module (API)...
r35877 wireprotoserver,
Gregory Szorc
wireproto: rename wireproto to wireprotov1server (API)...
r37803 wireprotov1server,
Siddharth Agarwal
sshserver: add a couple of tests for argument parsing...
r35770 )
Yuya Nishihara
procutil: bulk-replace function calls to point to new module
r37138 from mercurial.utils import (
procutil,
)
Siddharth Agarwal
sshserver: add a couple of tests for argument parsing...
r35770 class SSHServerGetArgsTests(unittest.TestCase):
def testparseknown(self):
tests = [
Gregory Szorc
py3: add b'' to test-sshserver.py...
r36230 (b'* 0\nnodes 0\n', [b'', {}]),
(b'* 0\nnodes 40\n1111111111111111111111111111111111111111\n',
[b'1111111111111111111111111111111111111111', {}]),
Siddharth Agarwal
sshserver: add a couple of tests for argument parsing...
r35770 ]
for input, expected in tests:
Gregory Szorc
py3: add b'' to test-sshserver.py...
r36230 self.assertparse(b'known', input, expected)
Siddharth Agarwal
sshserver: add a couple of tests for argument parsing...
r35770
def assertparse(self, cmd, input, expected):
server = mockserver(input)
Gregory Szorc
wireprotoserver: move SSH server operation to a standalone function...
r36232 proto = wireprotoserver.sshv1protocolhandler(server._ui,
server._fin,
server._fout)
Gregory Szorc
wireproto: rename wireproto to wireprotov1server (API)...
r37803 _func, spec = wireprotov1server.commands[cmd]
Gregory Szorc
wireprotoserver: move SSH server operation to a standalone function...
r36232 self.assertEqual(proto.getargs(spec), expected)
Siddharth Agarwal
sshserver: add a couple of tests for argument parsing...
r35770
def mockserver(inbytes):
ui = mockui(inbytes)
repo = mockrepo(ui)
Gregory Szorc
wireprotoserver: move sshserver into module (API)...
r35877 return wireprotoserver.sshserver(ui, repo)
Siddharth Agarwal
sshserver: add a couple of tests for argument parsing...
r35770
class mockrepo(object):
def __init__(self, ui):
self.ui = ui
class mockui(object):
def __init__(self, inbytes):
self.fin = io.BytesIO(inbytes)
self.fout = io.BytesIO()
self.ferr = io.BytesIO()
Yuya Nishihara
ui: proxy protect/restorestdio() calls to update internal flag...
r41321 def protectfinout(self):
return self.fin, self.fout
def restorefinout(self, fin, fout):
pass
Siddharth Agarwal
sshserver: add a couple of tests for argument parsing...
r35770 if __name__ == '__main__':
Matt Harbison
test-sshserver: stabilize for Windows
r35790 # Don't call into msvcrt to set BytesIO to binary mode
Yuya Nishihara
procutil: bulk-replace function calls to point to new module
r37138 procutil.setbinary = lambda fp: True
Siddharth Agarwal
sshserver: add a couple of tests for argument parsing...
r35770 silenttestrunner.main(__name__)