##// END OF EJS Templates
sshpeer: store subprocess so it cleans up correctly...
sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.

File last commit:

r18589:91aac279 default
r18759:9baf4330 default
Show More
test-hgweb-raw.t
58 lines | 2.0 KiB | text/troff | Tads3Lexer
Mads Kiilerich
tests: use 'hghave serve' to guard tests that requires serve daemon management
r15446 $ "$TESTDIR/hghave" serve || exit 80
Matt Mackall
tests: unify test-hgweb-raw
r12441 Test raw style of hgweb
$ hg init test
$ cd test
$ mkdir sub
Mads Kiilerich
tests: use a different evil name in test-hgweb-raw.t...
r16973 $ cat >'sub/some text%.txt' <<ENDSOME
Matt Mackall
tests: unify test-hgweb-raw
r12441 > This is just some random text
> that will go inside the file and take a few lines.
> It is very boring to read, but computers don't
> care about things like that.
> ENDSOME
Mads Kiilerich
tests: use a different evil name in test-hgweb-raw.t...
r16973 $ hg add 'sub/some text%.txt'
Matt Mackall
tests: unify test-hgweb-raw
r12441 $ hg commit -d "1 0" -m "Just some text"
$ hg serve -p $HGPORT -A access.log -E error.log -d --pid-file=hg.pid
$ cat hg.pid >> $DAEMON_PIDS
Mads Kiilerich
tests: prepare get-with-headers.py for MSYS...
r17017 $ ("$TESTDIR/get-with-headers.py" localhost:$HGPORT '?f=bf0ff59095c9;file=sub/some%20text%25.txt;style=raw' content-type content-length content-disposition) >getoutput.txt
Matt Mackall
tests: fix shutdown race in test-hgweb-raw
r16298
Augie Fackler
test-hgweb-raw.t: use killdaemons instead of kill `cat pidfile`
r18589 $ "$TESTDIR/killdaemons.py" hg.pid
Matt Mackall
tests: fix shutdown race in test-hgweb-raw
r16298
Matt Mackall
tests: unify test-hgweb-raw
r12441 $ cat getoutput.txt
200 Script output follows
Matt Mackall
hgweb: raw file mimetype guessing configurable, off by default (BC) (issue2923)...
r15004 content-type: application/binary
content-length: 157
Mads Kiilerich
tests: use a different evil name in test-hgweb-raw.t...
r16973 content-disposition: inline; filename="some text%.txt"
Matt Mackall
hgweb: raw file mimetype guessing configurable, off by default (BC) (issue2923)...
r15004
This is just some random text
that will go inside the file and take a few lines.
It is very boring to read, but computers don't
care about things like that.
$ cat access.log error.log
Mads Kiilerich
tests: use a different evil name in test-hgweb-raw.t...
r16973 127.0.0.1 - - [*] "GET /?f=bf0ff59095c9;file=sub/some%20text%25.txt;style=raw HTTP/1.1" 200 - (glob)
Matt Mackall
hgweb: raw file mimetype guessing configurable, off by default (BC) (issue2923)...
r15004
$ rm access.log error.log
$ hg serve -p $HGPORT -A access.log -E error.log -d --pid-file=hg.pid \
> --config web.guessmime=True
$ cat hg.pid >> $DAEMON_PIDS
Mads Kiilerich
tests: prepare get-with-headers.py for MSYS...
r17017 $ ("$TESTDIR/get-with-headers.py" localhost:$HGPORT '?f=bf0ff59095c9;file=sub/some%20text%25.txt;style=raw' content-type content-length content-disposition) >getoutput.txt
Augie Fackler
test-hgweb-raw.t: use killdaemons instead of kill `cat pidfile`
r18589 $ "$TESTDIR/killdaemons.py" hg.pid
Matt Mackall
tests: fix shutdown race in test-hgweb-raw
r16298
Matt Mackall
hgweb: raw file mimetype guessing configurable, off by default (BC) (issue2923)...
r15004 $ cat getoutput.txt
200 Script output follows
Matt Mackall
tests: unify test-hgweb-raw
r12441 content-type: text/plain; charset="ascii"
content-length: 157
Mads Kiilerich
tests: use a different evil name in test-hgweb-raw.t...
r16973 content-disposition: inline; filename="some text%.txt"
Matt Mackall
tests: unify test-hgweb-raw
r12441
This is just some random text
that will go inside the file and take a few lines.
It is very boring to read, but computers don't
care about things like that.
$ cat access.log error.log
Mads Kiilerich
tests: use a different evil name in test-hgweb-raw.t...
r16973 127.0.0.1 - - [*] "GET /?f=bf0ff59095c9;file=sub/some%20text%25.txt;style=raw HTTP/1.1" 200 - (glob)
Matt Mackall
tests: unify test-hgweb-raw
r12441
Mads Kiilerich
tests: add missing trailing 'cd ..'...
r16913 $ cd ..