upstream/mercurial-mirror Files · tests/test-hup.t

sshpeer: store subprocess so it cleans up correctly...

sshpeer: store subprocess so it cleans up correctly When running 'hg pull --rebase', I was seeing this exception 100% of the time as the python process was closing down: Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored By storing the subprocess on the sshpeer, the subprocess seems to clean up correctly, and I no longer see the exception. I have no idea why this actually works, but I get a 0% repro if I store the subprocess in self.subprocess, and a 100% repro if I store None in self.subprocess. Possibly related to issue 2240.

Jim Hague - - Load All Authors

File last commit:

r16364:f64b25f1 stable


                r18759:9baf4330

default

Download file

             test-hup.t
        
                    28 lines
            
             | 656 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-hup.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Matt Mackall
    
tests: unify test-hup

              r12413
            
      Test hangup signal in the middle of transaction

        Mads Kiilerich
    
tests: use 'hghave serve' to guard tests that requires serve daemon management

              r15446
            
        $ "$TESTDIR/hghave" serve fifo || exit 80

        Matt Mackall
    
tests: unify test-hup

              r12413
            
        $ hg init

        $ mkfifo p

        Matt Mackall
    
tests: make test-hup more race-proof...

              r16342
            
        $ hg serve --stdio < p 1>out 2>&1 &

        Matt Mackall
    
tests: unify test-hup

              r12413
            
        $ P=$!

        Matt Mackall
    
tests: remove sleep/startup/shutdown races from test-hup

              r16299
            
      Do test while holding fifo open

        $ (

        > echo lock

        > echo addchangegroup

        Jim Hague
    
tests: avoid test-hup hanging on AIX...

              r16364
            
        > while [ ! -s .hg/store/journal ]; do sleep 0; done

        Matt Mackall
    
tests: remove sleep/startup/shutdown races from test-hup

              r16299
            
        > kill -HUP $P

        > ) > p

        Matt Mackall
    
tests: make test-hup more race-proof...

              r16342
            
        Matt Mackall
    
tests: avoid zombie lockup with test-hup...

              r16344
            
        $ wait

        Matt Mackall
    
tests: make test-hup more race-proof...

              r16342
            
        $ cat out

        Matt Mackall
    
tests: unify test-hup

              r12413
            
        0

        0

        adding changesets

        transaction abort!

        rollback completed

        killed!

        Matt Mackall
    
tests: remove sleep/startup/shutdown races from test-hup

              r16299
            
        Matt Mackall
    
tests: unify test-hup

              r12413
            
        $ echo .hg/* .hg/store/*

        Pierre-Yves David
    
phases: add rollback support

              r15455
            
        .hg/00changelog.i .hg/journal.bookmarks .hg/journal.branch .hg/journal.desc .hg/journal.dirstate .hg/requires .hg/store .hg/store/00changelog.i .hg/store/00changelog.i.a .hg/store/journal.phaseroots

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Matt Mackall tests: unify test-hup	r12413	Test hangup signal in the middle of transaction

Mads Kiilerich tests: use 'hghave serve' to guard tests that requires serve daemon management	r15446	$ "$TESTDIR/hghave" serve fifo \|\| exit 80
Matt Mackall tests: unify test-hup	r12413	$ hg init
		$ mkfifo p
Matt Mackall tests: make test-hup more race-proof...	r16342	$ hg serve --stdio < p 1>out 2>&1 &
Matt Mackall tests: unify test-hup	r12413	$ P=$!
Matt Mackall tests: remove sleep/startup/shutdown races from test-hup	r16299
		Do test while holding fifo open

		$ (
		> echo lock
		> echo addchangegroup
Jim Hague tests: avoid test-hup hanging on AIX...	r16364	> while [ ! -s .hg/store/journal ]; do sleep 0; done
Matt Mackall tests: remove sleep/startup/shutdown races from test-hup	r16299	> kill -HUP $P
		> ) > p
Matt Mackall tests: make test-hup more race-proof...	r16342
Matt Mackall tests: avoid zombie lockup with test-hup...	r16344	$ wait
Matt Mackall tests: make test-hup more race-proof...	r16342	$ cat out
Matt Mackall tests: unify test-hup	r12413	0
		0
		adding changesets
		transaction abort!
		rollback completed
		killed!
Matt Mackall tests: remove sleep/startup/shutdown races from test-hup	r16299
Matt Mackall tests: unify test-hup	r12413	$ echo .hg/* .hg/store/*
Pierre-Yves David phases: add rollback support	r15455	.hg/00changelog.i .hg/journal.bookmarks .hg/journal.branch .hg/journal.desc .hg/journal.dirstate .hg/requires .hg/store .hg/store/00changelog.i .hg/store/00changelog.i.a .hg/store/journal.phaseroots