##// END OF EJS Templates
merge: fix UnboundLocalError (issue3791)...
merge: fix UnboundLocalError (issue3791) A wrong variable name was introduced in 384df4db6520 for a case without test coverage. The variable name is fixed and a test case is introduced.

File last commit:

r17773:434e5bd6 default
r18505:9de9727c stable
Show More
extdiff.py
333 lines | 12.3 KiB | text/x-python | PythonLexer
Vadim Gelfer
new extension: extdiff. allows to use external diff program.
r2333 # extdiff.py - external diff program support for mercurial
#
# Copyright 2006 Vadim Gelfer <vadim.gelfer@gmail.com>
#
Martin Geisler
updated license to be explicit about GPL version 2
r8225 # This software may be used and distributed according to the terms of the
Matt Mackall
Update license to GPLv2+
r10263 # GNU General Public License version 2 or any later version.
Brendan Cully
Improve extdiff configuration....
r5245
Dirkjan Ochtman
extensions: change descriptions for extensions providing a few commands
r8934 '''command to allow external programs to compare revisions
Dirkjan Ochtman
help: add/fix docstrings for a bunch of extensions
r8873
Cédric Duval
doc: fix quotes mismatches affecting rst
r9286 The extdiff Mercurial extension allows you to use external programs
Martin Geisler
extdiff: wrap docstrings at 70 characters
r9257 to compare revisions, or revision with working directory. The external
diff programs are called with a configurable set of options and two
Brendan Cully
Improve extdiff configuration....
r5245 non-option arguments: paths to directories containing snapshots of
files to compare.
Javi Merino
extdiff: grammar "allows to" -> "allows one to"...
r14327 The extdiff extension also allows you to configure new diff commands, so
Martin Geisler
extdiff: fix reST syntax in module docstring
r11191 you do not need to type :hg:`extdiff -p kdiff3` always. ::
Mathieu Clabaut
Update [extdiff] configuration sample for vimdiff,...
r3127
Brendan Cully
Improve extdiff configuration....
r5245 [extdiff]
# add new command that runs GNU diff(1) in 'context diff' mode
cdiff = gdiff -Nprc5
## or the old way:
#cmd.cdiff = gdiff
#opts.cdiff = -Nprc5
Mathieu Clabaut
Update [extdiff] configuration sample for vimdiff,...
r3127
Brendan Cully
Improve extdiff configuration....
r5245 # add new command called vdiff, runs kdiff3
vdiff = kdiff3
Mathieu Clabaut
Update [extdiff] configuration sample for vimdiff,...
r3127
Brendan Cully
Improve extdiff configuration....
r5245 # add new command called meld, runs meld (no need to name twice)
meld =
# add new command called vimdiff, runs gvimdiff with DirDiff plugin
Martin Geisler
extdiff: wrap docstrings at 70 characters
r9257 # (see http://www.vim.org/scripts/script.php?script_id=102) Non
# English user, be sure to put "let g:DirDiffDynamicDiffText = 1" in
Brendan Cully
Improve extdiff configuration....
r5245 # your .vimrc
Thomas Arendsen Hein
extdiff: escape filenames with vim/DirDiff and make quoting work with Windows...
r16242 vimdiff = gvim -f "+next" \\
"+execute 'DirDiff' fnameescape(argv(0)) fnameescape(argv(1))"
Brendan Cully
Improve extdiff configuration....
r5245
Martin Geisler
extdiff: fix reST syntax in module docstring
r11191 Tool arguments can include variables that are expanded at runtime::
Steve Borho
extdiff: add labels, read diff arguments from [merge-tools]...
r11184
$parent1, $plabel1 - filename, descriptive label of first parent
$child, $clabel - filename, descriptive label of child revision
$parent2, $plabel2 - filename, descriptive label of second parent
Steven Stallion
extdiff: add repository root as a variable...
r14045 $root - repository root
Steve Borho
extdiff: add labels, read diff arguments from [merge-tools]...
r11184 $parent is an alias for $parent1.
The extdiff extension will look in your [diff-tools] and [merge-tools]
sections for diff tool arguments, when none are specified in [extdiff].
Martin Geisler
extdiff: fix reST syntax in module docstring
r11191 ::
Steve Borho
extdiff: add labels, read diff arguments from [merge-tools]...
r11184 [extdiff]
Martin Geisler
extdiff: fix reST syntax in module docstring
r11191 kdiff3 =
Steve Borho
extdiff: add labels, read diff arguments from [merge-tools]...
r11184
[diff-tools]
kdiff3.diffargs=--L1 '$plabel1' --L2 '$clabel' $parent $child
Martin Geisler
extdiff: fix reST syntax in module docstring
r11191 You can use -I/-X and list of file or directory names like normal
:hg:`diff` command. The extdiff extension makes snapshots of only
needed files, so running the external diff program will actually be
pretty fast (at least faster than having to compare the entire tree).
Brendan Cully
Improve extdiff configuration....
r5245 '''
Vadim Gelfer
new extension: extdiff. allows to use external diff program.
r2333
Matt Mackall
Simplify i18n imports
r3891 from mercurial.i18n import _
Sune Foldager
extdiff: add 3-way diff for merge changesets...
r9512 from mercurial.node import short, nullid
Matt Mackall
scmutil: drop aliases in cmdutil for match functions
r14322 from mercurial import scmutil, scmutil, util, commands, encoding
Sune Foldager
extdiff: add 3-way diff for merge changesets...
r9512 import os, shlex, shutil, tempfile, re
Brad Schick
extdiff: un-nested two functions...
r5135
Augie Fackler
hgext: mark all first-party extensions as such
r16743 testedwith = 'internal'
Patrick Mezard
extdiff: merge node and working dir snapshot modes
r8064 def snapshot(ui, repo, files, node, tmproot):
'''snapshot files as of some revision
if not using snapshot, -I/-X does not work and recursive diff
in tools like kdiff3 and meld displays too many files.'''
Brad Schick
extdiff: un-nested two functions...
r5135 dirname = os.path.basename(repo.root)
if dirname == "":
dirname = "root"
Patrick Mezard
extdiff: merge node and working dir snapshot modes
r8064 if node is not None:
dirname = '%s.%s' % (dirname, short(node))
Brad Schick
extdiff: un-nested two functions...
r5135 base = os.path.join(tmproot, dirname)
os.mkdir(base)
Patrick Mezard
extdiff: merge node and working dir snapshot modes
r8064 if node is not None:
ui.note(_('making snapshot of %d files from rev %s\n') %
(len(files), short(node)))
else:
Patrick Mezard
Merge with crew-stable
r8066 ui.note(_('making snapshot of %d files from working directory\n') %
Patrick Mezard
extdiff: merge node and working dir snapshot modes
r8064 (len(files)))
Adrian Buehlmann
move opener from util to scmutil
r13970 wopener = scmutil.opener(base)
Patrick Mezard
extdiff: merge node and working dir snapshot modes
r8064 fns_and_mtime = []
Matt Mackall
use repo[changeid] to get a changectx
r6747 ctx = repo[node]
Brad Schick
extdiff: un-nested two functions...
r5135 for fn in files:
Matt Mackall
use repo[changeid] to get a changectx
r6747 wfn = util.pconvert(fn)
Brodie Rao
cleanup: "not x in y" -> "x not in y"
r16686 if wfn not in ctx:
Sune Foldager
extdiff: add 3-way diff for merge changesets...
r9512 # File doesn't exist; could be a bogus modify
Brad Schick
extdiff: un-nested two functions...
r5135 continue
ui.note(' %s\n' % wfn)
dest = os.path.join(base, wfn)
Patrick Mezard
extdiff: preserve execute-bit across copies (issue1562)...
r8065 fctx = ctx[wfn]
data = repo.wwritedata(wfn, fctx.data())
if 'l' in fctx.flags():
wopener.symlink(data, wfn)
else:
Dan Villiom Podlaski Christiansen
prevent transient leaks of file handle by using new helper functions...
r14168 wopener.write(wfn, data)
Patrick Mezard
extdiff: preserve execute-bit across copies (issue1562)...
r8065 if 'x' in fctx.flags():
Adrian Buehlmann
rename util.set_flags to setflags
r14232 util.setflags(dest, False, True)
Patrick Mezard
extdiff: merge node and working dir snapshot modes
r8064 if node is None:
Patrick Mezard
extdiff: fix broken symlinks handling (issue1909)
r14021 fns_and_mtime.append((dest, repo.wjoin(fn),
os.lstat(dest).st_mtime))
Fabio Zadrozny <fabiofz at gmail dot com>
Propagating changes back to working dirs when changing files in external
r6103 return dirname, fns_and_mtime
Thomas Arendsen Hein
Remove trailing spaces, fix indentation
r5143
Vadim Gelfer
extdiff: fix bugs. add test.
r2906 def dodiff(ui, repo, diffcmd, diffopts, pats, opts):
Mads Kiilerich
fix trivial spelling errors
r17424 '''Do the actual diff:
Fabio Zadrozny <fabiofz at gmail dot com>
Propagating changes back to working dirs when changing files in external
r6103
- copy to a temp structure if diffing 2 internal revisions
- copy to a temp structure if diffing working revision with
another one and more than 1 file is changed
- just invoke the diff for a single file in the working dir
'''
Gilles Moris
extdiff: add --change option to display single changeset diff...
r7758
revs = opts.get('rev')
change = opts.get('change')
Sune Foldager
extdiff: add 3-way diff for merge changesets...
r9512 args = ' '.join(diffopts)
do3way = '$parent2' in args
Gilles Moris
extdiff: add --change option to display single changeset diff...
r7758
if revs and change:
msg = _('cannot specify --rev and --change at the same time')
raise util.Abort(msg)
elif change:
Matt Mackall
scmutil: move revsingle/pair/range from cmdutil...
r14319 node2 = scmutil.revsingle(repo, change, None).node()
Sune Foldager
extdiff: add 3-way diff for merge changesets...
r9512 node1a, node1b = repo.changelog.parents(node2)
Gilles Moris
extdiff: add --change option to display single changeset diff...
r7758 else:
Matt Mackall
scmutil: move revsingle/pair/range from cmdutil...
r14319 node1a, node2 = scmutil.revpair(repo, revs)
Sune Foldager
extdiff: add 3-way diff for merge changesets...
r9512 if not revs:
Matt Mackall
misc: replace .parents()[0] with p1()
r13878 node1b = repo.dirstate.p2()
Sune Foldager
extdiff: add 3-way diff for merge changesets...
r9512 else:
node1b = nullid
# Disable 3-way merge if there is only one parent
if do3way:
if node1b == nullid:
do3way = False
Gilles Moris
extdiff: add --change option to display single changeset diff...
r7758
Matt Mackall
scmutil: switch match users to supplying contexts...
r14671 matcher = scmutil.match(repo[node2], pats, opts)
Sune Foldager
extdiff: add 3-way diff for merge changesets...
r9512 mod_a, add_a, rem_a = map(set, repo.status(node1a, node2, matcher)[:3])
if do3way:
mod_b, add_b, rem_b = map(set, repo.status(node1b, node2, matcher)[:3])
else:
mod_b, add_b, rem_b = set(), set(), set()
modadd = mod_a | add_a | mod_b | add_b
common = modadd | rem_a | rem_b
if not common:
Benoit Boissinot
fix coding style (reported by pylint)
r10394 return 0
Vadim Gelfer
new extension: extdiff. allows to use external diff program.
r2333
tmproot = tempfile.mkdtemp(prefix='extdiff.')
try:
Sune Foldager
extdiff: add 3-way diff for merge changesets...
r9512 # Always make a copy of node1a (and node1b, if applicable)
dir1a_files = mod_a | rem_a | ((mod_b | add_b) - add_a)
dir1a = snapshot(ui, repo, dir1a_files, node1a, tmproot)[0]
Steve Borho
extdiff: add labels, read diff arguments from [merge-tools]...
r11184 rev1a = '@%d' % repo[node1a].rev()
Sune Foldager
extdiff: add 3-way diff for merge changesets...
r9512 if do3way:
dir1b_files = mod_b | rem_b | ((mod_a | add_a) - add_b)
dir1b = snapshot(ui, repo, dir1b_files, node1b, tmproot)[0]
Steve Borho
extdiff: add labels, read diff arguments from [merge-tools]...
r11184 rev1b = '@%d' % repo[node1b].rev()
Sune Foldager
extdiff: add 3-way diff for merge changesets...
r9512 else:
dir1b = None
Steve Borho
extdiff: add labels, read diff arguments from [merge-tools]...
r11184 rev1b = ''
Sune Foldager
extdiff: add 3-way diff for merge changesets...
r9512
fns_and_mtime = []
Brad Schick
extdiff: do single file diffs from the wc with no copy...
r5137
# If node2 in not the wc or there is >1 change, copy it
Sune Foldager
extdiff: add 3-way diff for merge changesets...
r9512 dir2root = ''
Steve Borho
extdiff: add labels, read diff arguments from [merge-tools]...
r11184 rev2 = ''
Sune Foldager
extdiff: add 3-way diff for merge changesets...
r9512 if node2:
dir2 = snapshot(ui, repo, modadd, node2, tmproot)[0]
Steve Borho
extdiff: add labels, read diff arguments from [merge-tools]...
r11184 rev2 = '@%d' % repo[node2].rev()
Sune Foldager
extdiff: add 3-way diff for merge changesets...
r9512 elif len(common) > 1:
Martin Geisler
extdiff: wrap long lines in docstring and comments...
r9945 #we only actually need to get the files to copy back to
#the working dir in this case (because the other cases
#are: diffing 2 revisions or single file -- in which case
#the file is already directly passed to the diff tool).
Sune Foldager
extdiff: add 3-way diff for merge changesets...
r9512 dir2, fns_and_mtime = snapshot(ui, repo, modadd, None, tmproot)
Vadim Gelfer
new extension: extdiff. allows to use external diff program.
r2333 else:
Brad Schick
extdiff: do single file diffs from the wc with no copy...
r5137 # This lets the diff tool open the changed file directly
dir2 = ''
dir2root = repo.root
Steve Borho
extdiff: add labels, read diff arguments from [merge-tools]...
r11184 label1a = rev1a
label1b = rev1b
label2 = rev2
Brad Schick
extdiff: do single file diffs from the wc with no copy...
r5137 # If only one change, diff the files instead of the directories
Sune Foldager
extdiff: add 3-way diff for merge changesets...
r9512 # Handle bogus modifies correctly by checking if the files exist
if len(common) == 1:
common_file = util.localpath(common.pop())
jfh
extdiff: use absolute paths for any temporary files...
r13758 dir1a = os.path.join(tmproot, dir1a, common_file)
Steve Borho
extdiff: add labels, read diff arguments from [merge-tools]...
r11184 label1a = common_file + rev1a
jfh
extdiff: use absolute paths for any temporary files...
r13758 if not os.path.isfile(dir1a):
Sune Foldager
extdiff: add 3-way diff for merge changesets...
r9512 dir1a = os.devnull
if do3way:
jfh
extdiff: use absolute paths for any temporary files...
r13758 dir1b = os.path.join(tmproot, dir1b, common_file)
Steve Borho
extdiff: add labels, read diff arguments from [merge-tools]...
r11184 label1b = common_file + rev1b
jfh
extdiff: use absolute paths for any temporary files...
r13758 if not os.path.isfile(dir1b):
Sune Foldager
extdiff: add 3-way diff for merge changesets...
r9512 dir1b = os.devnull
dir2 = os.path.join(dir2root, dir2, common_file)
Steve Borho
extdiff: add labels, read diff arguments from [merge-tools]...
r11184 label2 = common_file + rev2
Thomas Arendsen Hein
Remove trailing spaces, fix indentation
r5143
Martin Geisler
extdiff: wrap long lines in docstring and comments...
r9945 # Function to quote file/dir names in the argument string.
# When not operating in 3-way mode, an empty string is
# returned for parent2
Steve Borho
extdiff: add labels, read diff arguments from [merge-tools]...
r11184 replace = dict(parent=dir1a, parent1=dir1a, parent2=dir1b,
plabel1=label1a, plabel2=label1b,
Steven Stallion
extdiff: add repository root as a variable...
r14045 clabel=label2, child=dir2,
root=repo.root)
Sune Foldager
extdiff: add 3-way diff for merge changesets...
r9512 def quote(match):
key = match.group()[1:]
if not do3way and key == 'parent2':
return ''
return util.shellquote(replace[key])
# Match parent2 first, so 'parent1?' will match both parent1 and parent
Steven Stallion
extdiff: add repository root as a variable...
r14045 regex = '\$(parent2|parent1?|child|plabel1|plabel2|clabel|root)'
Sune Foldager
extdiff: add 3-way diff for merge changesets...
r9512 if not do3way and not re.search(regex, args):
args += ' $parent1 $child'
args = re.sub(regex, quote, args)
cmdline = util.shellquote(diffcmd) + ' ' + args
Martin Geisler
do not attempt to translate ui.debug output
r9467 ui.debug('running %r in %s\n' % (cmdline, tmproot))
Idan Kamara
extdiff: use ui out descriptor when calling util.system
r14739 util.system(cmdline, cwd=tmproot, out=ui.fout)
Fabio Zadrozny <fabiofz at gmail dot com>
Propagating changes back to working dirs when changing files in external
r6103
for copy_fn, working_fn, mtime in fns_and_mtime:
Patrick Mezard
extdiff: fix broken symlinks handling (issue1909)
r14021 if os.lstat(copy_fn).st_mtime != mtime:
Martin Geisler
do not attempt to translate ui.debug output
r9467 ui.debug('file changed while diffing. '
'Overwriting: %s (src: %s)\n' % (working_fn, copy_fn))
Fabio Zadrozny <fabiofz at gmail dot com>
Propagating changes back to working dirs when changing files in external
r6103 util.copyfile(copy_fn, working_fn)
Vadim Gelfer
new extension: extdiff. allows to use external diff program.
r2333 return 1
finally:
ui.note(_('cleaning up temp directory\n'))
shutil.rmtree(tmproot)
def extdiff(ui, repo, *pats, **opts):
'''use external program to diff repository (or selected files)
Show differences between revisions for the specified files, using
Martin Geisler
Change double spaces to single spaces in help texts.
r7983 an external program. The default program used is diff, with
Vadim Gelfer
extdiff: fix bugs. add test.
r2906 default options "-Npru".
Martin Geisler
help texts: write command line switches as -a/--abc
r8076 To select a different program, use the -p/--program option. The
program will be passed the names of two directories to compare. To
pass additional options to the program, use -o/--option. These
will be passed before the names of the directories to compare.
Vadim Gelfer
new extension: extdiff. allows to use external diff program.
r2333
Martin Geisler
extdiff: word-wrap help texts at 70 characters
r7990 When two revision arguments are given, then changes are shown
between those revisions. If only one revision is specified then
that revision is compared to the working directory, and, when no
revisions are specified, the working directory files are compared
to its parent.'''
Peter Arrenbrecht
extdiff: fix defaulting to "diff" if no --program is given
r9519 program = opts.get('program')
option = opts.get('option')
if not program:
program = 'diff'
option = option or ['-Npru']
TK Soh
extdiff: use the default option only if the default program is used
r3129 return dodiff(ui, repo, program, option, pats, opts)
Vadim Gelfer
new extension: extdiff. allows to use external diff program.
r2333
cmdtable = {
"extdiff":
(extdiff,
FUJIWARA Katsunori
help: show value requirement and multiple occurrence of options...
r11321 [('p', 'program', '',
_('comparison program to run'), _('CMD')),
('o', 'option', [],
_('pass option to comparison program'), _('OPT')),
('r', 'rev', [],
_('revision'), _('REV')),
('c', 'change', '',
_('change made by revision'), _('REV')),
Benoit Boissinot
refactor options from cmdtable...
r5147 ] + commands.walkopts,
Vadim Gelfer
new extension: extdiff. allows to use external diff program.
r2333 _('hg extdiff [OPT]... [FILE]...')),
}
def uisetup(ui):
for cmd, path in ui.configitems('extdiff'):
Brendan Cully
Improve extdiff configuration....
r5245 if cmd.startswith('cmd.'):
cmd = cmd[4:]
Matt Mackall
many, many trivial check-code fixups
r10282 if not path:
path = cmd
Brendan Cully
Improve extdiff configuration....
r5245 diffopts = ui.config('extdiff', 'opts.' + cmd, '')
diffopts = diffopts and [diffopts] or []
elif cmd.startswith('opts.'):
continue
else:
# command = path opts
if path:
diffopts = shlex.split(path)
path = diffopts.pop(0)
else:
path, diffopts = cmd, []
Steve Borho
extdiff: add labels, read diff arguments from [merge-tools]...
r11184 # look for diff arguments in [diff-tools] then [merge-tools]
if diffopts == []:
args = ui.config('diff-tools', cmd+'.diffargs') or \
ui.config('merge-tools', cmd+'.diffargs')
if args:
diffopts = shlex.split(args)
TK Soh
extdiff: make new diff commands pick up their options correctly
r2959 def save(cmd, path, diffopts):
Vadim Gelfer
new extension: extdiff. allows to use external diff program.
r2333 '''use closure to save diff command to use'''
def mydiff(ui, repo, *pats, **opts):
Sune Foldager
extdiff: respect --option in command aliases (issue949)
r9956 return dodiff(ui, repo, path, diffopts + opts['option'],
pats, opts)
Martin Geisler
extdiff: prevent exception on double-translation...
r9941 doc = _('''\
Martin Geisler
extdiff: fix indentation and use gettext
r9050 use %(path)s to diff repository (or selected files)
Vadim Gelfer
new extension: extdiff. allows to use external diff program.
r2333
Martin Geisler
extdiff: wrap long lines in docstring and comments...
r9945 Show differences between revisions for the specified files, using
the %(path)s program.
Vadim Gelfer
new extension: extdiff. allows to use external diff program.
r2333
Martin Geisler
extdiff: wrap long lines in docstring and comments...
r9945 When two revision arguments are given, then changes are shown
between those revisions. If only one revision is specified then
that revision is compared to the working directory, and, when no
revisions are specified, the working directory files are compared
to its parent.\
Martin Geisler
extdiff: fix indentation and use gettext
r9050 ''') % dict(path=util.uirepr(path))
Martin Geisler
extdiff: prevent exception on double-translation...
r9941
# We must translate the docstring right away since it is
# used as a format string. The string will unfortunately
# be translated again in commands.helpcmd and this will
# fail when the docstring contains non-ASCII characters.
# Decoding the string to a Unicode string here (using the
# right encoding) prevents that.
mydiff.__doc__ = doc.decode(encoding.encoding)
Vadim Gelfer
new extension: extdiff. allows to use external diff program.
r2333 return mydiff
TK Soh
extdiff: make new diff commands pick up their options correctly
r2959 cmdtable[cmd] = (save(cmd, path, diffopts),
Vadim Gelfer
new extension: extdiff. allows to use external diff program.
r2333 cmdtable['extdiff'][1][1:],
Thomas Arendsen Hein
Updated command tables in commands.py and hgext extensions....
r4730 _('hg %s [OPTION]... [FILE]...') % cmd)
Siddharth Agarwal
commands: don't infer repo for commands like update (issue2748)...
r17773
commands.inferrepo += " extdiff"