##// END OF EJS Templates
perf: call _generatechangelog() instead of group()...
perf: call _generatechangelog() instead of group() Now that we have a separate function for generating just the changelog bits, the perf command should call it so it gets more accurate behavior. This changes the results of this command on my hg repo significantly: ! wall 1.390502 comb 1.390000 user 1.370000 sys 0.020000 (best of 8) ! wall 1.768750 comb 1.760000 user 1.760000 sys 0.000000 (best of 6) Profiling seems to reveal that ~20% of execution time is spent in progress bar accounting and printing! If we run with progress.disable=true: ! wall 1.639134 comb 1.650000 user 1.630000 sys 0.020000 (best of 7) A nice speedup. But profiling still shows a good chunk of time being spent in progress bar accounting code. The reason is that the progress bar is conditionally enabled via an argument to cgpacker.group(). The previous code in perf.py calling into group() did not enable the progress bar but _generatechangelog() always does. I think it is important for the perf* commands to capture real-world use cases. And this code always runs with an active progress bar. So the regression is acceptable. That being said, terminal printing performance can vary substantially. I don't think perf* commands should test terminal printing unless explicitly desired. So I've disabled progress bar printing in this command. Differential Revision: https://phab.mercurial-scm.org/D4134

File last commit:

r38234:a1c0873a default
r39013:a1f69477 default
Show More
fuzzutil.cc
27 lines | 922 B | text/x-c | CppLexer
Augie Fackler
fuzz: extract some common utilities and use modern C++ idioms...
r38191 #include "fuzzutil.h"
Yuya Nishihara
fuzz: fix use of undeclared function memcpy()
r38234 #include <cstring>
Augie Fackler
fuzz: extract some common utilities and use modern C++ idioms...
r38191 #include <utility>
Augie Fackler
fuzzutil: make it possible to use absl when C++17 isn't supported...
r38192 contrib::optional<two_inputs> SplitInputs(const uint8_t *Data, size_t Size)
Augie Fackler
fuzz: extract some common utilities and use modern C++ idioms...
r38191 {
if (!Size) {
Augie Fackler
fuzzutil: make it possible to use absl when C++17 isn't supported...
r38192 return contrib::nullopt;
Augie Fackler
fuzz: extract some common utilities and use modern C++ idioms...
r38191 }
// figure out a random point in [0, Size] to split our input.
size_t left_size = (Data[0] / 255.0) * (Size - 1);
// Copy inputs to new allocations so if bdiff over-reads
// AddressSanitizer can detect it.
std::unique_ptr<char[]> left(new char[left_size]);
Yuya Nishihara
fuzz: fix use of undeclared function memcpy()
r38234 std::memcpy(left.get(), Data + 1, left_size);
Augie Fackler
fuzz: extract some common utilities and use modern C++ idioms...
r38191 // right starts at the next byte after left ends
size_t right_size = Size - (left_size + 1);
std::unique_ptr<char[]> right(new char[right_size]);
Yuya Nishihara
fuzz: fix use of undeclared function memcpy()
r38234 std::memcpy(right.get(), Data + 1 + left_size, right_size);
Augie Fackler
fuzz: extract some common utilities and use modern C++ idioms...
r38191 LOG(2) << "inputs are " << left_size << " and " << right_size
<< " bytes" << std::endl;
two_inputs result = {std::move(right), right_size, std::move(left),
left_size};
return result;
}