##// END OF EJS Templates
exchange: move disabling of rev-branch-cache bundle part out of narrow...
exchange: move disabling of rev-branch-cache bundle part out of narrow I'm attempting to refactor changegroup code in order to better support alternate storage backends. The narrow extension is performing a lot of monkeypatching to this code and it is making it difficult to reason about how everything works. I'm reasonably certain I would be unable to abstract storage without requiring extensive rework of narrow. I believe it is less effort to move narrow code into core so it can be accounted for when changegroup code is refactored. So I'll be doing that. The first part of this is integrating the disabling of the cache:rev-branch-cache bundle2 part into core. This doesn't seem like it is related to changegroup, but narrow's modifications to changegroup are invasive and also require taking its code for bundle generation and exchange into core in order for the changegroup code to work. Differential Revision: https://phab.mercurial-scm.org/D4007

File last commit:

r36121:9b5df6e1 default
r38813:ab765bc4 default
Show More
TODO.rst
37 lines | 1.7 KiB | text/x-rst | RstLexer
Augie Fackler
narrow: add a TODO document...
r36121 Integration with the share extension needs improvement. Right now
we've seen some odd bugs, and the way we modify the contents of the
.hg/shared file is unfortunate. See wrappostshare() and unsharenarrowspec().
Resolve commentary on narrowrepo.wraprepo.narrowrepository.status
about the filtering of status being done at an awkward layer. This
came up the import to hgext, but nobody's got concrete improvement
ideas as of then.
Fold most (or preferably all) of narrowrevlog.py into core.
Address commentary in narrowrevlog.excludedmanifestrevlog.add -
specifically we should improve the collaboration with core so that
add() never gets called on an excluded directory and we can improve
the stand-in to raise a ProgrammingError.
Figure out how to correctly produce narrowmanifestrevlog and
narrowfilelog instances instead of monkeypatching regular revlogs at
runtime to our subclass. Even better, merge the narrowing logic
directly into core.
Reason more completely about rename-filtering logic in
narrowfilelog. There could be some surprises lurking there.
Formally document the narrowspec format. Unify with sparse, if at all
possible. For bonus points, unify with the server-specified narrowspec
format.
narrowrepo.setnarrowpats() or narrowspec.save() need to make sure
they're holding the wlock.
Implement a simple version of the expandnarrow wireproto command for
core. Having configurable shorthands for narrowspecs has been useful
at Google (and sparse has a similar feature from Facebook), so it
probably makes sense to implement the feature in core. (Google's
handler is entirely custom to Google, with a custom format related to
bazel's build language, so it's not in the narrowhg distribution.)