upstream/mercurial-mirror Files · contrib/showstack.py

errors: catch urllib errors specifically instead of using safehasattr()...

errors: catch urllib errors specifically instead of using safehasattr() Before this patch, we would catch `IOError` and `OSError` and check if the instance had a `.code` member (indicates `HTTPError`) or a `.reason` member (indicates the more generic `URLError`). It seems to me that can simply catch those exception specifically instead, so that's what this code does. The existing code is from (commands: report http exceptions nicely, 2005-06-17), so I suspect it's just that there was no `urllib2` (where `URLError` lives) back then. The old code mentioned `SSLError` in a comment. The new code does *not* try to catch that. The documentation for `ssl.SSLError` says that it has a `.reason` property, but `python -c 'import ssl; print(dir(ssl.SSLError("foo", Exception("bar"))))` doesn't mention that property on either Python 2 or Python 3 on my system. It also seems that `sslutil` is pretty careful about converting `ssl.SSLError` to `error.Abort`. It also is carefult to not assume that instances of the exception have a `.reason`. So I at least don't want to catch `ssl.SSLError` and handle it the same way as `URLError` because that would likely result in a crash. I also wonder if we don't need to handle it at all (because `sslutil` might handle all the cases). It's now early in the release cycle, so perhaps we can just see how it goes? Differential Revision: https://phab.mercurial-scm.org/D9318

Augie Fackler - - Load All Authors

File last commit:

r43346:2372284d default


                r46442:ae00e170

default

Download file

             showstack.py
        
                    31 lines
            
             | 734 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / contrib / showstack.py
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Matt Mackall
    
contrib: add showstack extension...

              r26123
            
      # showstack.py - extension to dump a Python stack trace on signal

      #

      # binds to both SIGQUIT (Ctrl-\) and SIGINFO (Ctrl-T on BSDs)

        Gregory Szorc
    
showstack: use raw docstring...

              r41689
            
      r"""dump stack trace when receiving SIGQUIT (Ctrl-\) or SIGINFO (Ctrl-T on BSDs)

        Boris Feld
    
showstack: add an extension docstring...

              r35674
            
      """

        Matt Mackall
    
contrib: add showstack extension...

              r26123
            
        Augie Fackler
    
showstack: also handle SIGALRM...

              r40072
            
      from __future__ import absolute_import, print_function

        Pulkit Goyal
    
showstack: use absolute_import

              r28522
            
      import signal

      import sys

      import traceback

        Matt Mackall
    
contrib: add showstack extension...

              r26123
            
        Augie Fackler
    
formatting: blacken the codebase...

              r43346
            
        Matt Mackall
    
contrib: add showstack extension...

              r26123
            
      def sigshow(*args):

          sys.stderr.write("\n")

          traceback.print_stack(args[1], limit=10, file=sys.stderr)

          sys.stderr.write("----\n")

        Augie Fackler
    
formatting: blacken the codebase...

              r43346
            
        Augie Fackler
    
showstack: also handle SIGALRM...

              r40072
            
      def sigexit(*args):

          sigshow(*args)

          print('alarm!')

          sys.exit(1)

        Augie Fackler
    
formatting: blacken the codebase...

              r43346
            
        Matt Mackall
    
contrib: add showstack extension...

              r26123
            
      def extsetup(ui):

          signal.signal(signal.SIGQUIT, sigshow)

        Augie Fackler
    
showstack: also handle SIGALRM...

              r40072
            
          signal.signal(signal.SIGALRM, sigexit)

        Matt Mackall
    
contrib: add showstack extension...

              r26123
            
          try:

              signal.signal(signal.SIGINFO, sigshow)

          except AttributeError:

              pass

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Matt Mackall contrib: add showstack extension...	r26123	# showstack.py - extension to dump a Python stack trace on signal
		#
		# binds to both SIGQUIT (Ctrl-\) and SIGINFO (Ctrl-T on BSDs)
Gregory Szorc showstack: use raw docstring...	r41689	r"""dump stack trace when receiving SIGQUIT (Ctrl-\) or SIGINFO (Ctrl-T on BSDs)
Boris Feld showstack: add an extension docstring...	r35674	"""
Matt Mackall contrib: add showstack extension...	r26123
Augie Fackler showstack: also handle SIGALRM...	r40072	from __future__ import absolute_import, print_function
Pulkit Goyal showstack: use absolute_import	r28522	import signal
		import sys
		import traceback
Matt Mackall contrib: add showstack extension...	r26123
Augie Fackler formatting: blacken the codebase...	r43346
Matt Mackall contrib: add showstack extension...	r26123	def sigshow(*args):
		sys.stderr.write("\n")
		traceback.print_stack(args[1], limit=10, file=sys.stderr)
		sys.stderr.write("----\n")

Augie Fackler formatting: blacken the codebase...	r43346
Augie Fackler showstack: also handle SIGALRM...	r40072	def sigexit(*args):
		sigshow(*args)
		print('alarm!')
		sys.exit(1)

Augie Fackler formatting: blacken the codebase...	r43346
Matt Mackall contrib: add showstack extension...	r26123	def extsetup(ui):
		signal.signal(signal.SIGQUIT, sigshow)
Augie Fackler showstack: also handle SIGALRM...	r40072	signal.signal(signal.SIGALRM, sigexit)
Matt Mackall contrib: add showstack extension...	r26123	try:
		signal.signal(signal.SIGINFO, sigshow)
		except AttributeError:
		pass