##// END OF EJS Templates
upstream » mercurial-mirror
RSS

Clone from https://www.mercurial-scm.org/repo/hg-all

errors: catch urllib errors specifically instead of using safehasattr()...
errors: catch urllib errors specifically instead of using safehasattr() Before this patch, we would catch `IOError` and `OSError` and check if the instance had a `.code` member (indicates `HTTPError`) or a `.reason` member (indicates the more generic `URLError`). It seems to me that can simply catch those exception specifically instead, so that's what this code does. The existing code is from fbe8834923c5 (commands: report http exceptions nicely, 2005-06-17), so I suspect it's just that there was no `urllib2` (where `URLError` lives) back then. The old code mentioned `SSLError` in a comment. The new code does *not* try to catch that. The documentation for `ssl.SSLError` says that it has a `.reason` property, but `python -c 'import ssl; print(dir(ssl.SSLError("foo", Exception("bar"))))` doesn't mention that property on either Python 2 or Python 3 on my system. It also seems that `sslutil` is pretty careful about converting `ssl.SSLError` to `error.Abort`. It also is carefult to not assume that instances of the exception have a `.reason`. So I at least don't want to catch `ssl.SSLError` and handle it the same way as `URLError` because that would likely result in a crash. I also wonder if we don't need to handle it at all (because `sslutil` might handle all the cases). It's now early in the release cycle, so perhaps we can just see how it goes? Differential Revision: https://phab.mercurial-scm.org/D9318
Yuya Nishihara - - Load All Authors

File last commit:

r45238:9fc9526e default
r46442:ae00e170 default
Show More
Cargo.toml
22 lines | 474 B | application/toml | TOMLLexer
/ rust / chg / Cargo.toml
History | Source | Raw |Copy content |Copy permalink
Yuya Nishihara
rust-chg: add project skeleton...
 r40003 [package]
name = "chg"
version = "0.1.0"
authors = ["Yuya Nishihara <yuya@tcha.org>"]
description = "Client for Mercurial command server with cHg extension"
license = "GPL-2.0+"
Yuya Nishihara
rust-chg: upgrade to 2018 edition and remove useless extern crates...
 r45179 edition = "2018"
Yuya Nishihara
rust-chg: add project skeleton...
 r40003
[dependencies]
Yuya Nishihara
rust-chg: upgrade to futures-0.3 based libraries...
 r45231 async-trait = "0.1"
bytes = "0.5"
futures = "0.3"
Yuya Nishihara
rust-chg: add project skeleton...
 r40003 libc = "0.2"
Yuya Nishihara
rust-chg: depend on log and tokio_timer...
 r40323 log = { version = "0.4", features = ["std"] }
Yuya Nishihara
rust-chg: upgrade to futures-0.3 based libraries...
 r45231 tokio-hglib = "0.3"
[dependencies.tokio]
version = "0.2"
features = ["rt-core", "io-util", "time", "process", "macros"]
Yuya Nishihara
rust-chg: add project skeleton...
 r40003
[build-dependencies]
cc = "1.0"