##// END OF EJS Templates
inotify: server: new data structure to keep track of changes....
inotify: server: new data structure to keep track of changes. == Rationale for the new structure == Current structure was a dictionary tree. One directory was tracked as a dictionary: - keys: file/subdir name - values: - for a file, the status (a/r/m/...) - for a subdir, the directory representing the subdir It allowed efficient lookups, no matter of the type of the terminal leaf: for part in path.split('/'): tree = tree[part] However, there is no way to represent a directory and a file with the same name because keys are conflicting in the dictionary. Concrete example: Initial state: root dir |- foo (file) |- bar (file) # data state is: {'foo': 'n', 'bar': 'n'} Remove foo: root dir |- bar (file) # Data becomes {'foo': 'r'} until next commit. Add foo, as a directory, and foo/barbar file: root dir |- bar (file) |-> foo (dir) |- barbar (file) # New state should be represented as: {'foo': {'barbar': 'a'}, 'bar': 'n'} however, the key "foo" is already used and represents the old file. The dirstate: D foo A foo/barbar cannot be represented, hence the need for a new structure. == The new structure == 'directory' class. Represents one directory level. * Notable attributes: Two dictionaries: - 'files' Maps filename -> status for the current dir. - 'dirs' Maps subdir's name -> directory object representing the subdir * methods - walk(), formerly server.walk - lookup(), old server.lookup - dir(), old server.dir This new class allows embedding all the tree walks/lookups in its own class, instead of having everything mixed together in server. Incidently, since files and directories are not stored in the same dictionaries, we are solving the previous key conflict problem. The small drawback is that lookup operation is a bit more complex: for a path a/b/c/d/e we have to check twice the leaf, if e is a directory or a file.

File last commit:

r8167:6c82beaa default
r9115:b55d4471 default
Show More
test-changelog-exec
32 lines | 571 B | text/plain | TextLexer
/ tests / test-changelog-exec
Alexis S. L. Carvalho
Avoid adding to the changelog executable files added by the second parent....
r5227 #!/bin/sh
# b51a8138292a introduced a regression where we would mention in the
# changelog executable files added by the second parent of a merge.
# Test that that doesn't happen anymore
"$TESTDIR/hghave" execbit || exit 80
hg init repo
cd repo
echo foo > foo
Martin Geisler
tests: removed redundant "-d '0 0'" from test scripts...
r8167 hg ci -qAm 'add foo'
Alexis S. L. Carvalho
Avoid adding to the changelog executable files added by the second parent....
r5227
echo bar > bar
chmod +x bar
Martin Geisler
tests: removed redundant "-d '0 0'" from test scripts...
r8167 hg ci -qAm 'add bar'
Alexis S. L. Carvalho
Avoid adding to the changelog executable files added by the second parent....
r5227 echo '% manifest of p2:'
hg manifest
echo
hg up -qC 0
echo >> foo
Martin Geisler
tests: removed redundant "-d '0 0'" from test scripts...
r8167 hg ci -m 'change foo'
Alexis S. L. Carvalho
Avoid adding to the changelog executable files added by the second parent....
r5227 echo '% manifest of p1:'
hg manifest
hg merge
Martin Geisler
tests: removed redundant "-d '0 0'" from test scripts...
r8167 hg ci -m 'merge'
Alexis S. L. Carvalho
Avoid adding to the changelog executable files added by the second parent....
r5227
echo '% this should not mention bar:'
hg tip -v
hg debugindex .hg/store/data/bar.i