##// END OF EJS Templates
inotify: server: new data structure to keep track of changes....
inotify: server: new data structure to keep track of changes. == Rationale for the new structure == Current structure was a dictionary tree. One directory was tracked as a dictionary: - keys: file/subdir name - values: - for a file, the status (a/r/m/...) - for a subdir, the directory representing the subdir It allowed efficient lookups, no matter of the type of the terminal leaf: for part in path.split('/'): tree = tree[part] However, there is no way to represent a directory and a file with the same name because keys are conflicting in the dictionary. Concrete example: Initial state: root dir |- foo (file) |- bar (file) # data state is: {'foo': 'n', 'bar': 'n'} Remove foo: root dir |- bar (file) # Data becomes {'foo': 'r'} until next commit. Add foo, as a directory, and foo/barbar file: root dir |- bar (file) |-> foo (dir) |- barbar (file) # New state should be represented as: {'foo': {'barbar': 'a'}, 'bar': 'n'} however, the key "foo" is already used and represents the old file. The dirstate: D foo A foo/barbar cannot be represented, hence the need for a new structure. == The new structure == 'directory' class. Represents one directory level. * Notable attributes: Two dictionaries: - 'files' Maps filename -> status for the current dir. - 'dirs' Maps subdir's name -> directory object representing the subdir * methods - walk(), formerly server.walk - lookup(), old server.lookup - dir(), old server.dir This new class allows embedding all the tree walks/lookups in its own class, instead of having everything mixed together in server. Incidently, since files and directories are not stored in the same dictionaries, we are solving the previous key conflict problem. The small drawback is that lookup operation is a bit more complex: for a path a/b/c/d/e we have to check twice the leaf, if e is a directory or a file.

File last commit:

r8721:2816239e default
r9115:b55d4471 default
Show More
test-fncache.out
71 lines | 1.2 KiB | text/plain | TextLexer
Adrian Buehlmann
add test-fncache
r7290 % init repo1
% add a; ci
adding a
% cat .hg/store/fncache
data/a.i
% add a.i/b; ci
adding a.i/b
% cat .hg/store/fncache
data/a.i
data/a.i.hg/b.i
% add a.i.hg/c; ci
adding a.i.hg/c
% cat .hg/store/fncache
data/a.i
data/a.i.hg/b.i
data/a.i.hg.hg/c.i
% hg verify
checking changesets
checking manifests
crosschecking files in changesets and manifests
checking files
3 files, 3 changesets, 3 total revisions
% rm .hg/store/fncache
% hg verify
checking changesets
checking manifests
crosschecking files in changesets and manifests
checking files
data/a.i@0: missing revlog!
Benoit Boissinot
filelog encoding: move the encoding/decoding into store...
r8531 data/a.i.hg/c.i@2: missing revlog!
data/a.i/b.i@1: missing revlog!
Adrian Buehlmann
add test-fncache
r7290 3 files, 3 changesets, 3 total revisions
3 integrity errors encountered!
(first damaged changeset appears to be 0)
Benoit Boissinot
store encoding: .i/.d encoding for non-store repo (broken by 810387f59696)
r8633 % non store repo
adding tst.d/foo
Will Maier
test-fncache: Use find instead of ls -R....
r8721 .hg
.hg/00changelog.i
.hg/00manifest.i
.hg/data
.hg/data/tst.d.hg
.hg/data/tst.d.hg/foo.i
.hg/dirstate
.hg/requires
.hg/undo
.hg/undo.branch
.hg/undo.dirstate
Benoit Boissinot
store encoding: .i/.d encoding for non-store repo (broken by 810387f59696)
r8633 % non fncache repo
adding tst.d/Foo
Will Maier
test-fncache: Use find instead of ls -R....
r8721 .hg
.hg/00changelog.i
.hg/dirstate
.hg/requires
.hg/store
.hg/store/00changelog.i
.hg/store/00manifest.i
.hg/store/data
.hg/store/data/tst.d.hg
.hg/store/data/tst.d.hg/_foo.i
.hg/store/undo
.hg/undo.branch
.hg/undo.dirstate