##// END OF EJS Templates
inotify: server: new data structure to keep track of changes....
inotify: server: new data structure to keep track of changes. == Rationale for the new structure == Current structure was a dictionary tree. One directory was tracked as a dictionary: - keys: file/subdir name - values: - for a file, the status (a/r/m/...) - for a subdir, the directory representing the subdir It allowed efficient lookups, no matter of the type of the terminal leaf: for part in path.split('/'): tree = tree[part] However, there is no way to represent a directory and a file with the same name because keys are conflicting in the dictionary. Concrete example: Initial state: root dir |- foo (file) |- bar (file) # data state is: {'foo': 'n', 'bar': 'n'} Remove foo: root dir |- bar (file) # Data becomes {'foo': 'r'} until next commit. Add foo, as a directory, and foo/barbar file: root dir |- bar (file) |-> foo (dir) |- barbar (file) # New state should be represented as: {'foo': {'barbar': 'a'}, 'bar': 'n'} however, the key "foo" is already used and represents the old file. The dirstate: D foo A foo/barbar cannot be represented, hence the need for a new structure. == The new structure == 'directory' class. Represents one directory level. * Notable attributes: Two dictionaries: - 'files' Maps filename -> status for the current dir. - 'dirs' Maps subdir's name -> directory object representing the subdir * methods - walk(), formerly server.walk - lookup(), old server.lookup - dir(), old server.dir This new class allows embedding all the tree walks/lookups in its own class, instead of having everything mixed together in server. Incidently, since files and directories are not stored in the same dictionaries, we are solving the previous key conflict problem. The small drawback is that lookup operation is a bit more complex: for a path a/b/c/d/e we have to check twice the leaf, if e is a directory or a file.

File last commit:

r8452:cb93eee1 default
r9115:b55d4471 default
Show More
test-hgweb-filelog
51 lines | 994 B | text/plain | TextLexer
/ tests / test-hgweb-filelog
Martin Geisler
tests: add missing interpreter lines
r8452 #!/bin/sh
Dirkjan Ochtman
hgweb: conditionally show file logs for deleted files
r7300 hg init test
cd test
echo b > b
hg ci -Am "b"
echo a > a
hg ci -Am "first a"
hg rm a
hg ci -m "del a"
echo b > a
hg ci -Am "second a"
hg rm a
hg ci -m "del2 a"
Benoit Boissinot
web: use the correct filectx in filelog
r7612 hg mv b c
hg ci -m "mv b"
Stefan Ring
Improved hgweb test....
r7624 echo c >> c
hg ci -m "change c"
Dirkjan Ochtman
hgweb: conditionally show file logs for deleted files
r7300 hg log -p
hg serve -n test -p $HGPORT -d --pid-file=hg.pid -E errors.log
cat hg.pid >> $DAEMON_PIDS
echo % tip - two revisions
("$TESTDIR/get-with-headers.py" localhost:$HGPORT '/log/tip/a')
echo % second version - two revisions
("$TESTDIR/get-with-headers.py" localhost:$HGPORT '/log/3/a')
echo % first deleted - one revision
("$TESTDIR/get-with-headers.py" localhost:$HGPORT '/log/2/a')
echo % first version - one revision
("$TESTDIR/get-with-headers.py" localhost:$HGPORT '/log/1/a')
echo % before addition - error
("$TESTDIR/get-with-headers.py" localhost:$HGPORT '/log/0/a')
Benoit Boissinot
web: use the correct filectx in filelog
r7612 echo % should show base link, use spartan because it shows it
("$TESTDIR/get-with-headers.py" localhost:$HGPORT '/log/tip/c?style=spartan')
Dirkjan Ochtman
hgweb: conditionally show file logs for deleted files
r7300 echo % errors
cat errors.log