##// END OF EJS Templates
inotify: server: new data structure to keep track of changes....
inotify: server: new data structure to keep track of changes. == Rationale for the new structure == Current structure was a dictionary tree. One directory was tracked as a dictionary: - keys: file/subdir name - values: - for a file, the status (a/r/m/...) - for a subdir, the directory representing the subdir It allowed efficient lookups, no matter of the type of the terminal leaf: for part in path.split('/'): tree = tree[part] However, there is no way to represent a directory and a file with the same name because keys are conflicting in the dictionary. Concrete example: Initial state: root dir |- foo (file) |- bar (file) # data state is: {'foo': 'n', 'bar': 'n'} Remove foo: root dir |- bar (file) # Data becomes {'foo': 'r'} until next commit. Add foo, as a directory, and foo/barbar file: root dir |- bar (file) |-> foo (dir) |- barbar (file) # New state should be represented as: {'foo': {'barbar': 'a'}, 'bar': 'n'} however, the key "foo" is already used and represents the old file. The dirstate: D foo A foo/barbar cannot be represented, hence the need for a new structure. == The new structure == 'directory' class. Represents one directory level. * Notable attributes: Two dictionaries: - 'files' Maps filename -> status for the current dir. - 'dirs' Maps subdir's name -> directory object representing the subdir * methods - walk(), formerly server.walk - lookup(), old server.lookup - dir(), old server.dir This new class allows embedding all the tree walks/lookups in its own class, instead of having everything mixed together in server. Incidently, since files and directories are not stored in the same dictionaries, we are solving the previous key conflict problem. The small drawback is that lookup operation is a bit more complex: for a path a/b/c/d/e we have to check twice the leaf, if e is a directory or a file.

File last commit:

r9110:561ff8d9 default
r9115:b55d4471 default
Show More
test-mq-merge.out
25 lines | 537 B | text/plain | TextLexer
/ tests / test-mq-merge.out
Patrick Mezard
Add test for issue 529 - "mq aborts when merging patch deleting files".
r4333 adding a
adding b
copy .hg/patches to .hg/patches.1
1 files updated, 0 files merged, 0 files removed, 0 files unresolved
M b
Dirkjan Ochtman
warn about new heads on commit (issue842)
r6336 created new head
Patrick Mezard
Add test for issue 529 - "mq aborts when merging patch deleting files".
r4333 a
b
merging with queue at: .hg/patches.1
applying rm_a
Martin Geisler
mq: lowercase output...
r7627 now at: rm_a
Patrick Mezard
Add test for issue 529 - "mq aborts when merging patch deleting files".
r4333 b
Mads Kiilerich
mq: qpop now tells which patches are popped...
r9110 popping rm_a
popping .hg.patches.merge.marker
Martin Geisler
mq: lowercase output...
r7627 patch queue now empty
Patrick Mezard
test-mq-merge: test mq merge and explicit patch queue
r6628
% init t2
adding a
1 files updated, 0 files merged, 0 files removed, 0 files unresolved
% create the reference queue
1 files updated, 0 files merged, 0 files removed, 0 files unresolved
% merge
merging with queue at refqueue
applying patcha
Martin Geisler
mq: lowercase output...
r7627 now at: patcha