##// END OF EJS Templates
inotify: server: new data structure to keep track of changes....
inotify: server: new data structure to keep track of changes. == Rationale for the new structure == Current structure was a dictionary tree. One directory was tracked as a dictionary: - keys: file/subdir name - values: - for a file, the status (a/r/m/...) - for a subdir, the directory representing the subdir It allowed efficient lookups, no matter of the type of the terminal leaf: for part in path.split('/'): tree = tree[part] However, there is no way to represent a directory and a file with the same name because keys are conflicting in the dictionary. Concrete example: Initial state: root dir |- foo (file) |- bar (file) # data state is: {'foo': 'n', 'bar': 'n'} Remove foo: root dir |- bar (file) # Data becomes {'foo': 'r'} until next commit. Add foo, as a directory, and foo/barbar file: root dir |- bar (file) |-> foo (dir) |- barbar (file) # New state should be represented as: {'foo': {'barbar': 'a'}, 'bar': 'n'} however, the key "foo" is already used and represents the old file. The dirstate: D foo A foo/barbar cannot be represented, hence the need for a new structure. == The new structure == 'directory' class. Represents one directory level. * Notable attributes: Two dictionaries: - 'files' Maps filename -> status for the current dir. - 'dirs' Maps subdir's name -> directory object representing the subdir * methods - walk(), formerly server.walk - lookup(), old server.lookup - dir(), old server.dir This new class allows embedding all the tree walks/lookups in its own class, instead of having everything mixed together in server. Incidently, since files and directories are not stored in the same dictionaries, we are solving the previous key conflict problem. The small drawback is that lookup operation is a bit more complex: for a path a/b/c/d/e we have to check twice the leaf, if e is a directory or a file.

File last commit:

r7138:0df09887 default
r9115:b55d4471 default
Show More
test-permissions
27 lines | 517 B | text/plain | TextLexer
Matt Mackall
Add permissions handling test
r1497 #!/bin/sh
Benoit Boissinot
testcase for issue705 (fixed by 316ce5e85b3e)
r5214 hg init t
cd t
Matt Mackall
Add permissions handling test
r1497 echo foo > a
hg add a
Thomas Arendsen Hein
Use 'hg ci -d "1000000 0"' in tests to circumvent problem with leading zero....
r1933 hg commit -m "1" -d "1000000 0"
Matt Mackall
Add permissions handling test
r1497 hg verify
Benoit Boissinot
switch to the .hg/store layout, fix the tests
r3853 chmod -r .hg/store/data/a.i
Matt Mackall
Add permissions handling test
r1497 hg verify 2>/dev/null || echo verify failed
Benoit Boissinot
switch to the .hg/store layout, fix the tests
r3853 chmod +r .hg/store/data/a.i
Matt Mackall
Add permissions handling test
r1497 hg verify 2>/dev/null || echo verify failed
Benoit Boissinot
switch to the .hg/store layout, fix the tests
r3853 chmod -w .hg/store/data/a.i
Matt Mackall
Add permissions handling test
r1497 echo barber > a
Thomas Arendsen Hein
Use 'hg ci -d "1000000 0"' in tests to circumvent problem with leading zero....
r1933 hg commit -m "2" -d "1000000 0" 2>/dev/null || echo commit failed
Alexis S. L. Carvalho
test-permissions: add a chmod +w to allow the directory to be removed
r5519 chmod -w .
Benoit Boissinot
fix test-permissions output
r5215 hg diff --nodates
Alexis S. L. Carvalho
test-permissions: add a chmod +w to allow the directory to be removed
r5519 chmod +w .
Benoit Boissinot
dirstate.walk: skip unreadable directories (issue1213)...
r7099
chmod +w .hg/store/data/a.i
mkdir dir
touch dir/a
hg status
chmod -rx dir
hg status
Benoit Boissinot
test-permission: put sane permissions at the end of the test...
r7138 # reenable perm to allow deletion
chmod +rx dir