##// END OF EJS Templates
inotify: server: new data structure to keep track of changes....
inotify: server: new data structure to keep track of changes. == Rationale for the new structure == Current structure was a dictionary tree. One directory was tracked as a dictionary: - keys: file/subdir name - values: - for a file, the status (a/r/m/...) - for a subdir, the directory representing the subdir It allowed efficient lookups, no matter of the type of the terminal leaf: for part in path.split('/'): tree = tree[part] However, there is no way to represent a directory and a file with the same name because keys are conflicting in the dictionary. Concrete example: Initial state: root dir |- foo (file) |- bar (file) # data state is: {'foo': 'n', 'bar': 'n'} Remove foo: root dir |- bar (file) # Data becomes {'foo': 'r'} until next commit. Add foo, as a directory, and foo/barbar file: root dir |- bar (file) |-> foo (dir) |- barbar (file) # New state should be represented as: {'foo': {'barbar': 'a'}, 'bar': 'n'} however, the key "foo" is already used and represents the old file. The dirstate: D foo A foo/barbar cannot be represented, hence the need for a new structure. == The new structure == 'directory' class. Represents one directory level. * Notable attributes: Two dictionaries: - 'files' Maps filename -> status for the current dir. - 'dirs' Maps subdir's name -> directory object representing the subdir * methods - walk(), formerly server.walk - lookup(), old server.lookup - dir(), old server.dir This new class allows embedding all the tree walks/lookups in its own class, instead of having everything mixed together in server. Incidently, since files and directories are not stored in the same dictionaries, we are solving the previous key conflict problem. The small drawback is that lookup operation is a bit more complex: for a path a/b/c/d/e we have to check twice the leaf, if e is a directory or a file.

File last commit:

r8024:9a1b86cf default
r9115:b55d4471 default
Show More
test-profile
32 lines | 1.1 KiB | text/plain | TextLexer
Patrick Mezard
Test --time, --profile and --lsprof
r5099 #!/bin/sh
echo % test --time
Patrick Mezard
test-profile: fix grep, check hotshot availability
r5102 hg --time help -q help 2>&1 | grep Time > /dev/null || echo --time failed
Patrick Mezard
Test --time, --profile and --lsprof
r5099
Nicolas Dumazet
profiling: Adding profiling.output config variable...
r8022 hg init a
cd a
Patrick Mezard
Test --time, --profile and --lsprof
r5099 echo % test --profile
Nicolas Dumazet
profiling: dropping hotshot profiling. --profile as a unique profiling option...
r8021 if "$TESTDIR/hghave" -q lsprof; then
Nicolas Dumazet
profiling: Adding profiling.output config variable...
r8022 hg --profile st 2>../out || echo --profile failed
grep CallCount < ../out > /dev/null || echo wrong --profile
hg --profile --config profiling.output=../out st 2>&1 \
|| echo --profile + output to file failed
grep CallCount < ../out > /dev/null \
|| echo wrong --profile output when saving to a file
Nicolas Dumazet
profiling: Adding a profiling.format config variable...
r8023
hg --profile --config profiling.format=text st 2>&1 \
| grep CallCount > /dev/null || echo --profile format=text failed
Nicolas Dumazet
profiling: Adding support for kcachegrind output format, using lsprofcalltree
r8024
echo "[profiling]" >> $HGRCPATH
echo "format=kcachegrind" >> $HGRCPATH
hg --profile st 2>../out || echo --profile format=kcachegrind failed
grep 'events: Ticks' < ../out > /dev/null || echo --profile output is wrong
hg --profile --config profiling.output=../out st 2>&1 \
|| echo --profile format=kcachegrind + output to file failed
grep 'events: Ticks' < ../out > /dev/null \
|| echo --profile output is wrong
Patrick Mezard
test-profile: fix grep, check hotshot availability
r5102 fi