##// END OF EJS Templates
inotify: server: new data structure to keep track of changes....
inotify: server: new data structure to keep track of changes. == Rationale for the new structure == Current structure was a dictionary tree. One directory was tracked as a dictionary: - keys: file/subdir name - values: - for a file, the status (a/r/m/...) - for a subdir, the directory representing the subdir It allowed efficient lookups, no matter of the type of the terminal leaf: for part in path.split('/'): tree = tree[part] However, there is no way to represent a directory and a file with the same name because keys are conflicting in the dictionary. Concrete example: Initial state: root dir |- foo (file) |- bar (file) # data state is: {'foo': 'n', 'bar': 'n'} Remove foo: root dir |- bar (file) # Data becomes {'foo': 'r'} until next commit. Add foo, as a directory, and foo/barbar file: root dir |- bar (file) |-> foo (dir) |- barbar (file) # New state should be represented as: {'foo': {'barbar': 'a'}, 'bar': 'n'} however, the key "foo" is already used and represents the old file. The dirstate: D foo A foo/barbar cannot be represented, hence the need for a new structure. == The new structure == 'directory' class. Represents one directory level. * Notable attributes: Two dictionaries: - 'files' Maps filename -> status for the current dir. - 'dirs' Maps subdir's name -> directory object representing the subdir * methods - walk(), formerly server.walk - lookup(), old server.lookup - dir(), old server.dir This new class allows embedding all the tree walks/lookups in its own class, instead of having everything mixed together in server. Incidently, since files and directories are not stored in the same dictionaries, we are solving the previous key conflict problem. The small drawback is that lookup operation is a bit more complex: for a path a/b/c/d/e we have to check twice the leaf, if e is a directory or a file.

File last commit:

r8168:8766fee6 default
r9115:b55d4471 default
Show More
test-rebase-conflicts
78 lines | 1.3 KiB | text/plain | TextLexer
/ tests / test-rebase-conflicts
Stefano Tortarolo
Add rebase extension
r6906 #!/bin/sh
echo "[extensions]" >> $HGRCPATH
echo "graphlog=" >> $HGRCPATH
echo "rebase=" >> $HGRCPATH
Brendan Cully
Debashify rebase tests
r6910 cleanoutput () {
Stefano Tortarolo
Add rebase extension
r6906 sed -e 's/\(Rebase status stored to\).*/\1/' \
-e 's/\(Rebase status restored from\).*/\1/' \
-e 's/\(saving bundle to \).*/\1/'
}
hg init a
cd a
echo 'c1' >common
hg add common
Martin Geisler
tests: removed redundant "-u test" from test scripts...
r8168 hg commit -d '0 0' -m "C1"
Stefano Tortarolo
Add rebase extension
r6906
echo 'c2' >>common
Martin Geisler
tests: removed redundant "-u test" from test scripts...
r8168 hg commit -d '1 0' -m "C2"
Stefano Tortarolo
Add rebase extension
r6906
echo 'c3' >>common
Martin Geisler
tests: removed redundant "-u test" from test scripts...
r8168 hg commit -d '2 0' -m "C3"
Stefano Tortarolo
Add rebase extension
r6906
hg update -C 1
echo 'l1' >>extra
hg add extra
Martin Geisler
tests: removed redundant "-u test" from test scripts...
r8168 hg commit -d '3 0' -m "L1"
Stefano Tortarolo
Add rebase extension
r6906
sed -e 's/c2/l2/' common > common.new
mv common.new common
Martin Geisler
tests: removed redundant "-u test" from test scripts...
r8168 hg commit -d '4 0' -m "L2"
Stefano Tortarolo
Add rebase extension
r6906
Stefano Tortarolo
rebase: avoid redundant merges (issue1301)
r7278 echo 'l3' >> extra2
hg add extra2
Martin Geisler
tests: removed redundant "-u test" from test scripts...
r8168 hg commit -d '5 0' -m "L3"
Stefano Tortarolo
rebase: avoid redundant merges (issue1301)
r7278
Stefano Tortarolo
Add rebase extension
r6906 hg glog --template '{rev}: {desc}\n'
echo
echo '% Try to call --continue'
hg rebase --continue
echo
echo '% Conflicting rebase'
hg rebase -s 3 -d 2
echo
echo '% Try to continue without solving the conflict'
hg rebase --continue
echo
echo '% Conclude rebase'
Stefano Tortarolo
rebase: avoid redundant merges (issue1301)
r7278 echo 'resolved merge' >common
Stefano Tortarolo
Add rebase extension
r6906 hg resolve -m common
hg rebase --continue 2>&1 | cleanoutput
Stefano Tortarolo
rebase: avoid redundant merges (issue1301)
r7278 hg glog --template '{rev}: {desc}\n'
Stefano Tortarolo
Add rebase extension
r6906
Stefano Tortarolo
rebase: avoid redundant merges (issue1301)
r7278 echo
echo '% Check correctness'
echo ' - Rev. 0'
hg cat -r 0 common
echo ' - Rev. 1'
hg cat -r 1 common
echo ' - Rev. 2'
hg cat -r 2 common
echo ' - Rev. 3'
hg cat -r 3 common
echo ' - Rev. 4'
hg cat -r 4 common
echo ' - Rev. 5'
hg cat -r 5 common