##// END OF EJS Templates
inotify: server: new data structure to keep track of changes....
inotify: server: new data structure to keep track of changes. == Rationale for the new structure == Current structure was a dictionary tree. One directory was tracked as a dictionary: - keys: file/subdir name - values: - for a file, the status (a/r/m/...) - for a subdir, the directory representing the subdir It allowed efficient lookups, no matter of the type of the terminal leaf: for part in path.split('/'): tree = tree[part] However, there is no way to represent a directory and a file with the same name because keys are conflicting in the dictionary. Concrete example: Initial state: root dir |- foo (file) |- bar (file) # data state is: {'foo': 'n', 'bar': 'n'} Remove foo: root dir |- bar (file) # Data becomes {'foo': 'r'} until next commit. Add foo, as a directory, and foo/barbar file: root dir |- bar (file) |-> foo (dir) |- barbar (file) # New state should be represented as: {'foo': {'barbar': 'a'}, 'bar': 'n'} however, the key "foo" is already used and represents the old file. The dirstate: D foo A foo/barbar cannot be represented, hence the need for a new structure. == The new structure == 'directory' class. Represents one directory level. * Notable attributes: Two dictionaries: - 'files' Maps filename -> status for the current dir. - 'dirs' Maps subdir's name -> directory object representing the subdir * methods - walk(), formerly server.walk - lookup(), old server.lookup - dir(), old server.dir This new class allows embedding all the tree walks/lookups in its own class, instead of having everything mixed together in server. Incidently, since files and directories are not stored in the same dictionaries, we are solving the previous key conflict problem. The small drawback is that lookup operation is a bit more complex: for a path a/b/c/d/e we have to check twice the leaf, if e is a directory or a file.

File last commit:

r8720:da1b9358 default
r9115:b55d4471 default
Show More
test-verify
45 lines | 581 B | text/plain | TextLexer
Adrian Buehlmann
add test-verify
r6893 #!/bin/sh
echo % prepare repo
Benoit Boissinot
raise RevlogError when parser can't parse the revlog index...
r8016 hg init a
cd a
Adrian Buehlmann
add test-verify
r6893 echo "some text" > FOO.txt
echo "another text" > bar.txt
echo "more text" > QUICK.txt
hg add
Martin Geisler
tests: removed redundant "-d '0 0'" from test scripts...
r8167 hg ci -mtest1
Adrian Buehlmann
add test-verify
r6893
echo
echo % verify
hg verify
echo
echo % introduce some bugs in repo
cd .hg/store/data
mv _f_o_o.txt.i X_f_o_o.txt.i
mv bar.txt.i xbar.txt.i
rm _q_u_i_c_k.txt.i
echo
echo % verify
hg verify
Benoit Boissinot
raise RevlogError when parser can't parse the revlog index...
r8016 cd ..
echo % test revlog corruption
hg init b
cd b
touch a
hg add a
hg ci -m a
echo 'corrupted' > b
Will Maier
Make test-verify SUSv3 compatible....
r8720 dd if=.hg/store/data/a.i of=start bs=1 count=20 2>/dev/null
Benoit Boissinot
raise RevlogError when parser can't parse the revlog index...
r8016 cat start b > .hg/store/data/a.i
echo
echo % verify
hg verify
Matt Mackall
store: simplify class hierarchy
r6898 exit 0