##// END OF EJS Templates
copies: avoid calling matcher if matcher.always()...
copies: avoid calling matcher if matcher.always() When storing copy information in the changesets (experimental.copies.read-from=changeset-only), this patch speeds up hg debugpathcopies FENNEC_58_0_2_BUILD1 FIREFOX_59_0b8_BUILD2 from 5.9s to 4.7s. At the start of this series (b162229e), that command took 18min. Differential Revision: https://phab.mercurial-scm.org/D6422

File last commit:

r42224:566daffc default
r42688:c0b51449 default
Show More
uncommit.py
250 lines | 8.9 KiB | text/x-python | PythonLexer
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 # uncommit - undo the actions of a commit
#
# Copyright 2011 Peter Arrenbrecht <peter.arrenbrecht@gmail.com>
# Logilab SA <contact@logilab.fr>
# Pierre-Yves David <pierre-yves.david@ens-lyon.org>
# Patrick Mezard <patrick@mezard.eu>
# Copyright 2016 Facebook, Inc.
#
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version.
"""uncommit part or all of a local changeset (EXPERIMENTAL)
This command undoes the effect of a local commit, returning the affected
files to their uncommitted state. This means that files modified, added or
removed in the changeset will be left unchanged, and so will remain modified,
added and removed in the working directory.
"""
from __future__ import absolute_import
from mercurial.i18n import _
from mercurial import (
Pulkit Goyal
uncommit: don't allow bare uncommit on dirty working directory...
r34285 cmdutil,
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 commands,
context,
Martin von Zweigbergk
unamend: import "copies" module as "copiesmod" to avoid shadowing...
r41370 copies as copiesmod,
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 error,
node,
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177 obsutil,
Pulkit Goyal
py3: handle keyword arguments in hgext/uncommit.py...
r35005 pycompat,
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 registrar,
Pulkit Goyal
rewriteutil: use precheck() in uncommit and amend commands...
r35244 rewriteutil,
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 scmutil,
Matt Harbison
uncommit: abort if an explicitly given file cannot be uncommitted (BC)...
r42218 util,
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 )
cmdtable = {}
command = registrar.command(cmdtable)
Boris Feld
configitems: register the 'experimental.uncommitondirtywdir' config
r34759 configtable = {}
configitem = registrar.configitem(configtable)
configitem('experimental', 'uncommitondirtywdir',
default=False,
)
Martin von Zweigbergk
uncommit: add config option to keep commit by default...
r41916 configitem('experimental', 'uncommit.keep',
default=False,
)
Boris Feld
configitems: register the 'experimental.uncommitondirtywdir' config
r34759
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 # Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for
# extensions which SHIP WITH MERCURIAL. Non-mainline extensions should
# be specifying the version(s) of Mercurial they are tested with, or
# leave the attribute unspecified.
testedwith = 'ships-with-hg-core'
Martin von Zweigbergk
uncommit: simplify condition for keeping commit...
r36992 def _commitfiltered(repo, ctx, match, keepcommit):
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 """Recommit ctx with changed files not in match. Return the new
node identifier, or None if nothing changed.
"""
base = ctx.p1()
# ctx
initialfiles = set(ctx.files())
exclude = set(f for f in initialfiles if match(f))
# No files matched commit, so nothing excluded
if not exclude:
return None
# return the p1 so that we don't create an obsmarker later
Martin von Zweigbergk
uncommit: simplify condition for keeping commit...
r36992 if not keepcommit:
Martin von Zweigbergk
cleanup: use p1() and p2() instead of parents()[0] and parents()[1]...
r41442 return ctx.p1().node()
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193
Martin von Zweigbergk
uncommit: inform user if the commit is empty after uncommit...
r41911 files = (initialfiles - exclude)
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 # Filter copies
Martin von Zweigbergk
unamend: import "copies" module as "copiesmod" to avoid shadowing...
r41370 copied = copiesmod.pathcopies(base, ctx)
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 copied = dict((dst, src) for dst, src in copied.iteritems()
if dst in files)
def filectxfn(repo, memctx, path, contentctx=ctx, redirect=()):
if path not in contentctx:
return None
fctx = contentctx[path]
Martin von Zweigbergk
memfilectx: make changectx argument mandatory in constructor (API)...
r35401 mctx = context.memfilectx(repo, memctx, fctx.path(), fctx.data(),
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 fctx.islink(),
fctx.isexec(),
Martin von Zweigbergk
memctx: rename constructor argument "copied" to "copysource" (API)...
r42161 copysource=copied.get(path))
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 return mctx
Martin von Zweigbergk
uncommit: inform user if the commit is empty after uncommit...
r41911 if not files:
repo.ui.status(_("note: keeping empty commit\n"))
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 new = context.memctx(repo,
parents=[base.node(), node.nullid],
text=ctx.description(),
files=files,
filectxfn=filectxfn,
user=ctx.user(),
date=ctx.date(),
extra=ctx.extra())
Martin von Zweigbergk
scmutil: make cleanupnodes optionally also fix the phase...
r38442 return repo.commitctx(new)
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193
@command('uncommit',
Martin von Zweigbergk
uncommit: add config option to keep commit by default...
r41916 [('', 'keep', None, _('allow an empty commit after uncommiting')),
Navaneeth Suresh
uncommit: add flag --allow-dirty-working-copy...
r42026 ('', 'allow-dirty-working-copy', False,
_('allow uncommit with outstanding changes'))
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 ] + commands.walkopts,
rdamazio@google.com
help: assigning categories to existing commands...
r40329 _('[OPTION]... [FILE]...'),
helpcategory=command.CATEGORY_CHANGE_MANAGEMENT)
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 def uncommit(ui, repo, *pats, **opts):
"""uncommit part or all of a local changeset
This command undoes the effect of a local commit, returning the affected
files to their uncommitted state. This means that files modified or
deleted in the changeset will be left unchanged, and so will remain
modified in the working directory.
Martin von Zweigbergk
uncommit: document when the commit will be pruned...
r36991
If no files are specified, the commit will be pruned, unless --keep is
given.
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 """
Pulkit Goyal
py3: handle keyword arguments in hgext/uncommit.py...
r35005 opts = pycompat.byteskwargs(opts)
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193
with repo.wlock(), repo.lock():
Navaneeth Suresh
uncommit: don't allow dirty working copy with PATH (issue5977)...
r42025 m, a, r, d = repo.status()[:4]
isdirtypath = any(set(m + a + r + d) & set(pats))
Navaneeth Suresh
uncommit: add flag --allow-dirty-working-copy...
r42026 allowdirtywcopy = (opts['allow_dirty_working_copy'] or
repo.ui.configbool('experimental', 'uncommitondirtywdir'))
if not allowdirtywcopy and (not pats or isdirtypath):
Navaneeth Suresh
uncommit: don't allow dirty working copy with PATH (issue5977)...
r42025 cmdutil.bailifchanged(repo, hint=_('requires '
Navaneeth Suresh
uncommit: add flag --allow-dirty-working-copy...
r42026 '--allow-dirty-working-copy to uncommit'))
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 old = repo['.']
Pulkit Goyal
rewriteutil: use precheck() in uncommit and amend commands...
r35244 rewriteutil.precheck(repo, [old.rev()], 'uncommit')
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 if len(old.parents()) > 1:
raise error.Abort(_("cannot uncommit merge changeset"))
Matt Harbison
uncommit: abort if an explicitly given file cannot be uncommitted (BC)...
r42218 match = scmutil.match(old, pats, opts)
# Check all explicitly given files; abort if there's a problem.
if match.files():
s = old.status(old.p1(), match, listclean=True)
eligible = set(s.added) | set(s.modified) | set(s.removed)
badfiles = set(match.files()) - eligible
# Naming a parent directory of an eligible file is OK, even
# if not everything tracked in that directory can be
# uncommitted.
if badfiles:
Martin von Zweigbergk
cleanup: use set literals where possible...
r42224 badfiles -= {f for f in util.dirs(eligible)}
Matt Harbison
uncommit: abort if an explicitly given file cannot be uncommitted (BC)...
r42218
for f in sorted(badfiles):
if f in s.clean:
hint = _(b"file was not changed in working directory "
b"parent")
elif repo.wvfs.exists(f):
hint = _(b"file was untracked in working directory parent")
else:
hint = _(b"file does not exist")
raise error.Abort(_(b'cannot uncommit "%s"')
% scmutil.getuipathfn(repo)(f), hint=hint)
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 with repo.transaction('uncommit'):
Martin von Zweigbergk
uncommit: add config option to keep commit by default...
r41916 keepcommit = pats
if not keepcommit:
if opts.get('keep') is not None:
keepcommit = opts.get('keep')
else:
keepcommit = ui.configbool('experimental', 'uncommit.keep')
Martin von Zweigbergk
uncommit: simplify condition for keeping commit...
r36992 newid = _commitfiltered(repo, old, match, keepcommit)
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 if newid is None:
ui.status(_("nothing to uncommit\n"))
return 1
mapping = {}
if newid != old.p1().node():
# Move local changes on filtered changeset
mapping[old.node()] = (newid,)
else:
# Fully removed the old commit
mapping[old.node()] = ()
with repo.dirstate.parentchange():
Martin von Zweigbergk
uncommit: move _movedirstate() to scmutil for reuse...
r42103 scmutil.movedirstate(repo, repo[newid], match)
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177
Martin von Zweigbergk
uncommit: mark old node obsolete after updating dirstate...
r41371 scmutil.cleanupnodes(repo, mapping, 'uncommit', fixphase=True)
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177 def predecessormarkers(ctx):
"""yields the obsolete markers marking the given changeset as a successor"""
for data in ctx.repo().obsstore.predecessors.get(ctx.node(), ()):
yield obsutil.marker(ctx.repo(), data)
Rodrigo Damazio
help: adding a proper declaration for shortlist/basic commands (API)...
r40331 @command('unamend', [], helpcategory=command.CATEGORY_CHANGE_MANAGEMENT,
helpbasic=True)
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177 def unamend(ui, repo, **opts):
Martin von Zweigbergk
unamend: fix command summary line...
r35827 """undo the most recent amend operation on a current changeset
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177
This command will roll back to the previous version of a changeset,
leaving working directory in state in which it was before running
`hg amend` (e.g. files modified as part of an amend will be
marked as modified `hg status`)
"""
unfi = repo.unfiltered()
Pulkit Goyal
unamend: drop unused vars, query after taking lock, use ctx.hex() for extras...
r35201 with repo.wlock(), repo.lock(), repo.transaction('unamend'):
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177
Pulkit Goyal
unamend: drop unused vars, query after taking lock, use ctx.hex() for extras...
r35201 # identify the commit from which to unamend
curctx = repo['.']
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177
Martin von Zweigbergk
unamend: allow unamending if allowunstable is set...
r35451 rewriteutil.precheck(repo, [curctx.rev()], 'unamend')
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177
# identify the commit to which to unamend
markers = list(predecessormarkers(curctx))
if len(markers) != 1:
e = _("changeset must have one predecessor, found %i predecessors")
raise error.Abort(e % len(markers))
prednode = markers[0].prednode()
predctx = unfi[prednode]
# add an extra so that we get a new hash
# note: allowing unamend to undo an unamend is an intentional feature
extras = predctx.extra()
Pulkit Goyal
unamend: drop unused vars, query after taking lock, use ctx.hex() for extras...
r35201 extras['unamend_source'] = curctx.hex()
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177
def filectxfn(repo, ctx_, path):
try:
return predctx.filectx(path)
except KeyError:
return None
# Make a new commit same as predctx
newctx = context.memctx(repo,
parents=(predctx.p1(), predctx.p2()),
text=predctx.description(),
files=predctx.files(),
filectxfn=filectxfn,
user=predctx.user(),
date=predctx.date(),
extra=extras)
Martin von Zweigbergk
scmutil: make cleanupnodes optionally also fix the phase...
r38442 newprednode = repo.commitctx(newctx)
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177 newpredctx = repo[newprednode]
dirstate = repo.dirstate
with dirstate.parentchange():
Martin von Zweigbergk
uncommit: move _movedirstate() to scmutil for reuse...
r42103 scmutil.movedirstate(repo, newpredctx)
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177
mapping = {curctx.node(): (newprednode,)}
Martin von Zweigbergk
scmutil: make cleanupnodes optionally also fix the phase...
r38442 scmutil.cleanupnodes(repo, mapping, 'unamend', fixphase=True)