##// END OF EJS Templates
wireprotov2: add phases to "changesetdata" command...
wireprotov2: add phases to "changesetdata" command This commit teaches the "changesetdata" wire protocol command to emit the phase state for each changeset. This is a different approach from existing phase transfer in a few ways. Previously, if there are no new revisions (or we're not using bundle2), we perform a "listkeys" request to retrieve phase heads. And when revision data is being transferred with bundle2, phases data is encoded in a standalone bundle2 part. In both cases, phases data is logically decoupled from the changeset data and is encountered/applied after changeset revision data is received. The new wire protocol purposefully tries to more tightly associate changeset metadata (phases, bookmarks, obsolescence markers, etc) with the changeset revision and index data itself, rather than have it live as a separate entity that must be fetched and processed separately. I reckon that one reason we didn't do this before was it was difficult to add new data types/fields without breaking existing consumers. By using CBOR maps to transfer changeset data and putting clients in control of what fields are requested / present in those maps, we can easily add additional changeset data while maintaining backwards compatibility. I believe this to be a superior approach to the problem. That being said, for performance reasons, we may need to resort to alternative mechanisms for transferring data like phases. But for now, I think giving the wire protocol the ability to transfer changeset metadata next to the changeset itself is a powerful feature because it is a raw, changeset-centric data API. And if you build simple APIs for accessing the fundamental units of repository data, you enable client-side experimentation (partial clone, etc). If it turns out that we need specialized APIs or mechanisms for transferring data like phases, we can build in those APIs later. For now, I'd like to see how far we can get on simple APIs. It's worth noting that when phase data is being requested, the server will also emit changeset records for nodes in the bases specified by the "noderange" argument. This is to ensure that phase-only updates for nodes the client has are available to the client, even if no new changesets will be transferred. Differential Revision: https://phab.mercurial-scm.org/D4483

File last commit:

r39482:5bfab940 default
r39668:c1aacb0d default
Show More
state.py
87 lines | 2.8 KiB | text/x-python | PythonLexer
Pulkit Goyal
state: import the file to write state files from evolve extension...
r38115 # state.py - writing and reading state files in Mercurial
#
# Copyright 2018 Pulkit Goyal <pulkitmgoyal@gmail.com>
#
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version.
"""
This file contains class to wrap the state for commands and other
related logic.
All the data related to the command state is stored as dictionary in the object.
The class has methods using which the data can be stored to disk in a file under
.hg/ directory.
We store the data on disk in cbor, for which we use the third party cbor library
to serialize and deserialize data.
"""
from __future__ import absolute_import
from . import (
Pulkit Goyal
state: write the version number in plain text on top of state files...
r38118 error,
Pulkit Goyal
state: import the file to write state files from evolve extension...
r38115 util,
)
Gregory Szorc
state: use our CBOR module...
r39482 from .utils import (
cborutil,
)
Pulkit Goyal
state: import the file to write state files from evolve extension...
r38115
class cmdstate(object):
"""a wrapper class to store the state of commands like `rebase`, `graft`,
`histedit`, `shelve` etc. Extensions can also use this to write state files.
All the data for the state is stored in the form of key-value pairs in a
dictionary.
The class object can write all the data to a file in .hg/ directory and
can populate the object data reading that file.
Uses cbor to serialize and deserialize data while writing and reading from
disk.
"""
Pulkit Goyal
state: removing remaining instances of opts class variable...
r38162 def __init__(self, repo, fname):
Pulkit Goyal
state: import the file to write state files from evolve extension...
r38115 """ repo is the repo object
fname is the file name in which data should be stored in .hg directory
"""
self._repo = repo
self.fname = fname
Pulkit Goyal
state: don't have a dict like interface for cmdstate class...
r38116 def read(self):
"""read the existing state file and return a dict of data stored"""
return self._read()
Pulkit Goyal
state: import the file to write state files from evolve extension...
r38115
Pulkit Goyal
state: write the version number in plain text on top of state files...
r38118 def save(self, version, data):
Pulkit Goyal
state: import the file to write state files from evolve extension...
r38115 """write all the state data stored to .hg/<filename> file
we use third-party library cbor to serialize data to write in the file.
"""
Pulkit Goyal
state: write the version number in plain text on top of state files...
r38118 if not isinstance(version, int):
raise error.ProgrammingError("version of state file should be"
" an integer")
Pulkit Goyal
state: import the file to write state files from evolve extension...
r38115 with self._repo.vfs(self.fname, 'wb', atomictemp=True) as fp:
Pulkit Goyal
state: fix usage of an unassigned variable...
r38140 fp.write('%d\n' % version)
Gregory Szorc
state: use our CBOR module...
r39482 for chunk in cborutil.streamencode(data):
fp.write(chunk)
Pulkit Goyal
state: import the file to write state files from evolve extension...
r38115
def _read(self):
"""reads the state file and returns a dictionary which contain
data in the same format as it was before storing"""
with self._repo.vfs(self.fname, 'rb') as fp:
Pulkit Goyal
state: write the version number in plain text on top of state files...
r38118 try:
Pulkit Goyal
state: temporary silence pyflakes warning by removing variable assignment...
r38141 int(fp.readline())
Pulkit Goyal
state: write the version number in plain text on top of state files...
r38118 except ValueError:
Pulkit Goyal
state: raise CorruptedState error isntead of ProgrammingError...
r38148 raise error.CorruptedState("unknown version of state file"
" found")
Gregory Szorc
state: use our CBOR module...
r39482
return cborutil.decodeall(fp.read())[0]
Pulkit Goyal
state: import the file to write state files from evolve extension...
r38115
def delete(self):
"""drop the state file if exists"""
util.unlinkpath(self._repo.vfs.join(self.fname), ignoremissing=True)
def exists(self):
"""check whether the state file exists or not"""
return self._repo.vfs.exists(self.fname)