upstream/mercurial-mirror Files · tests/test-editor-filename.t

wireprotov2: define and implement "manifestdata" command...

wireprotov2: define and implement "manifestdata" command The added command can be used for obtaining manifest data. Given a manifest path and set of manifest nodes, data about manifests can be retrieved. Unlike changeset data, we wish to emit deltas to describe manifest revisions. So the command uses the relatively new API for building delta requests and emitting them. The code calls into deltaparent(), which I'm not very keen of. There's still work to be done in delta generation land so implementation details of storage (e.g. exactly one delta is stored/available) don't creep into higher levels. But we can worry about this later (there is already a TODO on imanifestorage tracking this). On the subject of parent deltas, the server assumes parent revisions exist on the receiving end. This is obviously wrong for shallow clone. I've added TODOs to add a mechanism to the command to allow clients to specify desired behavior. This shouldn't be too difficult to implement. Another big change is that the client must explicitly request manifest nodes to retrieve. This is a major departure from "getbundle," where the server derives relevant manifests as it iterates changesets and sends them automatically. As implemented, the client must transmit each requested node to the server. At 20 bytes per node, we're looking at 2 MB per 100,000 nodes. Plus wire encoding overhead. This isn't ideal for clients with limited upload bandwidth. I plan to address this in the future by allowing alternate mechanisms for defining the revisions to retrieve. One idea is to define a range of changeset revisions whose manifest revisions to retrieve (similar to how "changesetdata" works). We almost certainly want an API to look up an individual manifest by node. And that's where I've chosen to start with the implementation. Again, a theme of this early exchangev2 work is I want to start by building primitives for accessing raw repository data first and see how far we can get with those before we need more complexity. Differential Revision: https://phab.mercurial-scm.org/D4488

Yuya Nishihara - - Load All Authors

File last commit:

r34060:4bf18894 default


                r39673:c7a7c7e8

default

Download file

             test-editor-filename.t
        
                    61 lines
            
             | 1.3 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-editor-filename.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Michael Bolin
    
editor: use an unambiguous path suffix for editor files...

              r34030
            
      Test temp file used with an editor has the expected suffix.

        $ hg init

      Create an editor that writes its arguments to stdout and set it to $HGEDITOR.

        $ cat > editor.sh << EOF

        > echo "\$@"

        > exit 1

        > EOF

        $ hg add editor.sh

        Yuya Nishihara
    
test-editor-filename: fix portability of fake editor command...

              r34060
            
        $ HGEDITOR="sh $TESTTMP/editor.sh"

        Michael Bolin
    
editor: use an unambiguous path suffix for editor files...

              r34030
            
        $ export HGEDITOR

      Verify that the path for a commit editor has the expected suffix.

        $ hg commit

        *.commit.hg.txt (glob)

        Yuya Nishihara
    
test-editor-filename: fix portability of fake editor command...

              r34060
            
        abort: edit failed: sh exited with status 1

        Michael Bolin
    
editor: use an unambiguous path suffix for editor files...

              r34030
            
        [255]

      Verify that the path for a histedit editor has the expected suffix.

        $ cat >> $HGRCPATH <<EOF

        > [extensions]

        > rebase=

        > histedit=

        > EOF

        $ hg commit --message 'At least one commit for histedit.'

        $ hg histedit

        *.histedit.hg.txt (glob)

        Yuya Nishihara
    
test-editor-filename: fix portability of fake editor command...

              r34060
            
        abort: edit failed: sh exited with status 1

        Michael Bolin
    
editor: use an unambiguous path suffix for editor files...

              r34030
            
        [255]

        Michael Bolin
    
editor: file created for diff action should have .diff suffix...

              r34056
            
      Verify that when performing an action that has the side-effect of creating an

      editor for a diff, the file ends in .diff.

        $ echo 1 > one

        $ echo 2 > two

        $ hg add

        adding one

        adding two

        $ hg commit --interactive --config ui.interactive=true --config ui.interface=text << EOF

        > y

        > e

        > q

        > EOF

        diff --git a/one b/one

        new file mode 100644

        examine changes to 'one'? [Ynesfdaq?] y

        @@ -0,0 +1,1 @@

        +1

        record change 1/2 to 'one'? [Ynesfdaq?] e

        *.diff (glob)

        editor exited with exit code 1

        record change 1/2 to 'one'? [Ynesfdaq?] q

        abort: user quit

        [255]

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Michael Bolin editor: use an unambiguous path suffix for editor files...	r34030	Test temp file used with an editor has the expected suffix.

		$ hg init

		Create an editor that writes its arguments to stdout and set it to $HGEDITOR.

		$ cat > editor.sh << EOF
		> echo "\$@"
		> exit 1
		> EOF
		$ hg add editor.sh
Yuya Nishihara test-editor-filename: fix portability of fake editor command...	r34060	$ HGEDITOR="sh $TESTTMP/editor.sh"
Michael Bolin editor: use an unambiguous path suffix for editor files...	r34030	$ export HGEDITOR

		Verify that the path for a commit editor has the expected suffix.

		$ hg commit
		*.commit.hg.txt (glob)
Yuya Nishihara test-editor-filename: fix portability of fake editor command...	r34060	abort: edit failed: sh exited with status 1
Michael Bolin editor: use an unambiguous path suffix for editor files...	r34030	[255]

		Verify that the path for a histedit editor has the expected suffix.

		$ cat >> $HGRCPATH <<EOF
		> [extensions]
		> rebase=
		> histedit=
		> EOF
		$ hg commit --message 'At least one commit for histedit.'
		$ hg histedit
		*.histedit.hg.txt (glob)
Yuya Nishihara test-editor-filename: fix portability of fake editor command...	r34060	abort: edit failed: sh exited with status 1
Michael Bolin editor: use an unambiguous path suffix for editor files...	r34030	[255]
Michael Bolin editor: file created for diff action should have .diff suffix...	r34056
		Verify that when performing an action that has the side-effect of creating an
		editor for a diff, the file ends in .diff.

		$ echo 1 > one
		$ echo 2 > two
		$ hg add
		adding one
		adding two
		$ hg commit --interactive --config ui.interactive=true --config ui.interface=text << EOF
		> y
		> e
		> q
		> EOF
		diff --git a/one b/one
		new file mode 100644
		examine changes to 'one'? [Ynesfdaq?] y

		@@ -0,0 +1,1 @@
		+1
		record change 1/2 to 'one'? [Ynesfdaq?] e

		*.diff (glob)
		editor exited with exit code 1
		record change 1/2 to 'one'? [Ynesfdaq?] q

		abort: user quit
		[255]