##// END OF EJS Templates
narrow: only send the narrowspecs back if ACL in play...
narrow: only send the narrowspecs back if ACL in play I am unable to think why we need to send narrowspecs back from the server. The current state adds a 'narrow:spec' part to each changegroup which is generated when narrow extension is enabled. So we are sending narrowspecs on pull also. There is a problem with sending the narrowspecs the way we are doing it right now. We add include and exclude as parameter of the 'narrow:spec' bundle2 part. The the len of include or exclude string increase 255 which is obvious while working on large repos, bundle2 generation code breaks. For more on that refer issue5952 on bugzilla. I was thinking why we need to send the narrowspecs back, and deleted the 'narrow:spec' bundle2 part generation code and found that only narrow-acl test has some failure. With this patch, we will only send the 'narrow:spec' bundle2 part if ACL is enabled because the original narrowspecs in those cases can be a subset of narrowspecs user requested. There are phase related output change in couple of tests. The output change shows that we are now dealing in public phases completely. So maybe sending the narrow:spec bundle2 part was preventing phases being exchanged or phase bundle2 data being applied. Differential Revision: https://phab.mercurial-scm.org/D4931

File last commit:

r26098:ce26928c default
r40373:cb516a85 default
Show More
patchreview.txt
97 lines | 3.9 KiB | text/plain | TextLexer
Manpreet Singh
Updated contrib/vim/patchreview.* to version 0.2.1...
r10545 *patchreview.txt* Vim global plugin for doing single, multi-patch or diff code reviews
Manpreet Singh
Updated contrib/vim/patchreview.* to version 0.2.2...
r10550 Version v0.2.2 (for Vim version 7.0 or higher)
Manpreet Singh
contrib: patch review plugin for vim 7.0...
r2350
Manpreet Singh
Updated contrib/vim/patchreview.* to version 0.2.1...
r10545 Author: Manpreet Singh < junkblocker@yahoo.com >
Copyright (C) 2006-2010 by Manpreet Singh
Manpreet Singh
contrib: patch review plugin for vim 7.0...
r2350 License : This file is placed in the public domain.
=============================================================================
Manpreet Singh
Updated contrib/vim/patchreview.* to version 0.2.1...
r10545 CONTENTS *patchreview* *diffreview* *patchreview-contents*
Manpreet Singh
contrib: patch review plugin for vim 7.0...
r2350
1. Contents.........................................: |patchreview-contents|
2. Introduction.....................................: |patchreview-intro|
3. PatchReview options..............................: |patchreview-options|
4. PatchReview Usage................................: |patchreview-usage|
Manpreet Singh
Updated contrib/vim/patchreview.* to version 0.2.1...
r10545 4.1 DiffReview Usage.............................: |:DiffReview|
4.2 PatchReview Usage............................: |:PatchReview|
Manpreet Singh
contrib: patch review plugin for vim 7.0...
r2350
=============================================================================
PatchReview Introduction *patchreview-intro*
Manpreet Singh
Updated contrib/vim/patchreview.* to version 0.2.1...
r10545 The Patch Review plugin allows easy single or multipatch code or diff reviews.
It opens each affected file in the patch or in a workspace diff in a diff view
in a separate tab.
VIM provides the |:diffpatch| and related commands to do single file reviews
but can not handle patch files containing multiple patches as is common with
software development projects. This plugin provides that missing
functionality.
timeless@mozdev.org
spelling: behaviour -> behavior
r26098 It also improves on |:diffpatch|'s behavior of creating the patched files in
Manpreet Singh
contrib: patch review plugin for vim 7.0...
r2350 the same directory as original file which can lead to project workspace
pollution.
Manpreet Singh
Updated contrib/vim/patchreview.* to version 0.2.2...
r10550 It does automatic diff generation for various version control systems by
running their diff command.
Manpreet Singh
contrib: patch review plugin for vim 7.0...
r2350 =============================================================================
PatchReview Options *patchreview-options*
Manpreet Singh
Updated contrib/vim/patchreview.* to version 0.2.2...
r10550 g:patchreview_patch = {string}
Optional path to patch binary. PatchReview tries to locate patch on
system path automatically. If the binary is not on system path, this
option tell PatchReview the full path to the binary. This option, if
specified, overrides the default patch binary on the path.
Manpreet Singh
Updated contrib/vim/patchreview.* to version 0.2.1...
r10545
examples:
Manpreet Singh
Updated contrib/vim/patchreview.* to version 0.2.2...
r10550 (On Windows with Cygwin) >
let g:patchreview_patch = 'c:\\cygwin\\bin\\patch.exe'
Manpreet Singh
Updated contrib/vim/patchreview.* to version 0.2.1...
r10545 <
(On *nix systems) >
Manpreet Singh
Updated contrib/vim/patchreview.* to version 0.2.2...
r10550 let g:patchreview_patch = '/usr/bin/gpatch'
Manpreet Singh
Updated contrib/vim/patchreview.* to version 0.2.1...
r10545 <
g:patchreview_filterdiff = {string}
Optional path to filterdiff binary. PatchReview tries to locate
filterdiff on system path automatically. If the binary is not on system
path, this option tell PatchReview the full path to the binary. This
option, if specified, overrides the default filterdiff binary on the
path.
Manpreet Singh
contrib: patch review plugin for vim 7.0...
r2350
examples:
(On Windows with Cygwin)
Manpreet Singh
Updated contrib/vim/patchreview.* to version 0.2.1...
r10545 >
Manpreet Singh
contrib: patch review plugin for vim 7.0...
r2350 let g:patchreview_filterdiff = 'c:\\cygwin\\bin\\filterdiff.exe'
Manpreet Singh
Updated contrib/vim/patchreview.* to version 0.2.1...
r10545 <
Manpreet Singh
contrib: patch review plugin for vim 7.0...
r2350 (On *nix systems)
Manpreet Singh
Updated contrib/vim/patchreview.* to version 0.2.1...
r10545 >
Manpreet Singh
contrib: patch review plugin for vim 7.0...
r2350 let g:patchreview_filterdiff = '/usr/bin/filterdiff'
Manpreet Singh
Updated contrib/vim/patchreview.* to version 0.2.1...
r10545 <
Manpreet Singh
contrib: patch review plugin for vim 7.0...
r2350 =============================================================================
PatchReview Usage *patchreview-usage*
Manpreet Singh
Updated contrib/vim/patchreview.* to version 0.2.1...
r10545 *:DiffReview*
:DiffReview
Perform a diff review in the current directory under version control.
Currently supports Mercurial (hg), Subversion (svn), CVS, Bazaar (bzr) and
Monotone.
Manpreet Singh
contrib: patch review plugin for vim 7.0...
r2350 *:PatchReview*
:PatchReview patchfile_path [optional_source_directory]
Perform a patch review in the current directory based on the supplied
patchfile_path. If optional_source_directory is specified, patchreview is
Manpreet Singh
Updated contrib/vim/patchreview.* to version 0.2.1...
r10545 done on that directory. Otherwise, the current directory is assumed to be
Manpreet Singh
contrib: patch review plugin for vim 7.0...
r2350 the source directory.
Manpreet Singh
Updated contrib/vim/patchreview.* to version 0.2.1...
r10545
Only supports context or unified format patches.
------------------------------------------------------------------------------
vim: ft=help:ts=2:sts=2:sw=2:tw=78:norl: