##// END OF EJS Templates
upstream » mercurial-mirror
RSS

Clone from https://www.mercurial-scm.org/repo/hg-all

largefiles: access to specific fields only if largefiles enabled (issue4547)...
largefiles: access to specific fields only if largefiles enabled (issue4547) Even if largefiles extension is enabled in a repository, "repo" object, which isn't "largefiles.reposetup()"-ed, is passed to overridden functions in the cases below unexpectedly, because extensions are enabled for each repositories strictly. (1) clone without -U: (2) pull with -U: (3) pull with --rebase: combination of "enabled@src", "disabled@dst" and "not-required@src" cause this situation. largefiles requirement @src @dst @src result -------- -------- --------------- -------------------- enabled disabled not-required aborted unexpectedly required requirement error (intentional) -------- -------- --------------- -------------------- enabled enabled * success -------- -------- --------------- -------------------- disabled enabled * success (only for "pull") -------- -------- --------------- -------------------- disabled disabled not-required success required requirement error (intentional) -------- -------- --------------- -------------------- (4) update/revert with a subrepo disabling largefiles In these cases, overridden functions cause accessing to largefiles specific fields of not "largefiles.reposetup()"-ed "repo" object, and execution is aborted. - (1), (2), (4) cause accessing to "_lfstatuswriters" in "getstatuswriter()" invoked via "updatelfiles()" - (3) causes accessing to "_lfcommithooks" in "overriderebase()" For safe accessing to these fields, this patch examines whether passed "repo" object is "largefiles.reposetup()"-ed or not before accessing to them. This patch chooses examining existence of newly introduced "_largefilesenabled" instead of "_lfcommithooks" and "_lfstatuswriters" directly, because the former is better name for the generic "largefiles is enabled in this repo" mark than the latter. In the future, all other overridden functions should avoid largefiles specific processing for efficiency, and "_largefilesenabled" is better also for such purpose. BTW, "lfstatus" can't be used for such purpose, because some code paths set it forcibly regardless of existence of it in specified "repo" object.
Matt Mackall - - Load All Authors

File last commit:

r22047:8fb6844a default
r24158:d414c28d stable
Show More
test-check-code-hg.t
15 lines | 661 B | text/troff | Tads3Lexer
/ tests / test-check-code-hg.t
History | Source | Raw |Copy content |Copy permalink
Matt Mackall
tests: change some #ifs to #requires
 r22047 #require test-repo
Matt Mackall
test-check-code-hg: use test-repo check
 r21223
Mads Kiilerich
tests: convert test-check-code-hg.py to .t
 r15557 $ check_code="$TESTDIR"/../contrib/check-code.py
$ cd "$TESTDIR"/..
Mads Kiilerich
tests: run check-code with warnings and maintain a whitelist...
 r15558
Simon Heimberg
tests: check-code all python files in one run
 r19384 New errors are not allowed. Warnings are strongly discouraged.
Simon Heimberg
check-code: always report when a file is skipped by "no-check-code"...
 r20239 (The writing "no-che?k-code" is for not skipping this file when checking.)
Simon Heimberg
tests: check-code all python files in one run
 r19384
Matt Mackall
test-check-code-hg: use locate instead of manifest
 r21225 $ hg locate | sed 's-\\-/-g' |
Simon Heimberg
tests: test-check-code-hg.t works for all files to check...
 r19495 > xargs "$check_code" --warnings --per-file=0 || false
Simon Heimberg
check-code: always report when a file is skipped by "no-check-code"...
 r20239 Skipping hgext/zeroconf/Zeroconf.py it has no-che?k-code (glob)
Skipping i18n/polib.py it has no-che?k-code (glob)
Skipping mercurial/httpclient/__init__.py it has no-che?k-code (glob)
Skipping mercurial/httpclient/_readers.py it has no-che?k-code (glob)
Skipping mercurial/httpclient/socketutil.py it has no-che?k-code (glob)