##// END OF EJS Templates
largefiles: access to specific fields only if largefiles enabled (issue4547)...
largefiles: access to specific fields only if largefiles enabled (issue4547) Even if largefiles extension is enabled in a repository, "repo" object, which isn't "largefiles.reposetup()"-ed, is passed to overridden functions in the cases below unexpectedly, because extensions are enabled for each repositories strictly. (1) clone without -U: (2) pull with -U: (3) pull with --rebase: combination of "enabled@src", "disabled@dst" and "not-required@src" cause this situation. largefiles requirement @src @dst @src result -------- -------- --------------- -------------------- enabled disabled not-required aborted unexpectedly required requirement error (intentional) -------- -------- --------------- -------------------- enabled enabled * success -------- -------- --------------- -------------------- disabled enabled * success (only for "pull") -------- -------- --------------- -------------------- disabled disabled not-required success required requirement error (intentional) -------- -------- --------------- -------------------- (4) update/revert with a subrepo disabling largefiles In these cases, overridden functions cause accessing to largefiles specific fields of not "largefiles.reposetup()"-ed "repo" object, and execution is aborted. - (1), (2), (4) cause accessing to "_lfstatuswriters" in "getstatuswriter()" invoked via "updatelfiles()" - (3) causes accessing to "_lfcommithooks" in "overriderebase()" For safe accessing to these fields, this patch examines whether passed "repo" object is "largefiles.reposetup()"-ed or not before accessing to them. This patch chooses examining existence of newly introduced "_largefilesenabled" instead of "_lfcommithooks" and "_lfstatuswriters" directly, because the former is better name for the generic "largefiles is enabled in this repo" mark than the latter. In the future, all other overridden functions should avoid largefiles specific processing for efficiency, and "_largefilesenabled" is better also for such purpose. BTW, "lfstatus" can't be used for such purpose, because some code paths set it forcibly regardless of existence of it in specified "repo" object.

File last commit:

r20117:aa9385f9 default
r24158:d414c28d stable
Show More
test-commit-multiple.t
132 lines | 3.6 KiB | text/troff | Tads3Lexer
/ tests / test-commit-multiple.t
Greg Ward
dirstate: avoid a race with multiple commits in the same process...
r13704 # reproduce issue2264, issue2516
create test repo
$ cat <<EOF >> $HGRCPATH
> [extensions]
> transplant =
> EOF
$ hg init repo
$ cd repo
$ template="{rev} {desc|firstline} [{branch}]\n"
# we need to start out with two changesets on the default branch
# in order to avoid the cute little optimization where transplant
# pulls rather than transplants
add initial changesets
$ echo feature1 > file1
$ hg ci -Am"feature 1"
adding file1
$ echo feature2 >> file2
$ hg ci -Am"feature 2"
adding file2
# The changes to 'bugfix' are enough to show the bug: in fact, with only
# those changes, it's a very noisy crash ("RuntimeError: nothing
# committed after transplant"). But if we modify a second file in the
# transplanted changesets, the bug is much more subtle: transplant
# silently drops the second change to 'bugfix' on the floor, and we only
# see it when we run 'hg status' after transplanting. Subtle data loss
# bugs are worse than crashes, so reproduce the subtle case here.
commit bug fixes on bug fix branch
$ hg branch fixes
marked working directory as branch fixes
Matt Mackall
branch: warn on branching
r15615 (branches are permanent and global, did you want a bookmark?)
Greg Ward
dirstate: avoid a race with multiple commits in the same process...
r13704 $ echo fix1 > bugfix
$ echo fix1 >> file1
$ hg ci -Am"fix 1"
adding bugfix
$ echo fix2 > bugfix
$ echo fix2 >> file1
$ hg ci -Am"fix 2"
Martin Geisler
tests: don't load unnecessary graphlog extension...
r20117 $ hg log -G --template="$template"
Greg Ward
dirstate: avoid a race with multiple commits in the same process...
r13704 @ 3 fix 2 [fixes]
|
o 2 fix 1 [fixes]
|
o 1 feature 2 [default]
|
o 0 feature 1 [default]
transplant bug fixes onto release branch
$ hg update 0
1 files updated, 0 files merged, 2 files removed, 0 files unresolved
$ hg branch release
marked working directory as branch release
Matt Mackall
branch: warn on branching
r15615 (branches are permanent and global, did you want a bookmark?)
Greg Ward
dirstate: avoid a race with multiple commits in the same process...
r13704 $ hg transplant 2 3
applying [0-9a-f]{12} (re)
[0-9a-f]{12} transplanted to [0-9a-f]{12} (re)
applying [0-9a-f]{12} (re)
[0-9a-f]{12} transplanted to [0-9a-f]{12} (re)
Martin Geisler
tests: don't load unnecessary graphlog extension...
r20117 $ hg log -G --template="$template"
Greg Ward
dirstate: avoid a race with multiple commits in the same process...
r13704 @ 5 fix 2 [release]
|
o 4 fix 1 [release]
|
| o 3 fix 2 [fixes]
| |
| o 2 fix 1 [fixes]
| |
| o 1 feature 2 [default]
|/
o 0 feature 1 [default]
$ hg status
$ hg status --rev 0:4
M file1
A bugfix
$ hg status --rev 4:5
M bugfix
M file1
now test that we fixed the bug for all scripts/extensions
$ cat > $TESTTMP/committwice.py <<__EOF__
> from mercurial import ui, hg, match, node
Adrian Buehlmann
test-commit-multiple.t: improve committwice.py...
r13749 > from time import sleep
Greg Ward
dirstate: avoid a race with multiple commits in the same process...
r13704 >
> def replacebyte(fn, b):
Adrian Buehlmann
test-commit-multiple.t: improve committwice.py...
r13749 > f = open(fn, "rb+")
Greg Ward
dirstate: avoid a race with multiple commits in the same process...
r13704 > f.seek(0, 0)
> f.write(b)
> f.close()
>
Adrian Buehlmann
test-commit-multiple.t: improve committwice.py...
r13749 > def printfiles(repo, rev):
> print "revision %s files: %s" % (rev, repo[rev].files())
>
Greg Ward
dirstate: avoid a race with multiple commits in the same process...
r13704 > repo = hg.repository(ui.ui(), '.')
> assert len(repo) == 6, \
Adrian Buehlmann
test-commit-multiple.t: improve committwice.py...
r13749 > "initial: len(repo): %d, expected: 6" % len(repo)
>
> replacebyte("bugfix", "u")
> sleep(2)
Greg Ward
dirstate: avoid a race with multiple commits in the same process...
r13704 > try:
Adrian Buehlmann
test-commit-multiple.t: improve committwice.py...
r13749 > print "PRE: len(repo): %d" % len(repo)
Greg Ward
dirstate: avoid a race with multiple commits in the same process...
r13704 > wlock = repo.wlock()
> lock = repo.lock()
> replacebyte("file1", "x")
Adrian Buehlmann
test-commit-multiple.t: improve committwice.py...
r13749 > repo.commit(text="x", user="test", date=(0, 0))
Greg Ward
dirstate: avoid a race with multiple commits in the same process...
r13704 > replacebyte("file1", "y")
Adrian Buehlmann
test-commit-multiple.t: improve committwice.py...
r13749 > repo.commit(text="y", user="test", date=(0, 0))
> print "POST: len(repo): %d" % len(repo)
Greg Ward
dirstate: avoid a race with multiple commits in the same process...
r13704 > finally:
> lock.release()
> wlock.release()
Adrian Buehlmann
test-commit-multiple.t: improve committwice.py...
r13749 > printfiles(repo, 6)
> printfiles(repo, 7)
Greg Ward
dirstate: avoid a race with multiple commits in the same process...
r13704 > __EOF__
$ $PYTHON $TESTTMP/committwice.py
Adrian Buehlmann
test-commit-multiple.t: improve committwice.py...
r13749 PRE: len(repo): 6
POST: len(repo): 8
revision 6 files: ['bugfix', 'file1']
revision 7 files: ['file1']
Greg Ward
dirstate: avoid a race with multiple commits in the same process...
r13704
Do a size-preserving modification outside of that process
$ echo abcd > bugfix
$ hg status
M bugfix
$ hg log --template "{rev} {desc} {files}\n" -r5:
5 fix 2 bugfix file1
Adrian Buehlmann
test-commit-multiple.t: improve committwice.py...
r13749 6 x bugfix file1
Greg Ward
dirstate: avoid a race with multiple commits in the same process...
r13704 7 y file1
Mads Kiilerich
tests: add missing trailing 'cd ..'...
r16913
$ cd ..