upstream/mercurial-mirror Files · tests/test-doctest.py

largefiles: access to specific fields only if largefiles enabled (issue4547)...

largefiles: access to specific fields only if largefiles enabled (issue4547) Even if largefiles extension is enabled in a repository, "repo" object, which isn't "largefiles.reposetup()"-ed, is passed to overridden functions in the cases below unexpectedly, because extensions are enabled for each repositories strictly. (1) clone without -U: (2) pull with -U: (3) pull with --rebase: combination of "enabled@src", "disabled@dst" and "not-required@src" cause this situation. largefiles requirement @src @dst @src result -------- -------- --------------- -------------------- enabled disabled not-required aborted unexpectedly required requirement error (intentional) -------- -------- --------------- -------------------- enabled enabled * success -------- -------- --------------- -------------------- disabled enabled * success (only for "pull") -------- -------- --------------- -------------------- disabled disabled not-required success required requirement error (intentional) -------- -------- --------------- -------------------- (4) update/revert with a subrepo disabling largefiles In these cases, overridden functions cause accessing to largefiles specific fields of not "largefiles.reposetup()"-ed "repo" object, and execution is aborted. - (1), (2), (4) cause accessing to "_lfstatuswriters" in "getstatuswriter()" invoked via "updatelfiles()" - (3) causes accessing to "_lfcommithooks" in "overriderebase()" For safe accessing to these fields, this patch examines whether passed "repo" object is "largefiles.reposetup()"-ed or not before accessing to them. This patch chooses examining existence of newly introduced "_largefilesenabled" instead of "_lfcommithooks" and "_lfstatuswriters" directly, because the former is better name for the generic "largefiles is enabled in this repo" mark than the latter. In the future, all other overridden functions should avoid largefiles specific processing for efficiency, and "_largefilesenabled" is better also for such purpose. BTW, "lfstatus" can't be used for such purpose, because some code paths set it forcibly regardless of existence of it in specified "repo" object.

Mads Kiilerich - - Load All Authors

File last commit:

r22546:aac5482d default


                r24158:d414c28d

stable

Download file

             test-doctest.py
        
                    34 lines
            
             | 1.0 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / test-doctest.py
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Mads Kiilerich
    
tests: fix readline escape characters in output for test-doctest.py

              r7041
            
      # this is hack to make sure no escape characters are inserted into the output

        Mads Kiilerich
    
tests: make doctest test runner less verbose

              r20047
            
      import os, sys

        Patrick Mezard
    
test-doctest: remove TERM env variable only if it's there

              r7078
            
      if 'TERM' in os.environ:

        Dirkjan Ochtman
    
clean up trailing spaces

              r7184
            
          del os.environ['TERM']

        Benoit Boissinot
    
[extendedchangelog] encode/decode function...

              r3232
            
      import doctest

        Mads Kiilerich
    
tests: make doctest test runner less verbose

              r20047
            
      def testmod(name, optionflags=0, testtarget=None):

          __import__(name)

          mod = sys.modules[name]

          if testtarget is not None:

              mod = getattr(mod, testtarget)

          doctest.testmod(mod, optionflags=optionflags)

        Sune Foldager
    
ui: add configint function and tests

              r14171
            
        Mads Kiilerich
    
tests: make doctest test runner less verbose

              r20047
            
      testmod('mercurial.changelog')

      testmod('mercurial.dagparser', optionflags=doctest.NORMALIZE_WHITESPACE)

      testmod('mercurial.dispatch')

      testmod('mercurial.encoding')

        Yuya Nishihara
    
clone: add doctest for default destination

              r20799
            
      testmod('mercurial.hg')

        Mads Kiilerich
    
tests: make doctest test runner less verbose

              r20047
            
      testmod('mercurial.hgweb.hgwebdir_mod')

      testmod('mercurial.match')

      testmod('mercurial.minirst')

        FUJIWARA Katsunori
    
subrepo: normalize path in the specific way for problematic encodings...

              r21568
            
      testmod('mercurial.pathutil')

        Mads Kiilerich
    
tests: make doctest test runner less verbose

              r20047
            
      testmod('mercurial.revset')

      testmod('mercurial.store')

        Siddharth Agarwal
    
subrepo: factor out Git version check to add doctests...

              r20840
            
      testmod('mercurial.subrepo')

        Mads Kiilerich
    
tests: make doctest test runner less verbose

              r20047
            
      testmod('mercurial.templatefilters')

      testmod('mercurial.ui')

      testmod('mercurial.url')

      testmod('mercurial.util')

      testmod('mercurial.util', testtarget='platform')

      testmod('hgext.convert.cvsps')

        Mads Kiilerich
    
convert: readability and test of rpairs function

              r20048
            
      testmod('hgext.convert.filemap')

        Mads Kiilerich
    
convert: make subversion revsplit more stable when meeting revisions without @...

              r20419
            
      testmod('hgext.convert.subversion')

        Mads Kiilerich
    
mq: refactor patchheader header ordering to match export (BC)...

              r22546
            
      testmod('hgext.mq')

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Mads Kiilerich tests: fix readline escape characters in output for test-doctest.py	r7041	# this is hack to make sure no escape characters are inserted into the output
Mads Kiilerich tests: make doctest test runner less verbose	r20047	import os, sys
Patrick Mezard test-doctest: remove TERM env variable only if it's there	r7078	if 'TERM' in os.environ:
Dirkjan Ochtman clean up trailing spaces	r7184	del os.environ['TERM']
Benoit Boissinot [extendedchangelog] encode/decode function...	r3232	import doctest

Mads Kiilerich tests: make doctest test runner less verbose	r20047	def testmod(name, optionflags=0, testtarget=None):
		__import__(name)
		mod = sys.modules[name]
		if testtarget is not None:
		mod = getattr(mod, testtarget)
		doctest.testmod(mod, optionflags=optionflags)
Sune Foldager ui: add configint function and tests	r14171
Mads Kiilerich tests: make doctest test runner less verbose	r20047	testmod('mercurial.changelog')
		testmod('mercurial.dagparser', optionflags=doctest.NORMALIZE_WHITESPACE)
		testmod('mercurial.dispatch')
		testmod('mercurial.encoding')
Yuya Nishihara clone: add doctest for default destination	r20799	testmod('mercurial.hg')
Mads Kiilerich tests: make doctest test runner less verbose	r20047	testmod('mercurial.hgweb.hgwebdir_mod')
		testmod('mercurial.match')
		testmod('mercurial.minirst')
FUJIWARA Katsunori subrepo: normalize path in the specific way for problematic encodings...	r21568	testmod('mercurial.pathutil')
Mads Kiilerich tests: make doctest test runner less verbose	r20047	testmod('mercurial.revset')
		testmod('mercurial.store')
Siddharth Agarwal subrepo: factor out Git version check to add doctests...	r20840	testmod('mercurial.subrepo')
Mads Kiilerich tests: make doctest test runner less verbose	r20047	testmod('mercurial.templatefilters')
		testmod('mercurial.ui')
		testmod('mercurial.url')
		testmod('mercurial.util')
		testmod('mercurial.util', testtarget='platform')
		testmod('hgext.convert.cvsps')
Mads Kiilerich convert: readability and test of rpairs function	r20048	testmod('hgext.convert.filemap')
Mads Kiilerich convert: make subversion revsplit more stable when meeting revisions without @...	r20419	testmod('hgext.convert.subversion')
Mads Kiilerich mq: refactor patchheader header ordering to match export (BC)...	r22546	testmod('hgext.mq')