upstream/mercurial-mirror Files · tests/test-empty-file.t

largefiles: access to specific fields only if largefiles enabled (issue4547)...

largefiles: access to specific fields only if largefiles enabled (issue4547) Even if largefiles extension is enabled in a repository, "repo" object, which isn't "largefiles.reposetup()"-ed, is passed to overridden functions in the cases below unexpectedly, because extensions are enabled for each repositories strictly. (1) clone without -U: (2) pull with -U: (3) pull with --rebase: combination of "enabled@src", "disabled@dst" and "not-required@src" cause this situation. largefiles requirement @src @dst @src result -------- -------- --------------- -------------------- enabled disabled not-required aborted unexpectedly required requirement error (intentional) -------- -------- --------------- -------------------- enabled enabled * success -------- -------- --------------- -------------------- disabled enabled * success (only for "pull") -------- -------- --------------- -------------------- disabled disabled not-required success required requirement error (intentional) -------- -------- --------------- -------------------- (4) update/revert with a subrepo disabling largefiles In these cases, overridden functions cause accessing to largefiles specific fields of not "largefiles.reposetup()"-ed "repo" object, and execution is aborted. - (1), (2), (4) cause accessing to "_lfstatuswriters" in "getstatuswriter()" invoked via "updatelfiles()" - (3) causes accessing to "_lfcommithooks" in "overriderebase()" For safe accessing to these fields, this patch examines whether passed "repo" object is "largefiles.reposetup()"-ed or not before accessing to them. This patch chooses examining existence of newly introduced "_largefilesenabled" instead of "_lfcommithooks" and "_lfstatuswriters" directly, because the former is better name for the generic "largefiles is enabled in this repo" mark than the latter. In the future, all other overridden functions should avoid largefiles specific processing for efficiency, and "_largefilesenabled" is better also for such purpose. BTW, "lfstatus" can't be used for such purpose, because some code paths set it forcibly regardless of existence of it in specified "repo" object.

Mads Kiilerich - - Load All Authors

File last commit:

r16913:f2719b38 default


                r24158:d414c28d

stable

Download file

             test-empty-file.t
        
                    47 lines
            
             | 1.1 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-empty-file.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Adrian Buehlmann
    
tests: unify test-empty-file

              r12159
            
        $ hg init a

        $ cd a

        $ touch empty1

        $ hg add empty1

        $ hg commit -m 'add empty1'

        $ touch empty2

        $ hg add empty2

        $ hg commit -m 'add empty2'

        $ hg up -C 0

        0 files updated, 0 files merged, 1 files removed, 0 files unresolved

        $ touch empty3

        $ hg add empty3

        $ hg commit -m 'add empty3'

        created new head

        $ hg heads

        changeset:   2:a1cb177e0d44

        tag:         tip

        parent:      0:1e1d9c4e5b64

        user:        test

        date:        Thu Jan 01 00:00:00 1970 +0000

        summary:     add empty3

        changeset:   1:097d2b0e17f6

        user:        test

        date:        Thu Jan 01 00:00:00 1970 +0000

        summary:     add empty2

        $ hg merge 1

        1 files updated, 0 files merged, 0 files removed, 0 files unresolved

        (branch merge, don't forget to commit)

      Before changeset 05257fd28591, we didn't notice the

      empty file that came from rev 1:

        $ hg status

        M empty2

        $ hg commit -m merge

        $ hg manifest --debug tip

        b80de5d138758541c5f05265ad144ab9fa86d1db 644   empty1

        b80de5d138758541c5f05265ad144ab9fa86d1db 644   empty2

        b80de5d138758541c5f05265ad144ab9fa86d1db 644   empty3

        Mads Kiilerich
    
tests: add missing trailing 'cd ..'...

              r16913
            
        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Adrian Buehlmann tests: unify test-empty-file	r12159	$ hg init a
		$ cd a
		$ touch empty1
		$ hg add empty1
		$ hg commit -m 'add empty1'

		$ touch empty2
		$ hg add empty2
		$ hg commit -m 'add empty2'

		$ hg up -C 0
		0 files updated, 0 files merged, 1 files removed, 0 files unresolved
		$ touch empty3
		$ hg add empty3
		$ hg commit -m 'add empty3'
		created new head

		$ hg heads
		changeset: 2:a1cb177e0d44
		tag: tip
		parent: 0:1e1d9c4e5b64
		user: test
		date: Thu Jan 01 00:00:00 1970 +0000
		summary: add empty3

		changeset: 1:097d2b0e17f6
		user: test
		date: Thu Jan 01 00:00:00 1970 +0000
		summary: add empty2


		$ hg merge 1
		1 files updated, 0 files merged, 0 files removed, 0 files unresolved
		(branch merge, don't forget to commit)

		Before changeset 05257fd28591, we didn't notice the
		empty file that came from rev 1:

		$ hg status
		M empty2
		$ hg commit -m merge
		$ hg manifest --debug tip
		b80de5d138758541c5f05265ad144ab9fa86d1db 644 empty1
		b80de5d138758541c5f05265ad144ab9fa86d1db 644 empty2
		b80de5d138758541c5f05265ad144ab9fa86d1db 644 empty3

Mads Kiilerich tests: add missing trailing 'cd ..'...	r16913	$ cd ..