upstream/mercurial-mirror Files · tests/test-eol-tag.t

largefiles: access to specific fields only if largefiles enabled (issue4547)...

largefiles: access to specific fields only if largefiles enabled (issue4547) Even if largefiles extension is enabled in a repository, "repo" object, which isn't "largefiles.reposetup()"-ed, is passed to overridden functions in the cases below unexpectedly, because extensions are enabled for each repositories strictly. (1) clone without -U: (2) pull with -U: (3) pull with --rebase: combination of "enabled@src", "disabled@dst" and "not-required@src" cause this situation. largefiles requirement @src @dst @src result -------- -------- --------------- -------------------- enabled disabled not-required aborted unexpectedly required requirement error (intentional) -------- -------- --------------- -------------------- enabled enabled * success -------- -------- --------------- -------------------- disabled enabled * success (only for "pull") -------- -------- --------------- -------------------- disabled disabled not-required success required requirement error (intentional) -------- -------- --------------- -------------------- (4) update/revert with a subrepo disabling largefiles In these cases, overridden functions cause accessing to largefiles specific fields of not "largefiles.reposetup()"-ed "repo" object, and execution is aborted. - (1), (2), (4) cause accessing to "_lfstatuswriters" in "getstatuswriter()" invoked via "updatelfiles()" - (3) causes accessing to "_lfcommithooks" in "overriderebase()" For safe accessing to these fields, this patch examines whether passed "repo" object is "largefiles.reposetup()"-ed or not before accessing to them. This patch chooses examining existence of newly introduced "_largefilesenabled" instead of "_lfcommithooks" and "_lfstatuswriters" directly, because the former is better name for the generic "largefiles is enabled in this repo" mark than the latter. In the future, all other overridden functions should avoid largefiles specific processing for efficiency, and "_largefilesenabled" is better also for such purpose. BTW, "lfstatus" can't be used for such purpose, because some code paths set it forcibly regardless of existence of it in specified "repo" object.

Mads Kiilerich - - Load All Authors

File last commit:

r16913:f2719b38 default


                r24158:d414c28d

stable

Download file

             test-eol-tag.t
        
                    39 lines
            
             | 583 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-eol-tag.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Colin Caughie
    
eol: exclude .hgtags file from eol translation (issue2493)

              r12974
            
      http://mercurial.selenic.com/bts/issue2493

      Testing tagging with the EOL extension

        Martin Geisler
    
tests: don't overwrite HGRCPATH...

              r13519
            
        $ cat >> $HGRCPATH <<EOF

        Colin Caughie
    
eol: exclude .hgtags file from eol translation (issue2493)

              r12974
            
        > [extensions]

        > eol =

        > 

        > [eol]

        > native = CRLF

        > EOF

      setup repository

        $ hg init repo

        $ cd repo

        $ cat > .hgeol <<EOF

        > [patterns]

        > ** = native

        > EOF

        $ printf "first\r\nsecond\r\nthird\r\n" > a.txt

        $ hg commit --addremove -m 'checkin'

        adding .hgeol

        adding a.txt

      Tag:

        $ hg tag 1.0

      Rewrite .hgtags file as it would look on a new checkout:

        $ hg update -q null

        $ hg update -q

      Touch .hgtags file again:

        $ hg tag 2.0

        Mads Kiilerich
    
tests: add missing trailing 'cd ..'...

              r16913
            
        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Colin Caughie eol: exclude .hgtags file from eol translation (issue2493)	r12974	http://mercurial.selenic.com/bts/issue2493

		Testing tagging with the EOL extension

Martin Geisler tests: don't overwrite HGRCPATH...	r13519	$ cat >> $HGRCPATH <<EOF
Colin Caughie eol: exclude .hgtags file from eol translation (issue2493)	r12974	> [extensions]
		> eol =
		>
		> [eol]
		> native = CRLF
		> EOF

		setup repository

		$ hg init repo
		$ cd repo
		$ cat > .hgeol <<EOF
		> [patterns]
		> ** = native
		> EOF
		$ printf "first\r\nsecond\r\nthird\r\n" > a.txt
		$ hg commit --addremove -m 'checkin'
		adding .hgeol
		adding a.txt

		Tag:

		$ hg tag 1.0

		Rewrite .hgtags file as it would look on a new checkout:

		$ hg update -q null
		$ hg update -q

		Touch .hgtags file again:

		$ hg tag 2.0
Mads Kiilerich tests: add missing trailing 'cd ..'...	r16913
		$ cd ..