##// END OF EJS Templates
largefiles: access to specific fields only if largefiles enabled (issue4547)...
largefiles: access to specific fields only if largefiles enabled (issue4547) Even if largefiles extension is enabled in a repository, "repo" object, which isn't "largefiles.reposetup()"-ed, is passed to overridden functions in the cases below unexpectedly, because extensions are enabled for each repositories strictly. (1) clone without -U: (2) pull with -U: (3) pull with --rebase: combination of "enabled@src", "disabled@dst" and "not-required@src" cause this situation. largefiles requirement @src @dst @src result -------- -------- --------------- -------------------- enabled disabled not-required aborted unexpectedly required requirement error (intentional) -------- -------- --------------- -------------------- enabled enabled * success -------- -------- --------------- -------------------- disabled enabled * success (only for "pull") -------- -------- --------------- -------------------- disabled disabled not-required success required requirement error (intentional) -------- -------- --------------- -------------------- (4) update/revert with a subrepo disabling largefiles In these cases, overridden functions cause accessing to largefiles specific fields of not "largefiles.reposetup()"-ed "repo" object, and execution is aborted. - (1), (2), (4) cause accessing to "_lfstatuswriters" in "getstatuswriter()" invoked via "updatelfiles()" - (3) causes accessing to "_lfcommithooks" in "overriderebase()" For safe accessing to these fields, this patch examines whether passed "repo" object is "largefiles.reposetup()"-ed or not before accessing to them. This patch chooses examining existence of newly introduced "_largefilesenabled" instead of "_lfcommithooks" and "_lfstatuswriters" directly, because the former is better name for the generic "largefiles is enabled in this repo" mark than the latter. In the future, all other overridden functions should avoid largefiles specific processing for efficiency, and "_largefilesenabled" is better also for such purpose. BTW, "lfstatus" can't be used for such purpose, because some code paths set it forcibly regardless of existence of it in specified "repo" object.

File last commit:

r15024:0f1311e8 stable
r24158:d414c28d stable
Show More
test-hgweb-auth.py.out
196 lines | 4.7 KiB | text/plain | TextLexer
/ tests / test-hgweb-auth.py.out
Sune Foldager
allow http authentication information to be specified in the configuration
r8333
*** Test in-uri schemes
CFG: {x.prefix: http://example.org}
URI: http://example.org/foo
('x', 'x')
URI: http://example.org/foo/bar
('x', 'x')
URI: http://example.org/bar
('x', 'x')
URI: https://example.org/foo
abort
URI: https://example.org/foo/bar
abort
URI: https://example.org/bar
abort
Patrick Mezard
hgweb: do not ignore [auth] if url has a username (issue2822)...
r15005 URI: https://x@example.org/bar
abort
URI: https://y@example.org/bar
abort
Sune Foldager
allow http authentication information to be specified in the configuration
r8333 CFG: {x.prefix: https://example.org}
URI: http://example.org/foo
abort
URI: http://example.org/foo/bar
abort
URI: http://example.org/bar
abort
URI: https://example.org/foo
('x', 'x')
URI: https://example.org/foo/bar
('x', 'x')
URI: https://example.org/bar
('x', 'x')
Patrick Mezard
hgweb: do not ignore [auth] if url has a username (issue2822)...
r15005 URI: https://x@example.org/bar
('x', 'x')
URI: https://y@example.org/bar
abort
Sune Foldager
allow http authentication information to be specified in the configuration
r8333 CFG: {x.prefix: http://example.org, x.schemes: https}
URI: http://example.org/foo
('x', 'x')
URI: http://example.org/foo/bar
('x', 'x')
URI: http://example.org/bar
('x', 'x')
URI: https://example.org/foo
abort
URI: https://example.org/foo/bar
abort
URI: https://example.org/bar
abort
Patrick Mezard
hgweb: do not ignore [auth] if url has a username (issue2822)...
r15005 URI: https://x@example.org/bar
abort
URI: https://y@example.org/bar
abort
Sune Foldager
allow http authentication information to be specified in the configuration
r8333 CFG: {x.prefix: https://example.org, x.schemes: http}
URI: http://example.org/foo
abort
URI: http://example.org/foo/bar
abort
URI: http://example.org/bar
abort
URI: https://example.org/foo
('x', 'x')
URI: https://example.org/foo/bar
('x', 'x')
URI: https://example.org/bar
('x', 'x')
Patrick Mezard
hgweb: do not ignore [auth] if url has a username (issue2822)...
r15005 URI: https://x@example.org/bar
('x', 'x')
URI: https://y@example.org/bar
abort
Sune Foldager
allow http authentication information to be specified in the configuration
r8333
*** Test separately configured schemes
CFG: {x.prefix: example.org, x.schemes: http}
URI: http://example.org/foo
('x', 'x')
URI: http://example.org/foo/bar
('x', 'x')
URI: http://example.org/bar
('x', 'x')
URI: https://example.org/foo
abort
URI: https://example.org/foo/bar
abort
URI: https://example.org/bar
abort
Patrick Mezard
hgweb: do not ignore [auth] if url has a username (issue2822)...
r15005 URI: https://x@example.org/bar
abort
URI: https://y@example.org/bar
abort
Sune Foldager
allow http authentication information to be specified in the configuration
r8333 CFG: {x.prefix: example.org, x.schemes: https}
URI: http://example.org/foo
abort
URI: http://example.org/foo/bar
abort
URI: http://example.org/bar
abort
URI: https://example.org/foo
('x', 'x')
URI: https://example.org/foo/bar
('x', 'x')
URI: https://example.org/bar
('x', 'x')
Patrick Mezard
hgweb: do not ignore [auth] if url has a username (issue2822)...
r15005 URI: https://x@example.org/bar
('x', 'x')
URI: https://y@example.org/bar
abort
Sune Foldager
allow http authentication information to be specified in the configuration
r8333 CFG: {x.prefix: example.org, x.schemes: http https}
URI: http://example.org/foo
('x', 'x')
URI: http://example.org/foo/bar
('x', 'x')
URI: http://example.org/bar
('x', 'x')
URI: https://example.org/foo
('x', 'x')
URI: https://example.org/foo/bar
('x', 'x')
URI: https://example.org/bar
('x', 'x')
Patrick Mezard
hgweb: do not ignore [auth] if url has a username (issue2822)...
r15005 URI: https://x@example.org/bar
('x', 'x')
URI: https://y@example.org/bar
abort
Sune Foldager
allow http authentication information to be specified in the configuration
r8333
*** Test prefix matching
CFG: {x.prefix: http://example.org/foo, y.prefix: http://example.org/bar}
URI: http://example.org/foo
('x', 'x')
URI: http://example.org/foo/bar
('x', 'x')
URI: http://example.org/bar
('y', 'y')
URI: https://example.org/foo
abort
URI: https://example.org/foo/bar
abort
URI: https://example.org/bar
abort
Patrick Mezard
hgweb: do not ignore [auth] if url has a username (issue2822)...
r15005 URI: https://x@example.org/bar
abort
URI: https://y@example.org/bar
abort
Sune Foldager
allow http authentication information to be specified in the configuration
r8333 CFG: {x.prefix: http://example.org/foo, y.prefix: http://example.org/foo/bar}
URI: http://example.org/foo
('x', 'x')
URI: http://example.org/foo/bar
('y', 'y')
URI: http://example.org/bar
abort
URI: https://example.org/foo
abort
URI: https://example.org/foo/bar
abort
URI: https://example.org/bar
abort
Patrick Mezard
hgweb: do not ignore [auth] if url has a username (issue2822)...
r15005 URI: https://x@example.org/bar
abort
URI: https://y@example.org/bar
abort
Sune Foldager
allow http authentication information to be specified in the configuration
r8333 CFG: {x.prefix: *, y.prefix: https://example.org/bar}
URI: http://example.org/foo
abort
URI: http://example.org/foo/bar
abort
URI: http://example.org/bar
abort
URI: https://example.org/foo
('x', 'x')
URI: https://example.org/foo/bar
('x', 'x')
URI: https://example.org/bar
('y', 'y')
Patrick Mezard
hgweb: do not ignore [auth] if url has a username (issue2822)...
r15005 URI: https://x@example.org/bar
('x', 'x')
URI: https://y@example.org/bar
('y', 'y')
*** Test user matching
CFG: {x.password: xpassword, x.prefix: http://example.org/foo, x.username: None}
URI: http://y@example.org/foo
('y', 'xpassword')
CFG: {x.password: xpassword, x.prefix: http://example.org/foo, x.username: None, y.password: ypassword, y.prefix: http://example.org/foo, y.username: y}
URI: http://y@example.org/foo
('y', 'ypassword')
CFG: {x.password: xpassword, x.prefix: http://example.org/foo/bar, x.username: None, y.password: ypassword, y.prefix: http://example.org/foo, y.username: y}
URI: http://y@example.org/foo/bar
('y', 'xpassword')
Patrick Mezard
http: strip credentials from urllib2 manager URIs (issue2885)...
r15024
*** Test urllib2 and util.url
URIs: http://user@example.com:8080/foo http://example.com:8080/foo
('user', '')