upstream/mercurial-mirror Files · tests/test-hup.t

largefiles: access to specific fields only if largefiles enabled (issue4547)...

largefiles: access to specific fields only if largefiles enabled (issue4547) Even if largefiles extension is enabled in a repository, "repo" object, which isn't "largefiles.reposetup()"-ed, is passed to overridden functions in the cases below unexpectedly, because extensions are enabled for each repositories strictly. (1) clone without -U: (2) pull with -U: (3) pull with --rebase: combination of "enabled@src", "disabled@dst" and "not-required@src" cause this situation. largefiles requirement @src @dst @src result -------- -------- --------------- -------------------- enabled disabled not-required aborted unexpectedly required requirement error (intentional) -------- -------- --------------- -------------------- enabled enabled * success -------- -------- --------------- -------------------- disabled enabled * success (only for "pull") -------- -------- --------------- -------------------- disabled disabled not-required success required requirement error (intentional) -------- -------- --------------- -------------------- (4) update/revert with a subrepo disabling largefiles In these cases, overridden functions cause accessing to largefiles specific fields of not "largefiles.reposetup()"-ed "repo" object, and execution is aborted. - (1), (2), (4) cause accessing to "_lfstatuswriters" in "getstatuswriter()" invoked via "updatelfiles()" - (3) causes accessing to "_lfcommithooks" in "overriderebase()" For safe accessing to these fields, this patch examines whether passed "repo" object is "largefiles.reposetup()"-ed or not before accessing to them. This patch chooses examining existence of newly introduced "_largefilesenabled" instead of "_lfcommithooks" and "_lfstatuswriters" directly, because the former is better name for the generic "largefiles is enabled in this repo" mark than the latter. In the future, all other overridden functions should avoid largefiles specific processing for efficiency, and "_largefilesenabled" is better also for such purpose. BTW, "lfstatus" can't be used for such purpose, because some code paths set it forcibly regardless of existence of it in specified "repo" object.

Pierre-Yves David - - Load All Authors

File last commit:

r23277:581d3bc0 default


                r24158:d414c28d

stable

Download file

             test-hup.t
        
                    47 lines
            
             | 923 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-hup.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Matt Mackall
    
tests: replace exit 80 with #require

              r22046
            
      #require serve fifo

        Matt Mackall
    
tests: unify test-hup

              r12413
            
      Test hangup signal in the middle of transaction

        $ hg init

        $ mkfifo p

        Matt Mackall
    
tests: make test-hup more race-proof...

              r16342
            
        $ hg serve --stdio < p 1>out 2>&1 &

        Matt Mackall
    
tests: unify test-hup

              r12413
            
        $ P=$!

        Matt Mackall
    
tests: remove sleep/startup/shutdown races from test-hup

              r16299
            
      Do test while holding fifo open

        $ (

        > echo lock

        > echo addchangegroup

        Pierre-Yves David
    
tests: prevent test-hup from hanging forever if the transaction does not start...

              r20896
            
        > start=`date +%s`

        > # 10 second seems much enough to let the server catch up

        > deadline=`expr $start + 10`

        > while [ ! -s .hg/store/journal ]; do

        >     sleep 0;

        >     if [ `date +%s` -gt $deadline ]; then

        >         echo "transaction did not start after 10 seconds" >&2;

        >         exit 1;

        >     fi

        > done

        Matt Mackall
    
tests: remove sleep/startup/shutdown races from test-hup

              r16299
            
        > kill -HUP $P

        > ) > p

        Matt Mackall
    
tests: make test-hup more race-proof...

              r16342
            
        Matt Mackall
    
tests: avoid zombie lockup with test-hup...

              r16344
            
        $ wait

        Matt Mackall
    
tests: make test-hup more race-proof...

              r16342
            
        $ cat out

        Matt Mackall
    
tests: unify test-hup

              r12413
            
        0

        0

        adding changesets

        transaction abort!

        rollback completed

        killed!

        Matt Mackall
    
tests: remove sleep/startup/shutdown races from test-hup

              r16299
            
        Pierre-Yves David
    
test-hup: use ls instead of echo...

              r23277
            
        $ ls -1d .hg/* .hg/store/*

        .hg/00changelog.i

        .hg/journal.bookmarks

        .hg/journal.branch

        .hg/journal.desc

        .hg/journal.dirstate

        .hg/requires

        .hg/store

        .hg/store/00changelog.i

        .hg/store/00changelog.i.a

        .hg/store/journal.phaseroots

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Matt Mackall tests: replace exit 80 with #require	r22046	#require serve fifo

Matt Mackall tests: unify test-hup	r12413	Test hangup signal in the middle of transaction

		$ hg init
		$ mkfifo p
Matt Mackall tests: make test-hup more race-proof...	r16342	$ hg serve --stdio < p 1>out 2>&1 &
Matt Mackall tests: unify test-hup	r12413	$ P=$!
Matt Mackall tests: remove sleep/startup/shutdown races from test-hup	r16299
		Do test while holding fifo open

		$ (
		> echo lock
		> echo addchangegroup
Pierre-Yves David tests: prevent test-hup from hanging forever if the transaction does not start...	r20896	> start=`date +%s`
		> # 10 second seems much enough to let the server catch up
		> deadline=`expr $start + 10`
		> while [ ! -s .hg/store/journal ]; do
		> sleep 0;
		> if [ `date +%s` -gt $deadline ]; then
		> echo "transaction did not start after 10 seconds" >&2;
		> exit 1;
		> fi
		> done
Matt Mackall tests: remove sleep/startup/shutdown races from test-hup	r16299	> kill -HUP $P
		> ) > p
Matt Mackall tests: make test-hup more race-proof...	r16342
Matt Mackall tests: avoid zombie lockup with test-hup...	r16344	$ wait
Matt Mackall tests: make test-hup more race-proof...	r16342	$ cat out
Matt Mackall tests: unify test-hup	r12413	0
		0
		adding changesets
		transaction abort!
		rollback completed
		killed!
Matt Mackall tests: remove sleep/startup/shutdown races from test-hup	r16299
Pierre-Yves David test-hup: use ls instead of echo...	r23277	$ ls -1d .hg/* .hg/store/*
		.hg/00changelog.i
		.hg/journal.bookmarks
		.hg/journal.branch
		.hg/journal.desc
		.hg/journal.dirstate
		.hg/requires
		.hg/store
		.hg/store/00changelog.i
		.hg/store/00changelog.i.a
		.hg/store/journal.phaseroots