upstream/mercurial-mirror Files · tests/test-issue1502.t

largefiles: access to specific fields only if largefiles enabled (issue4547)...

largefiles: access to specific fields only if largefiles enabled (issue4547) Even if largefiles extension is enabled in a repository, "repo" object, which isn't "largefiles.reposetup()"-ed, is passed to overridden functions in the cases below unexpectedly, because extensions are enabled for each repositories strictly. (1) clone without -U: (2) pull with -U: (3) pull with --rebase: combination of "enabled@src", "disabled@dst" and "not-required@src" cause this situation. largefiles requirement @src @dst @src result -------- -------- --------------- -------------------- enabled disabled not-required aborted unexpectedly required requirement error (intentional) -------- -------- --------------- -------------------- enabled enabled * success -------- -------- --------------- -------------------- disabled enabled * success (only for "pull") -------- -------- --------------- -------------------- disabled disabled not-required success required requirement error (intentional) -------- -------- --------------- -------------------- (4) update/revert with a subrepo disabling largefiles In these cases, overridden functions cause accessing to largefiles specific fields of not "largefiles.reposetup()"-ed "repo" object, and execution is aborted. - (1), (2), (4) cause accessing to "_lfstatuswriters" in "getstatuswriter()" invoked via "updatelfiles()" - (3) causes accessing to "_lfcommithooks" in "overriderebase()" For safe accessing to these fields, this patch examines whether passed "repo" object is "largefiles.reposetup()"-ed or not before accessing to them. This patch chooses examining existence of newly introduced "_largefilesenabled" instead of "_lfcommithooks" and "_lfstatuswriters" directly, because the former is better name for the generic "largefiles is enabled in this repo" mark than the latter. In the future, all other overridden functions should avoid largefiles specific processing for efficiency, and "_largefilesenabled" is better also for such purpose. BTW, "lfstatus" can't be used for such purpose, because some code paths set it forcibly regardless of existence of it in specified "repo" object.

Siddharth Agarwal - - Load All Authors

File last commit:

r19798:76df01e5 default


                r24158:d414c28d

stable

Download file

             test-issue1502.t
        
                    42 lines
            
             | 1.2 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-issue1502.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        David Soria Parra
    
bookmarks: restrict moving a bookmark to its descendants (issue1502)...

              r13478
            
      http://mercurial.selenic.com/bts/issue1502

      Initialize repository

        $ hg init foo

        $ touch foo/a && hg -R foo commit -A -m "added a"

        adding a

        $ hg clone foo foo1

        updating to branch default

        1 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ echo "bar" > foo1/a && hg -R foo1 commit -m "edit a in foo1"

        $ echo "hi" > foo/a && hg -R foo commit -m "edited a foo"

        $ hg -R foo1 pull -u

        Mads Kiilerich
    
tests: make (glob) on windows accept \ instead of /...

              r15447
            
        pulling from $TESTTMP/foo (glob)

        David Soria Parra
    
bookmarks: restrict moving a bookmark to its descendants (issue1502)...

              r13478
            
        searching for changes

        adding changesets

        adding manifests

        adding file changes

        added 1 changesets with 1 changes to 1 files (+1 heads)

        Siddharth Agarwal
    
update: improve error message for clean non-linear update

              r19798
            
        not updating: not a linear update

        (merge or update --check to force update)

        David Soria Parra
    
bookmarks: restrict moving a bookmark to its descendants (issue1502)...

              r13478
            
        $ hg -R foo1 book branchy

        $ hg -R foo1 book

         * branchy                   1:e3e522925eff

      Pull. Bookmark should not jump to new head.

        $ echo "there" >> foo/a && hg -R foo commit -m "edited a again"

        $ hg -R foo1 pull

        Mads Kiilerich
    
tests: make (glob) on windows accept \ instead of /...

              r15447
            
        pulling from $TESTTMP/foo (glob)

        David Soria Parra
    
bookmarks: restrict moving a bookmark to its descendants (issue1502)...

              r13478
            
        searching for changes

        adding changesets

        adding manifests

        adding file changes

        added 1 changesets with 1 changes to 1 files

        (run 'hg update' to get a working copy)

        $ hg -R foo1 book

         * branchy                   1:e3e522925eff

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

David Soria Parra bookmarks: restrict moving a bookmark to its descendants (issue1502)...	r13478	http://mercurial.selenic.com/bts/issue1502

		Initialize repository

		$ hg init foo
		$ touch foo/a && hg -R foo commit -A -m "added a"
		adding a

		$ hg clone foo foo1
		updating to branch default
		1 files updated, 0 files merged, 0 files removed, 0 files unresolved

		$ echo "bar" > foo1/a && hg -R foo1 commit -m "edit a in foo1"
		$ echo "hi" > foo/a && hg -R foo commit -m "edited a foo"
		$ hg -R foo1 pull -u
Mads Kiilerich tests: make (glob) on windows accept \ instead of /...	r15447	pulling from $TESTTMP/foo (glob)
David Soria Parra bookmarks: restrict moving a bookmark to its descendants (issue1502)...	r13478	searching for changes
		adding changesets
		adding manifests
		adding file changes
		added 1 changesets with 1 changes to 1 files (+1 heads)
Siddharth Agarwal update: improve error message for clean non-linear update	r19798	not updating: not a linear update
		(merge or update --check to force update)
David Soria Parra bookmarks: restrict moving a bookmark to its descendants (issue1502)...	r13478
		$ hg -R foo1 book branchy
		$ hg -R foo1 book
		* branchy 1:e3e522925eff

		Pull. Bookmark should not jump to new head.

		$ echo "there" >> foo/a && hg -R foo commit -m "edited a again"
		$ hg -R foo1 pull
Mads Kiilerich tests: make (glob) on windows accept \ instead of /...	r15447	pulling from $TESTTMP/foo (glob)
David Soria Parra bookmarks: restrict moving a bookmark to its descendants (issue1502)...	r13478	searching for changes
		adding changesets
		adding manifests
		adding file changes
		added 1 changesets with 1 changes to 1 files
		(run 'hg update' to get a working copy)

		$ hg -R foo1 book
		* branchy 1:e3e522925eff