upstream/mercurial-mirror Files · tests/test-issue660.t

largefiles: access to specific fields only if largefiles enabled (issue4547)...

largefiles: access to specific fields only if largefiles enabled (issue4547) Even if largefiles extension is enabled in a repository, "repo" object, which isn't "largefiles.reposetup()"-ed, is passed to overridden functions in the cases below unexpectedly, because extensions are enabled for each repositories strictly. (1) clone without -U: (2) pull with -U: (3) pull with --rebase: combination of "enabled@src", "disabled@dst" and "not-required@src" cause this situation. largefiles requirement @src @dst @src result -------- -------- --------------- -------------------- enabled disabled not-required aborted unexpectedly required requirement error (intentional) -------- -------- --------------- -------------------- enabled enabled * success -------- -------- --------------- -------------------- disabled enabled * success (only for "pull") -------- -------- --------------- -------------------- disabled disabled not-required success required requirement error (intentional) -------- -------- --------------- -------------------- (4) update/revert with a subrepo disabling largefiles In these cases, overridden functions cause accessing to largefiles specific fields of not "largefiles.reposetup()"-ed "repo" object, and execution is aborted. - (1), (2), (4) cause accessing to "_lfstatuswriters" in "getstatuswriter()" invoked via "updatelfiles()" - (3) causes accessing to "_lfcommithooks" in "overriderebase()" For safe accessing to these fields, this patch examines whether passed "repo" object is "largefiles.reposetup()"-ed or not before accessing to them. This patch chooses examining existence of newly introduced "_largefilesenabled" instead of "_lfcommithooks" and "_lfstatuswriters" directly, because the former is better name for the generic "largefiles is enabled in this repo" mark than the latter. In the future, all other overridden functions should avoid largefiles specific processing for efficiency, and "_largefilesenabled" is better also for such purpose. BTW, "lfstatus" can't be used for such purpose, because some code paths set it forcibly regardless of existence of it in specified "repo" object.

Matt Mackall - - Load All Authors

File last commit:

r19510:8b190adb stable


                r24158:d414c28d

stable

Download file

             test-issue660.t
        
                    154 lines
            
             | 2.1 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-issue660.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Nicolas Dumazet
    
tests: remove test-issue322 as it's fully included in test-issue660

              r14112
            
      http://mercurial.selenic.com/bts/issue660 and:

      http://mercurial.selenic.com/bts/issue322

        Adrian Buehlmann
    
tests: unify test-issue*

              r12195
            
        $ hg init

        $ echo a > a

        $ mkdir b

        $ echo b > b/b

        $ hg commit -A -m "a is file, b is dir"

        adding a

        adding b/b

      File replaced with directory:

        $ rm a

        $ mkdir a

        $ echo a > a/a

      Should fail - would corrupt dirstate:

        $ hg add a/a

        abort: file 'a' in dirstate clashes with 'a/a'

        Matt Mackall
    
tests: add exit codes to unified tests

              r12316
            
        [255]

        Adrian Buehlmann
    
tests: unify test-issue*

              r12195
            
      Removing shadow:

        $ hg rm --after a

      Should succeed - shadow removed:

        $ hg add a/a

      Directory replaced with file:

        $ rm -r b

        $ echo b > b

      Should fail - would corrupt dirstate:

        $ hg add b

        abort: directory 'b' already in dirstate

        Matt Mackall
    
tests: add exit codes to unified tests

              r12316
            
        [255]

        Adrian Buehlmann
    
tests: unify test-issue*

              r12195
            
      Removing shadow:

        $ hg rm --after b/b

      Should succeed - shadow removed:

        $ hg add b

      Look what we got:

        $ hg st

        A a/a

        A b

        R a

        R b/b

      Revert reintroducing shadow - should fail:

        $ rm -r a b

        $ hg revert b/b

        abort: file 'b' in dirstate clashes with 'b/b'

        Matt Mackall
    
tests: add exit codes to unified tests

              r12316
            
        [255]

        Adrian Buehlmann
    
tests: unify test-issue*

              r12195
            
      Revert all - should succeed:

        $ hg revert --all

        undeleting a

        Mads Kiilerich
    
tests: make (glob) on windows accept \ instead of /...

              r15447
            
        forgetting a/a (glob)

        Adrian Buehlmann
    
tests: unify test-issue*

              r12195
            
        forgetting b

        Mads Kiilerich
    
tests: make (glob) on windows accept \ instead of /...

              r15447
            
        undeleting b/b (glob)

        Adrian Buehlmann
    
tests: unify test-issue*

              r12195
            
        $ hg st

        Matt Mackall
    
revert: make backup when unforgetting a file (issue3423)...

              r19510
            
      Issue3423:

        $ hg forget a

        $ echo zed > a

        $ hg revert a

        $ hg st

        ? a.orig

        $ rm a.orig

        Adrian Buehlmann
    
tests: unify test-issue*

              r12195
            
      addremove:

        $ rm -r a b

        $ mkdir a

        $ echo a > a/a

        $ echo b > b

        $ hg addremove -s 0

        removing a

        adding a/a

        adding b

        removing b/b

        $ hg st

        A a/a

        A b

        R a

        R b/b

      commit:

        $ hg ci -A -m "a is dir, b is file"

        $ hg st --all

        C a/a

        C b

      Long directory replaced with file:

        $ mkdir d

        $ mkdir d/d

        $ echo d > d/d/d

        $ hg commit -A -m "d is long directory"

        adding d/d/d

        $ rm -r d

        $ echo d > d

      Should fail - would corrupt dirstate:

        $ hg add d

        abort: directory 'd' already in dirstate

        Matt Mackall
    
tests: add exit codes to unified tests

              r12316
            
        [255]

        Adrian Buehlmann
    
tests: unify test-issue*

              r12195
            
      Removing shadow:

        $ hg rm --after d/d/d

      Should succeed - shadow removed:

        $ hg add d

        $ hg ci -md

      Update should work at least with clean working directory:

        $ rm -r a b d

        $ hg up -r 0

        2 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ hg st --all

        C a

        C b/b

        $ rm -r a b

        $ hg up -r 1

        2 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ hg st --all

        C a/a

        C b

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Nicolas Dumazet tests: remove test-issue322 as it's fully included in test-issue660	r14112	http://mercurial.selenic.com/bts/issue660 and:
		http://mercurial.selenic.com/bts/issue322
Adrian Buehlmann tests: unify test-issue*	r12195
		$ hg init
		$ echo a > a
		$ mkdir b
		$ echo b > b/b
		$ hg commit -A -m "a is file, b is dir"
		adding a
		adding b/b

		File replaced with directory:

		$ rm a
		$ mkdir a
		$ echo a > a/a

		Should fail - would corrupt dirstate:

		$ hg add a/a
		abort: file 'a' in dirstate clashes with 'a/a'
Matt Mackall tests: add exit codes to unified tests	r12316	[255]
Adrian Buehlmann tests: unify test-issue*	r12195
		Removing shadow:

		$ hg rm --after a

		Should succeed - shadow removed:

		$ hg add a/a

		Directory replaced with file:

		$ rm -r b
		$ echo b > b

		Should fail - would corrupt dirstate:

		$ hg add b
		abort: directory 'b' already in dirstate
Matt Mackall tests: add exit codes to unified tests	r12316	[255]
Adrian Buehlmann tests: unify test-issue*	r12195
		Removing shadow:

		$ hg rm --after b/b

		Should succeed - shadow removed:

		$ hg add b

		Look what we got:

		$ hg st
		A a/a
		A b
		R a
		R b/b

		Revert reintroducing shadow - should fail:

		$ rm -r a b
		$ hg revert b/b
		abort: file 'b' in dirstate clashes with 'b/b'
Matt Mackall tests: add exit codes to unified tests	r12316	[255]
Adrian Buehlmann tests: unify test-issue*	r12195
		Revert all - should succeed:

		$ hg revert --all
		undeleting a
Mads Kiilerich tests: make (glob) on windows accept \ instead of /...	r15447	forgetting a/a (glob)
Adrian Buehlmann tests: unify test-issue*	r12195	forgetting b
Mads Kiilerich tests: make (glob) on windows accept \ instead of /...	r15447	undeleting b/b (glob)
Adrian Buehlmann tests: unify test-issue*	r12195
		$ hg st

Matt Mackall revert: make backup when unforgetting a file (issue3423)...	r19510	Issue3423:

		$ hg forget a
		$ echo zed > a
		$ hg revert a
		$ hg st
		? a.orig
		$ rm a.orig

Adrian Buehlmann tests: unify test-issue*	r12195	addremove:

		$ rm -r a b
		$ mkdir a
		$ echo a > a/a
		$ echo b > b

		$ hg addremove -s 0
		removing a
		adding a/a
		adding b
		removing b/b

		$ hg st
		A a/a
		A b
		R a
		R b/b

		commit:

		$ hg ci -A -m "a is dir, b is file"
		$ hg st --all
		C a/a
		C b

		Long directory replaced with file:

		$ mkdir d
		$ mkdir d/d
		$ echo d > d/d/d
		$ hg commit -A -m "d is long directory"
		adding d/d/d

		$ rm -r d
		$ echo d > d

		Should fail - would corrupt dirstate:

		$ hg add d
		abort: directory 'd' already in dirstate
Matt Mackall tests: add exit codes to unified tests	r12316	[255]
Adrian Buehlmann tests: unify test-issue*	r12195
		Removing shadow:

		$ hg rm --after d/d/d

		Should succeed - shadow removed:

		$ hg add d
		$ hg ci -md

		Update should work at least with clean working directory:

		$ rm -r a b d
		$ hg up -r 0
		2 files updated, 0 files merged, 0 files removed, 0 files unresolved

		$ hg st --all
		C a
		C b/b

		$ rm -r a b
		$ hg up -r 1
		2 files updated, 0 files merged, 0 files removed, 0 files unresolved

		$ hg st --all
		C a/a
		C b