upstream/mercurial-mirror Files · tests/test-strict.t

largefiles: access to specific fields only if largefiles enabled (issue4547)...

largefiles: access to specific fields only if largefiles enabled (issue4547) Even if largefiles extension is enabled in a repository, "repo" object, which isn't "largefiles.reposetup()"-ed, is passed to overridden functions in the cases below unexpectedly, because extensions are enabled for each repositories strictly. (1) clone without -U: (2) pull with -U: (3) pull with --rebase: combination of "enabled@src", "disabled@dst" and "not-required@src" cause this situation. largefiles requirement @src @dst @src result -------- -------- --------------- -------------------- enabled disabled not-required aborted unexpectedly required requirement error (intentional) -------- -------- --------------- -------------------- enabled enabled * success -------- -------- --------------- -------------------- disabled enabled * success (only for "pull") -------- -------- --------------- -------------------- disabled disabled not-required success required requirement error (intentional) -------- -------- --------------- -------------------- (4) update/revert with a subrepo disabling largefiles In these cases, overridden functions cause accessing to largefiles specific fields of not "largefiles.reposetup()"-ed "repo" object, and execution is aborted. - (1), (2), (4) cause accessing to "_lfstatuswriters" in "getstatuswriter()" invoked via "updatelfiles()" - (3) causes accessing to "_lfcommithooks" in "overriderebase()" For safe accessing to these fields, this patch examines whether passed "repo" object is "largefiles.reposetup()"-ed or not before accessing to them. This patch chooses examining existence of newly introduced "_largefilesenabled" instead of "_lfcommithooks" and "_lfstatuswriters" directly, because the former is better name for the generic "largefiles is enabled in this repo" mark than the latter. In the future, all other overridden functions should avoid largefiles specific processing for efficiency, and "_largefilesenabled" is better also for such purpose. BTW, "lfstatus" can't be used for such purpose, because some code paths set it forcibly regardless of existence of it in specified "repo" object.

anatoly techtonik - - Load All Authors

File last commit:

r23400:3bd577a3 stable


                r24158:d414c28d

stable

Download file

             test-strict.t
        
                    48 lines
            
             | 1.5 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-strict.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Nicolas Dumazet
    
tests: unify test-strict

              r12097
            
        $ hg init

        $ echo a > a

        $ hg ci -Ama

        adding a

        $ hg an a

        0: a

        Yuya Nishihara
    
commands: parse ui.strict config item as bool

              r16591
            
        $ hg --config ui.strict=False an a

        0: a

        Nicolas Dumazet
    
tests: unify test-strict

              r12097
            
        $ echo "[ui]" >> $HGRCPATH

        $ echo "strict=True" >> $HGRCPATH

        $ hg an a

        hg: unknown command 'an'

        Mercurial Distributed SCM

        basic commands:

        Olav Reinert
    
help: format command and option list help using RST...

              r16853
            
         add           add the specified files on the next commit

         annotate      show changeset information by line for each file

         clone         make a copy of an existing repository

         commit        commit the specified files or all outstanding changes

         diff          diff repository (or selected files)

         export        dump the header and diffs for one or more changesets

         forget        forget the specified files on the next commit

         init          create a new repository in the given directory

         log           show revision history of entire repository or files

        anatoly techtonik
    
merge: be precise about what merged into what in short desc

              r23400
            
         merge         merge another revision into working directory

        Olav Reinert
    
help: format command and option list help using RST...

              r16853
            
         pull          pull changes from the specified source

         push          push changes to the specified destination

         remove        remove the specified files on the next commit

         serve         start stand-alone webserver

         status        show changed files in the working directory

         summary       summarize working directory state

         update        update working directory (or switch revisions)

        Nicolas Dumazet
    
tests: unify test-strict

              r12097
            
        Matt Mackall
    
help: normalize helplist hints

              r22118
            
        (use "hg help" for the full list of commands or "hg -v" for details)

        Matt Mackall
    
tests: add exit codes to unified tests

              r12316
            
        [255]

        Nicolas Dumazet
    
tests: unify test-strict

              r12097
            
        $ hg annotate a

        0: a

      should succeed - up is an alias, not an abbreviation

        $ hg up

        0 files updated, 0 files merged, 0 files removed, 0 files unresolved

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Nicolas Dumazet tests: unify test-strict	r12097	$ hg init

		$ echo a > a
		$ hg ci -Ama
		adding a

		$ hg an a
		0: a

Yuya Nishihara commands: parse ui.strict config item as bool	r16591	$ hg --config ui.strict=False an a
		0: a

Nicolas Dumazet tests: unify test-strict	r12097	$ echo "[ui]" >> $HGRCPATH
		$ echo "strict=True" >> $HGRCPATH

		$ hg an a
		hg: unknown command 'an'
		Mercurial Distributed SCM

		basic commands:

Olav Reinert help: format command and option list help using RST...	r16853	add add the specified files on the next commit
		annotate show changeset information by line for each file
		clone make a copy of an existing repository
		commit commit the specified files or all outstanding changes
		diff diff repository (or selected files)
		export dump the header and diffs for one or more changesets
		forget forget the specified files on the next commit
		init create a new repository in the given directory
		log show revision history of entire repository or files
anatoly techtonik merge: be precise about what merged into what in short desc	r23400	merge merge another revision into working directory
Olav Reinert help: format command and option list help using RST...	r16853	pull pull changes from the specified source
		push push changes to the specified destination
		remove remove the specified files on the next commit
		serve start stand-alone webserver
		status show changed files in the working directory
		summary summarize working directory state
		update update working directory (or switch revisions)
Nicolas Dumazet tests: unify test-strict	r12097
Matt Mackall help: normalize helplist hints	r22118	(use "hg help" for the full list of commands or "hg -v" for details)
Matt Mackall tests: add exit codes to unified tests	r12316	[255]
Nicolas Dumazet tests: unify test-strict	r12097	$ hg annotate a
		0: a

		should succeed - up is an alias, not an abbreviation

		$ hg up
		0 files updated, 0 files merged, 0 files removed, 0 files unresolved