##// END OF EJS Templates
largefiles: access to specific fields only if largefiles enabled (issue4547)...
largefiles: access to specific fields only if largefiles enabled (issue4547) Even if largefiles extension is enabled in a repository, "repo" object, which isn't "largefiles.reposetup()"-ed, is passed to overridden functions in the cases below unexpectedly, because extensions are enabled for each repositories strictly. (1) clone without -U: (2) pull with -U: (3) pull with --rebase: combination of "enabled@src", "disabled@dst" and "not-required@src" cause this situation. largefiles requirement @src @dst @src result -------- -------- --------------- -------------------- enabled disabled not-required aborted unexpectedly required requirement error (intentional) -------- -------- --------------- -------------------- enabled enabled * success -------- -------- --------------- -------------------- disabled enabled * success (only for "pull") -------- -------- --------------- -------------------- disabled disabled not-required success required requirement error (intentional) -------- -------- --------------- -------------------- (4) update/revert with a subrepo disabling largefiles In these cases, overridden functions cause accessing to largefiles specific fields of not "largefiles.reposetup()"-ed "repo" object, and execution is aborted. - (1), (2), (4) cause accessing to "_lfstatuswriters" in "getstatuswriter()" invoked via "updatelfiles()" - (3) causes accessing to "_lfcommithooks" in "overriderebase()" For safe accessing to these fields, this patch examines whether passed "repo" object is "largefiles.reposetup()"-ed or not before accessing to them. This patch chooses examining existence of newly introduced "_largefilesenabled" instead of "_lfcommithooks" and "_lfstatuswriters" directly, because the former is better name for the generic "largefiles is enabled in this repo" mark than the latter. In the future, all other overridden functions should avoid largefiles specific processing for efficiency, and "_largefilesenabled" is better also for such purpose. BTW, "lfstatus" can't be used for such purpose, because some code paths set it forcibly regardless of existence of it in specified "repo" object.

File last commit:

r19380:ee07f9d1 default
r24158:d414c28d stable
Show More
test-subrepo-paths.t
61 lines | 1.2 KiB | text/troff | Tads3Lexer
/ tests / test-subrepo-paths.t
Martin Geisler
tests: unify test-subrepo-paths
r11914 $ hg init outer
$ cd outer
Martin Geisler
subrepo: try remapping subpaths using the "final" path...
r15150 $ echo '[paths]' >> .hg/hgrc
$ echo 'default = http://example.net/' >> .hg/hgrc
Martin Geisler
test-subrepo-paths: moved comment lines to where they belong
r11959 hg debugsub with no remapping
Martin Geisler
subrepo: try remapping subpaths using the "final" path...
r15150 $ echo 'sub = libfoo' > .hgsub
Martin Geisler
tests: unify test-subrepo-paths
r11914 $ hg add .hgsub
$ hg debugsub
path sub
Martin Geisler
subrepo: try remapping subpaths using the "final" path...
r15150 source libfoo
Martin Geisler
tests: unify test-subrepo-paths
r11914 revision
Martin Geisler
test-subrepo-paths: moved comment lines to where they belong
r11959 hg debugsub with remapping
Martin Geisler
subrepo: try remapping subpaths using the "final" path...
r15150 $ echo '[subpaths]' >> .hg/hgrc
Simon Heimberg
check-code: do not warn on printf \\x or \\[1-9]...
r19380 $ printf 'http://example.net/lib(.*) = C:\\libs\\\\1-lib\\\n' >> .hg/hgrc
Martin Geisler
tests: unify test-subrepo-paths
r11914
$ hg debugsub
path sub
Martin Geisler
subrepos: handle backslashes in subpaths
r11961 source C:\libs\foo-lib\
Martin Geisler
tests: unify test-subrepo-paths
r11914 revision
Martin Geisler
test-subrepo-paths: fix typo
r13582 test cumulative remapping, the $HGRCPATH file is loaded first
Martin Geisler
test-subrepo-paths: test cummulative remapping
r13578
$ echo '[subpaths]' >> $HGRCPATH
$ echo 'libfoo = libbar' >> $HGRCPATH
$ hg debugsub
path sub
source C:\libs\bar-lib\
revision
Martin Geisler
subrepo: try remapping subpaths using the "final" path...
r15150 test absolute source path -- testing with a URL is important since
standard os.path.join wont treat that as an absolute path
$ echo 'abs = http://example.net/abs' > .hgsub
$ hg debugsub
path abs
source http://example.net/abs
revision
$ echo 'abs = /abs' > .hgsub
$ hg debugsub
path abs
source /abs
revision
Martin Geisler
tests: unify test-subrepo-paths
r11914 test bad subpaths pattern
$ cat > .hg/hgrc <<EOF
> [subpaths]
> .* = \1
> EOF
$ hg debugsub
Mads Kiilerich
tests: make (glob) on windows accept \ instead of /...
r15447 abort: bad subrepository pattern in $TESTTMP/outer/.hg/hgrc:2: invalid group reference (glob)
Matt Mackall
tests: add exit codes to unified tests
r12316 [255]
Mads Kiilerich
tests: add missing trailing 'cd ..'...
r16913
$ cd ..