upstream/mercurial-mirror Files · tests/test-module-imports.t

revset: make descendants() lazier...

revset: make descendants() lazier Previously descendants() would force the provided subset to become a set. In the case of revsets like '(%ld::) - (%ld)' (as used by histedit) this would force the '- (%ld)' set to be evaluated, which produced a set containing every commit in the repo (except %ld). This takes 0.6s on large repos. This changes descendants to trust the subset to implement __contains__ efficiently, which improves the above revset to 0.16s. Shaving 0.4 seconds off of histedit. revset : (20000::) - (20000) 0) obsolete feature not enabled but 54243 markers found! ! wall 0.023640 comb 0.020000 user 0.020000 sys 0.000000 (best of 100) 1) obsolete feature not enabled but 54243 markers found! ! wall 0.019589 comb 0.020000 user 0.020000 sys 0.000000 (best of 100) This commit removes the final revset related perf hotspot from histedit. Combined with the previous two patches, they shave a little over 3 seconds off histedit on large repos.

Durham Goode - - Load All Authors

File last commit:

r20519:cda9d2b6 default


                r22449:da05fe01

default

Download file

             test-module-imports.t
        
                    41 lines
            
             | 1.6 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-module-imports.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Augie Fackler
    
test-module-imports: skip on Python < 2.6, since ast is new in 2.6

              r20059
            
      This code uses the ast module, which was new in 2.6, so we'll skip

      this test on anything earlier.

        $ python -c 'import sys ; assert sys.version_info >= (2, 6)' || exit 80

        Augie Fackler
    
test-module-imports.t: new test to use the import cycle detector

              r20039
            
        $ import_checker="$TESTDIR"/../contrib/import-checker.py

      Run the doctests from the import checker, and make sure

      it's working correctly.

        $ TERM=dumb

        $ export TERM

        $ python -m doctest $import_checker

        $ cd "$TESTDIR"/..

        $ if hg identify -q > /dev/null 2>&1; then :

        > else

        >     echo "skipped: not a Mercurial working dir" >&2

        >     exit 80

        > fi

      There are a handful of cases here that require renaming a module so it

      doesn't overlap with a stdlib module name. There are also some cycles

      here that we should still endeavor to fix, and some cycles will be

      hidden by deduplication algorithm in the cycle detector, so fixing

      these may expose other cycles.

        Simon Heimberg
    
tests: test-module-imports.t works on windows (with backslash path sep)...

              r20395
            
        $ hg locate 'mercurial/**.py' | sed 's-\\-/-g' | xargs python "$import_checker"

        Mads Kiilerich
    
import-checker: show stdlib and relative imports separately...

              r20386
            
        mercurial/dispatch.py mixed imports

           stdlib:    commands

           relative:  error, extensions, fancyopts, hg, hook, util

        mercurial/fileset.py mixed imports

           stdlib:    parser

           relative:  error, merge, util

        mercurial/revset.py mixed imports

           stdlib:    parser

           relative:  discovery, error, hbisect, phases, util

        mercurial/templater.py mixed imports

           stdlib:    parser

        Durham Goode
    
template: add revset() template function...

              r20519
            
           relative:  config, error, templatefilters, templatekw, util

        Mads Kiilerich
    
import-checker: show stdlib and relative imports separately...

              r20386
            
        mercurial/ui.py mixed imports

           stdlib:    formatter

           relative:  config, error, scmutil, util

        Augie Fackler
    
itersubrepos: move to scmutil to break a direct import cycle

              r20392
            
        Import cycle: mercurial.cmdutil -> mercurial.context -> mercurial.subrepo -> mercurial.cmdutil -> mercurial.cmdutil

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Augie Fackler test-module-imports: skip on Python < 2.6, since ast is new in 2.6	r20059	This code uses the ast module, which was new in 2.6, so we'll skip
		this test on anything earlier.
		$ python -c 'import sys ; assert sys.version_info >= (2, 6)' \|\| exit 80

Augie Fackler test-module-imports.t: new test to use the import cycle detector	r20039	$ import_checker="$TESTDIR"/../contrib/import-checker.py
		Run the doctests from the import checker, and make sure
		it's working correctly.
		$ TERM=dumb
		$ export TERM
		$ python -m doctest $import_checker

		$ cd "$TESTDIR"/..
		$ if hg identify -q > /dev/null 2>&1; then :
		> else
		> echo "skipped: not a Mercurial working dir" >&2
		> exit 80
		> fi

		There are a handful of cases here that require renaming a module so it
		doesn't overlap with a stdlib module name. There are also some cycles
		here that we should still endeavor to fix, and some cycles will be
		hidden by deduplication algorithm in the cycle detector, so fixing
		these may expose other cycles.

Simon Heimberg tests: test-module-imports.t works on windows (with backslash path sep)...	r20395	$ hg locate 'mercurial/**.py' \| sed 's-\\-/-g' \| xargs python "$import_checker"
Mads Kiilerich import-checker: show stdlib and relative imports separately...	r20386	mercurial/dispatch.py mixed imports
		stdlib: commands
		relative: error, extensions, fancyopts, hg, hook, util
		mercurial/fileset.py mixed imports
		stdlib: parser
		relative: error, merge, util
		mercurial/revset.py mixed imports
		stdlib: parser
		relative: discovery, error, hbisect, phases, util
		mercurial/templater.py mixed imports
		stdlib: parser
Durham Goode template: add revset() template function...	r20519	relative: config, error, templatefilters, templatekw, util
Mads Kiilerich import-checker: show stdlib and relative imports separately...	r20386	mercurial/ui.py mixed imports
		stdlib: formatter
		relative: config, error, scmutil, util
Augie Fackler itersubrepos: move to scmutil to break a direct import cycle	r20392	Import cycle: mercurial.cmdutil -> mercurial.context -> mercurial.subrepo -> mercurial.cmdutil -> mercurial.cmdutil