upstream/mercurial-mirror Files · hgext/git/TODO.md

hgweb: handle None from templatedir() equally bad in webcommands.py...

hgweb: handle None from templatedir() equally bad in webcommands.py The following paragraph is based just on my reading of the code; I have not tried to test it. Before my recent work on templates in frozen binaries, it seems both `hgwebdir_mod.py` and `webcommands.py` would pass in an empty list into `staticfile()` when running in a frozen binary. That would then result in a variable in that function (`path`) not getting bound before its first use. I then changed that without thinking in D8786 so we passed a `None` value into the function, which made it break in another way (trying to iterate over `None`). Then I tried to fix it up in D8810, but I only changed `hgwebdir_mod.py` for some reason, and it still doesn't actually work in frozen binaries (which seems fair, since was broken before my changes too). This patch just replicates the half-assed "fix" from D8810 in `webcommands.py`, so they look more similar so I can start refactoring them in the same way. Differential Revision: https://phab.mercurial-scm.org/D8933

Josef 'Jeff' Sipek - - Load All Authors

File last commit:

r45111:c5653cf2 default


                r45937:da3b7c80

default

Download file

             TODO.md
        
                    30 lines
            
             | 1.1 KiB
            
                | text/x-minidsrc
            
             |
                MarkdownLexer
            
             / hgext / git / TODO.md
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Augie Fackler
    
git: skeleton of a new extension to _directly_ operate on git repos...

              r44961
            
      Octopus Merge Support

      =====================

      This will be moderately complicated, as we'll need to synthesize phony

      changeset entries to explode the octopus into "revisions" that only

      have two parents each. For today, we can probably just do something like

          aaaaaaaaaaaaaaaaaaXX{20 bytes of exploded node's hex sha}

      where XX is a counter (so we could have as many as 255 parents in a

      git commit - more than I think we'd ever see.) That means that we can

      install some check in this extension to disallow checking out or

      otherwise interacting with the `aaaaaaaaaaaaaaaaaa` revisions.

      Interface Creation

      ====================

      We at least need an interface definition for `changelog` in core that

      this extension can satisfy, and again for `basicstore`.

      Reason About Locking

      ====================

      We should spend some time thinking hard about locking, especially on

      .git/index etc. We're probably adequately locking the _git_

      repository, but may not have enough locking correctness in places

      where hg does locking that git isn't aware of (notably the working

      copy, which I believe Git does not lock.)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Augie Fackler git: skeleton of a new extension to _directly_ operate on git repos...	r44961	Octopus Merge Support
		=====================

		This will be moderately complicated, as we'll need to synthesize phony
		changeset entries to explode the octopus into "revisions" that only
		have two parents each. For today, we can probably just do something like

		aaaaaaaaaaaaaaaaaaXX{20 bytes of exploded node's hex sha}

		where XX is a counter (so we could have as many as 255 parents in a
		git commit - more than I think we'd ever see.) That means that we can
		install some check in this extension to disallow checking out or
		otherwise interacting with the `aaaaaaaaaaaaaaaaaa` revisions.


		Interface Creation
		====================

		We at least need an interface definition for `changelog` in core that
		this extension can satisfy, and again for `basicstore`.


		Reason About Locking
		====================

		We should spend some time thinking hard about locking, especially on
		.git/index etc. We're probably adequately locking the _git_
		repository, but may not have enough locking correctness in places
		where hg does locking that git isn't aware of (notably the working
		copy, which I believe Git does not lock.)