upstream/mercurial-mirror Files · hgext/narrow/TODO.rst

hgweb: handle None from templatedir() equally bad in webcommands.py...

hgweb: handle None from templatedir() equally bad in webcommands.py The following paragraph is based just on my reading of the code; I have not tried to test it. Before my recent work on templates in frozen binaries, it seems both `hgwebdir_mod.py` and `webcommands.py` would pass in an empty list into `staticfile()` when running in a frozen binary. That would then result in a variable in that function (`path`) not getting bound before its first use. I then changed that without thinking in D8786 so we passed a `None` value into the function, which made it break in another way (trying to iterate over `None`). Then I tried to fix it up in D8810, but I only changed `hgwebdir_mod.py` for some reason, and it still doesn't actually work in frozen binaries (which seems fair, since was broken before my changes too). This patch just replicates the half-assed "fix" from D8810 in `webcommands.py`, so they look more similar so I can start refactoring them in the same way. Differential Revision: https://phab.mercurial-scm.org/D8933

Martin von Zweigbergk - - Load All Authors

File last commit:

r41072:ce0bc295 default


                r45937:da3b7c80

default

Download file

             TODO.rst
        
                    21 lines
            
             | 782 B
            
                | text/x-rst
            
             |
                RstLexer
            
             / hgext / narrow / TODO.rst
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Gregory Szorc
    
narrow: remove narrowrevlog...

              r39807
            
      Address commentary in manifest.excludedmanifestrevlog.add -

        Augie Fackler
    
narrow: add a TODO document...

              r36121
            
      specifically we should improve the collaboration with core so that

      add() never gets called on an excluded directory and we can improve

      the stand-in to raise a ProgrammingError.

      Reason more completely about rename-filtering logic in

      narrowfilelog. There could be some surprises lurking there.

        Martin von Zweigbergk
    
narrow: update TODO.rst now that we share format with sparse...

              r40116
            
      Formally document the narrowspec format. For bonus points, unify with the

      server-specified narrowspec format.

        Augie Fackler
    
narrow: add a TODO document...

              r36121
            
      narrowrepo.setnarrowpats() or narrowspec.save() need to make sure

      they're holding the wlock.

        Martin von Zweigbergk
    
narrow: move remaining narrow-limited dirstate walks to core...

              r40123
            
      The follinwg places do an unrestricted dirstate walk (including files outside the

      narrowspec). Some of them should perhaps not do that.

       * debugfileset

       * perfwalk

       * sparse (but restricted to sparse config)

       * largefiles

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Gregory Szorc narrow: remove narrowrevlog...	r39807	Address commentary in manifest.excludedmanifestrevlog.add -
Augie Fackler narrow: add a TODO document...	r36121	specifically we should improve the collaboration with core so that
		add() never gets called on an excluded directory and we can improve
		the stand-in to raise a ProgrammingError.

		Reason more completely about rename-filtering logic in
		narrowfilelog. There could be some surprises lurking there.

Martin von Zweigbergk narrow: update TODO.rst now that we share format with sparse...	r40116	Formally document the narrowspec format. For bonus points, unify with the
		server-specified narrowspec format.
Augie Fackler narrow: add a TODO document...	r36121
		narrowrepo.setnarrowpats() or narrowspec.save() need to make sure
		they're holding the wlock.
Martin von Zweigbergk narrow: move remaining narrow-limited dirstate walks to core...	r40123
		The follinwg places do an unrestricted dirstate walk (including files outside the
		narrowspec). Some of them should perhaps not do that.

		* debugfileset
		* perfwalk
		* sparse (but restricted to sparse config)
		* largefiles