##// END OF EJS Templates
phabricator: combine commit messages into the review when folding commits...
phabricator: combine commit messages into the review when folding commits No visible changes here, until an option to enable it is added to `phabsend`. This combines the Differential fields like Arcanist does, rather than simply concatenating the text blocks. Aside from populating everything properly in the web interface, Phabricator fails the review create/update if repeated fields are seen as would happen with simple concatenation. On the flip side, now that the Summary and Test Plan fields can contain data from multiple commits, we can't just join these fields together to determine if an amend is needed. If that were to happen, every single commit in the folded range would get amended with the combined commit message, which seems clearly wrong. Aside from making a minor assumption about the content of the Differential Revision field (it seems they allow some minor variances with spacing), this means that for folded reviews, you can't post it, go to the web page add a missing Test Plan, and then get it added to the commit message by re-posting it. I don't think that's a big deal. Differential Revision: https://phab.mercurial-scm.org/D8309

File last commit:

r44937:9d2b2df2 default
r45134:dbe9182c default
Show More
uncommit.py
314 lines | 9.7 KiB | text/x-python | PythonLexer
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 # uncommit - undo the actions of a commit
#
# Copyright 2011 Peter Arrenbrecht <peter.arrenbrecht@gmail.com>
# Logilab SA <contact@logilab.fr>
# Pierre-Yves David <pierre-yves.david@ens-lyon.org>
# Patrick Mezard <patrick@mezard.eu>
# Copyright 2016 Facebook, Inc.
#
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version.
"""uncommit part or all of a local changeset (EXPERIMENTAL)
This command undoes the effect of a local commit, returning the affected
files to their uncommitted state. This means that files modified, added or
removed in the changeset will be left unchanged, and so will remain modified,
added and removed in the working directory.
"""
from __future__ import absolute_import
from mercurial.i18n import _
from mercurial import (
Pulkit Goyal
uncommit: don't allow bare uncommit on dirty working directory...
r34285 cmdutil,
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 commands,
context,
Martin von Zweigbergk
unamend: import "copies" module as "copiesmod" to avoid shadowing...
r41370 copies as copiesmod,
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 error,
node,
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177 obsutil,
utils: move the `dirs` definition in pathutil (API)...
r43923 pathutil,
Pulkit Goyal
py3: handle keyword arguments in hgext/uncommit.py...
r35005 pycompat,
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 registrar,
Pulkit Goyal
rewriteutil: use precheck() in uncommit and amend commands...
r35244 rewriteutil,
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 scmutil,
)
cmdtable = {}
command = registrar.command(cmdtable)
Boris Feld
configitems: register the 'experimental.uncommitondirtywdir' config
r34759 configtable = {}
configitem = registrar.configitem(configtable)
Augie Fackler
formatting: blacken the codebase...
r43346 configitem(
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 b'experimental', b'uncommitondirtywdir', default=False,
Boris Feld
configitems: register the 'experimental.uncommitondirtywdir' config
r34759 )
Augie Fackler
formatting: blacken the codebase...
r43346 configitem(
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 b'experimental', b'uncommit.keep', default=False,
Martin von Zweigbergk
uncommit: add config option to keep commit by default...
r41916 )
Boris Feld
configitems: register the 'experimental.uncommitondirtywdir' config
r34759
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 # Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for
# extensions which SHIP WITH MERCURIAL. Non-mainline extensions should
# be specifying the version(s) of Mercurial they are tested with, or
# leave the attribute unspecified.
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 testedwith = b'ships-with-hg-core'
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193
Augie Fackler
formatting: blacken the codebase...
r43346
def _commitfiltered(
repo, ctx, match, keepcommit, message=None, user=None, date=None
):
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 """Recommit ctx with changed files not in match. Return the new
node identifier, or None if nothing changed.
"""
base = ctx.p1()
# ctx
initialfiles = set(ctx.files())
Augie Fackler
cleanup: run pyupgrade on our source tree to clean up varying things...
r44937 exclude = {f for f in initialfiles if match(f)}
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193
# No files matched commit, so nothing excluded
if not exclude:
return None
# return the p1 so that we don't create an obsmarker later
Martin von Zweigbergk
uncommit: simplify condition for keeping commit...
r36992 if not keepcommit:
Martin von Zweigbergk
cleanup: use p1() and p2() instead of parents()[0] and parents()[1]...
r41442 return ctx.p1().node()
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193
Augie Fackler
formatting: blacken the codebase...
r43346 files = initialfiles - exclude
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 # Filter copies
Martin von Zweigbergk
unamend: import "copies" module as "copiesmod" to avoid shadowing...
r41370 copied = copiesmod.pathcopies(base, ctx)
Augie Fackler
cleanup: run pyupgrade on our source tree to clean up varying things...
r44937 copied = {
dst: src for dst, src in pycompat.iteritems(copied) if dst in files
}
Augie Fackler
formatting: blacken the codebase...
r43346
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 def filectxfn(repo, memctx, path, contentctx=ctx, redirect=()):
if path not in contentctx:
return None
fctx = contentctx[path]
Augie Fackler
formatting: blacken the codebase...
r43346 mctx = context.memfilectx(
repo,
memctx,
fctx.path(),
fctx.data(),
fctx.islink(),
fctx.isexec(),
copysource=copied.get(path),
)
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 return mctx
Martin von Zweigbergk
uncommit: inform user if the commit is empty after uncommit...
r41911 if not files:
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 repo.ui.status(_(b"note: keeping empty commit\n"))
Martin von Zweigbergk
uncommit: inform user if the commit is empty after uncommit...
r41911
Matt Harbison
uncommit: add support to modify the commit message and date...
r43172 if message is None:
message = ctx.description()
if not user:
user = ctx.user()
if not date:
date = ctx.date()
Augie Fackler
formatting: blacken the codebase...
r43346 new = context.memctx(
repo,
parents=[base.node(), node.nullid],
text=message,
files=files,
filectxfn=filectxfn,
user=user,
date=date,
extra=ctx.extra(),
)
Martin von Zweigbergk
scmutil: make cleanupnodes optionally also fix the phase...
r38442 return repo.commitctx(new)
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193
Augie Fackler
formatting: blacken the codebase...
r43346
@command(
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 b'uncommit',
Augie Fackler
formatting: blacken the codebase...
r43346 [
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 (b'', b'keep', None, _(b'allow an empty commit after uncommitting')),
Augie Fackler
formatting: blacken the codebase...
r43346 (
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 b'',
b'allow-dirty-working-copy',
Augie Fackler
formatting: blacken the codebase...
r43346 False,
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 _(b'allow uncommit with outstanding changes'),
Augie Fackler
formatting: blacken the codebase...
r43346 ),
(b'n', b'note', b'', _(b'store a note on uncommit'), _(b'TEXT')),
]
+ commands.walkopts
+ commands.commitopts
+ commands.commitopts2
Matt Harbison
uncommit: add options to update to the current user or current date...
r43173 + commands.commitopts3,
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 _(b'[OPTION]... [FILE]...'),
Augie Fackler
formatting: blacken the codebase...
r43346 helpcategory=command.CATEGORY_CHANGE_MANAGEMENT,
)
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 def uncommit(ui, repo, *pats, **opts):
"""uncommit part or all of a local changeset
This command undoes the effect of a local commit, returning the affected
files to their uncommitted state. This means that files modified or
deleted in the changeset will be left unchanged, and so will remain
modified in the working directory.
Martin von Zweigbergk
uncommit: document when the commit will be pruned...
r36991
If no files are specified, the commit will be pruned, unless --keep is
given.
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 """
Pulkit Goyal
py3: handle keyword arguments in hgext/uncommit.py...
r35005 opts = pycompat.byteskwargs(opts)
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193
Matt Harbison
uncommit: enable support for adding a note...
r43206 cmdutil.checknotesize(ui, opts)
Matt Harbison
uncommit: add options to update to the current user or current date...
r43173 cmdutil.resolvecommitoptions(ui, opts)
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 with repo.wlock(), repo.lock():
Augie Fackler
uncommit: use field names instead of field numbers on scmutil.status...
r44042 st = repo.status()
m, a, r, d = st.modified, st.added, st.removed, st.deleted
Navaneeth Suresh
uncommit: don't allow dirty working copy with PATH (issue5977)...
r42025 isdirtypath = any(set(m + a + r + d) & set(pats))
Augie Fackler
formatting: blacken the codebase...
r43346 allowdirtywcopy = opts[
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 b'allow_dirty_working_copy'
] or repo.ui.configbool(b'experimental', b'uncommitondirtywdir')
Navaneeth Suresh
uncommit: add flag --allow-dirty-working-copy...
r42026 if not allowdirtywcopy and (not pats or isdirtypath):
Augie Fackler
formatting: blacken the codebase...
r43346 cmdutil.bailifchanged(
repo,
Martin von Zweigbergk
cleanup: join string literals that are already on one line...
r43387 hint=_(b'requires --allow-dirty-working-copy to uncommit'),
Augie Fackler
formatting: blacken the codebase...
r43346 )
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 old = repo[b'.']
rewriteutil.precheck(repo, [old.rev()], b'uncommit')
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 if len(old.parents()) > 1:
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 raise error.Abort(_(b"cannot uncommit merge changeset"))
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193
Matt Harbison
uncommit: abort if an explicitly given file cannot be uncommitted (BC)...
r42218 match = scmutil.match(old, pats, opts)
# Check all explicitly given files; abort if there's a problem.
if match.files():
s = old.status(old.p1(), match, listclean=True)
eligible = set(s.added) | set(s.modified) | set(s.removed)
badfiles = set(match.files()) - eligible
# Naming a parent directory of an eligible file is OK, even
# if not everything tracked in that directory can be
# uncommitted.
if badfiles:
utils: move the `dirs` definition in pathutil (API)...
r43923 badfiles -= {f for f in pathutil.dirs(eligible)}
Matt Harbison
uncommit: abort if an explicitly given file cannot be uncommitted (BC)...
r42218
for f in sorted(badfiles):
if f in s.clean:
Augie Fackler
formatting: blacken the codebase...
r43346 hint = _(
Martin von Zweigbergk
cleanup: join string literals that are already on one line...
r43387 b"file was not changed in working directory parent"
Augie Fackler
formatting: blacken the codebase...
r43346 )
Matt Harbison
uncommit: abort if an explicitly given file cannot be uncommitted (BC)...
r42218 elif repo.wvfs.exists(f):
hint = _(b"file was untracked in working directory parent")
else:
hint = _(b"file does not exist")
Augie Fackler
formatting: blacken the codebase...
r43346 raise error.Abort(
_(b'cannot uncommit "%s"') % scmutil.getuipathfn(repo)(f),
hint=hint,
)
Matt Harbison
uncommit: abort if an explicitly given file cannot be uncommitted (BC)...
r42218
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 with repo.transaction(b'uncommit'):
Matt Harbison
uncommit: add support to modify the commit message and date...
r43172 if not (opts[b'message'] or opts[b'logfile']):
opts[b'message'] = old.description()
Martin von Zweigbergk
py3: don't double-convert "opts" to bytes...
r43222 message = cmdutil.logmessage(ui, opts)
Matt Harbison
uncommit: add support to modify the commit message and date...
r43172
Martin von Zweigbergk
uncommit: add config option to keep commit by default...
r41916 keepcommit = pats
if not keepcommit:
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 if opts.get(b'keep') is not None:
keepcommit = opts.get(b'keep')
Martin von Zweigbergk
uncommit: add config option to keep commit by default...
r41916 else:
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 keepcommit = ui.configbool(
b'experimental', b'uncommit.keep'
)
Augie Fackler
formatting: blacken the codebase...
r43346 newid = _commitfiltered(
repo,
old,
match,
keepcommit,
message=message,
user=opts.get(b'user'),
date=opts.get(b'date'),
)
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 if newid is None:
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 ui.status(_(b"nothing to uncommit\n"))
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 return 1
mapping = {}
if newid != old.p1().node():
# Move local changes on filtered changeset
mapping[old.node()] = (newid,)
else:
# Fully removed the old commit
mapping[old.node()] = ()
with repo.dirstate.parentchange():
Martin von Zweigbergk
uncommit: move _movedirstate() to scmutil for reuse...
r42103 scmutil.movedirstate(repo, repo[newid], match)
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 scmutil.cleanupnodes(repo, mapping, b'uncommit', fixphase=True)
Martin von Zweigbergk
uncommit: mark old node obsolete after updating dirstate...
r41371
Augie Fackler
formatting: blacken the codebase...
r43346
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177 def predecessormarkers(ctx):
"""yields the obsolete markers marking the given changeset as a successor"""
for data in ctx.repo().obsstore.predecessors.get(ctx.node(), ()):
yield obsutil.marker(ctx.repo(), data)
Augie Fackler
formatting: blacken the codebase...
r43346
@command(
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 b'unamend',
Augie Fackler
formatting: blacken the codebase...
r43346 [],
helpcategory=command.CATEGORY_CHANGE_MANAGEMENT,
helpbasic=True,
)
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177 def unamend(ui, repo, **opts):
Martin von Zweigbergk
unamend: fix command summary line...
r35827 """undo the most recent amend operation on a current changeset
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177
This command will roll back to the previous version of a changeset,
leaving working directory in state in which it was before running
`hg amend` (e.g. files modified as part of an amend will be
marked as modified `hg status`)
"""
unfi = repo.unfiltered()
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 with repo.wlock(), repo.lock(), repo.transaction(b'unamend'):
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177
Pulkit Goyal
unamend: drop unused vars, query after taking lock, use ctx.hex() for extras...
r35201 # identify the commit from which to unamend
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 curctx = repo[b'.']
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 rewriteutil.precheck(repo, [curctx.rev()], b'unamend')
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177
# identify the commit to which to unamend
markers = list(predecessormarkers(curctx))
if len(markers) != 1:
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 e = _(b"changeset must have one predecessor, found %i predecessors")
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177 raise error.Abort(e % len(markers))
prednode = markers[0].prednode()
predctx = unfi[prednode]
# add an extra so that we get a new hash
# note: allowing unamend to undo an unamend is an intentional feature
extras = predctx.extra()
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 extras[b'unamend_source'] = curctx.hex()
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177
def filectxfn(repo, ctx_, path):
try:
return predctx.filectx(path)
except KeyError:
return None
# Make a new commit same as predctx
Augie Fackler
formatting: blacken the codebase...
r43346 newctx = context.memctx(
repo,
parents=(predctx.p1(), predctx.p2()),
text=predctx.description(),
files=predctx.files(),
filectxfn=filectxfn,
user=predctx.user(),
date=predctx.date(),
extra=extras,
)
Martin von Zweigbergk
scmutil: make cleanupnodes optionally also fix the phase...
r38442 newprednode = repo.commitctx(newctx)
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177 newpredctx = repo[newprednode]
dirstate = repo.dirstate
with dirstate.parentchange():
Martin von Zweigbergk
uncommit: move _movedirstate() to scmutil for reuse...
r42103 scmutil.movedirstate(repo, newpredctx)
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177
mapping = {curctx.node(): (newprednode,)}
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 scmutil.cleanupnodes(repo, mapping, b'unamend', fixphase=True)