upstream/mercurial-mirror Files · tests/test-journal-exists.t

changelog: never inline changelog...

changelog: never inline changelog The test suite mostly use small repositories, that implies that most changelog in the tests are inlined. As a result, non-inlined changelog are quite poorly tested. Since non-inline changelog are most common case for serious repositories, this lack of testing is a significant problem that results in high profile issue like the one recently fixed by and 849745d7da89. Inlining the changelog does not bring much to the table, the number of total file saved is negligible, and the changelog will be read by most operation anyway. So this changeset is make it so we never inline the changelog, and de-inline the one that are still inlined whenever we touch them. By doing that, we remove the "dual code path" situation for writing new entry to the changelog and move to a "single code path" situation. Having a single code path simplify the code and make sure it is covered by test (if test cover that situation obviously) This impact all tests that care about the number of file and the exchange size, but there is nothing too complicated in them just a lot of churn. The churn is made "worse" by the fact rust will use the persistent nodemap on any changelog now. Which is overall a win as it means testing the persistent nodemap more and having less special cases. In short, having inline changelog is mostly useless and an endless source of pain. We get rid of it.

marmoute - - Load All Authors

File last commit:

r52074:dcaa2df1 default


                r52074:dcaa2df1

default

Download file

             test-journal-exists.t
        
                    57 lines
            
             | 1.2 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-journal-exists.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Arseniy Alekseyev
    
tests: run many tests in $TESTTMP/repo instead of $TESTTMP...

              r50516
            
        $ hg init repo

        $ cd repo

        Adrian Buehlmann
    
tests: unify test-journal-exists

              r12205
            
        $ echo a > a

        $ hg ci -Am0

        adding a

        $ hg -q clone . foo

        $ touch .hg/store/journal

        $ echo foo > a

        $ hg ci -Am0

        Martin von Zweigbergk
    
errors: remove trailing "!" from some error messages for consistency...

              r46518
            
        abort: abandoned transaction found

        Johan Bjork
    
journal: set Abort hint when failing due to an abandoned transaction

              r21274
            
        (run 'hg recover' to clean up transaction)

        Matt Mackall
    
tests: add exit codes to unified tests

              r12316
            
        [255]

        Adrian Buehlmann
    
tests: unify test-journal-exists

              r12205
            
        $ hg recover

        rolling back interrupted transaction

        Valentin Gatien-Baron
    
recover: don't verify by default...

              r44830
            
        (verify step skipped, run `hg verify` to check your repository content)

        Adrian Buehlmann
    
tests: unify test-journal-exists

              r12205
            
        Valentin Gatien-Baron
    
recover: fix typos...

              r44608
            
      recover, explicit verify

        marmoute
    
recover: add a --[no-]verify flag...

              r42320
            
        $ touch .hg/store/journal

        $ hg ci -Am0

        Martin von Zweigbergk
    
errors: remove trailing "!" from some error messages for consistency...

              r46518
            
        abort: abandoned transaction found

        marmoute
    
recover: add a --[no-]verify flag...

              r42320
            
        (run 'hg recover' to clean up transaction)

        [255]

        Raphaël Gomès
    
tests: use the `--quiet` flag for verify when applicable...

              r50720
            
        $ hg recover --verify  -q

        marmoute
    
recover: add a --[no-]verify flag...

              r42320
            
      recover, no verify

        $ touch .hg/store/journal

        $ hg ci -Am0

        Martin von Zweigbergk
    
errors: remove trailing "!" from some error messages for consistency...

              r46518
            
        abort: abandoned transaction found

        marmoute
    
recover: add a --[no-]verify flag...

              r42320
            
        (run 'hg recover' to clean up transaction)

        [255]

        $ hg recover --no-verify

        rolling back interrupted transaction

        Valentin Gatien-Baron
    
recover: fix typos...

              r44608
            
        (verify step skipped, run `hg verify` to check your repository content)

        marmoute
    
recover: add a --[no-]verify flag...

              r42320
            
        Adrian Buehlmann
    
tests: unify test-journal-exists

              r12205
            
      Check that zero-size journals are correctly aborted:

        Matt Mackall
    
tests: skip tests that require not having root (issue4089)...

              r20008
            
      #if unix-permissions no-root

        Adrian Buehlmann
    
tests: unify test-journal-exists

              r12205
            
        $ hg bundle -qa repo.hg

        $ chmod -w foo/.hg/store/00changelog.i

        $ hg -R foo unbundle repo.hg

        adding changesets

        marmoute
    
changelog: never inline changelog...

              r52074
            
        transaction abort!

        rollback completed

        Arseniy Alekseyev
    
tests: add a rewriting step to detect EACCES errors

              r51215
            
        abort: $EACCES$: '$TESTTMP/repo/foo/.hg/store/.00changelog.i-*' (glob)

        Matt Mackall
    
tests: add exit codes to unified tests

              r12316
            
        [255]

        Adrian Buehlmann
    
tests: unify test-journal-exists

              r12205
            
        $ if test -f foo/.hg/store/journal; then echo 'journal exists :-('; fi

        Adrian Buehlmann
    
test-journal-exists: use #if

              r16959
            
      #endif

        Adrian Buehlmann
    
tests: unify test-journal-exists

              r12205

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Arseniy Alekseyev tests: run many tests in $TESTTMP/repo instead of $TESTTMP...	r50516	$ hg init repo
		$ cd repo
Adrian Buehlmann tests: unify test-journal-exists	r12205	$ echo a > a
		$ hg ci -Am0
		adding a

		$ hg -q clone . foo

		$ touch .hg/store/journal

		$ echo foo > a
		$ hg ci -Am0
Martin von Zweigbergk errors: remove trailing "!" from some error messages for consistency...	r46518	abort: abandoned transaction found
Johan Bjork journal: set Abort hint when failing due to an abandoned transaction	r21274	(run 'hg recover' to clean up transaction)
Matt Mackall tests: add exit codes to unified tests	r12316	[255]
Adrian Buehlmann tests: unify test-journal-exists	r12205
		$ hg recover
		rolling back interrupted transaction
Valentin Gatien-Baron recover: don't verify by default...	r44830	(verify step skipped, run `hg verify` to check your repository content)
Adrian Buehlmann tests: unify test-journal-exists	r12205
Valentin Gatien-Baron recover: fix typos...	r44608	recover, explicit verify
marmoute recover: add a --[no-]verify flag...	r42320
		$ touch .hg/store/journal
		$ hg ci -Am0
Martin von Zweigbergk errors: remove trailing "!" from some error messages for consistency...	r46518	abort: abandoned transaction found
marmoute recover: add a --[no-]verify flag...	r42320	(run 'hg recover' to clean up transaction)
		[255]
Raphaël Gomès tests: use the `--quiet` flag for verify when applicable...	r50720	$ hg recover --verify -q
marmoute recover: add a --[no-]verify flag...	r42320
		recover, no verify

		$ touch .hg/store/journal
		$ hg ci -Am0
Martin von Zweigbergk errors: remove trailing "!" from some error messages for consistency...	r46518	abort: abandoned transaction found
marmoute recover: add a --[no-]verify flag...	r42320	(run 'hg recover' to clean up transaction)
		[255]
		$ hg recover --no-verify
		rolling back interrupted transaction
Valentin Gatien-Baron recover: fix typos...	r44608	(verify step skipped, run `hg verify` to check your repository content)
marmoute recover: add a --[no-]verify flag...	r42320

Adrian Buehlmann tests: unify test-journal-exists	r12205	Check that zero-size journals are correctly aborted:

Matt Mackall tests: skip tests that require not having root (issue4089)...	r20008	#if unix-permissions no-root
Adrian Buehlmann tests: unify test-journal-exists	r12205	$ hg bundle -qa repo.hg
		$ chmod -w foo/.hg/store/00changelog.i

		$ hg -R foo unbundle repo.hg
		adding changesets
marmoute changelog: never inline changelog...	r52074	transaction abort!
		rollback completed
Arseniy Alekseyev tests: add a rewriting step to detect EACCES errors	r51215	abort: $EACCES$: '$TESTTMP/repo/foo/.hg/store/.00changelog.i-*' (glob)
Matt Mackall tests: add exit codes to unified tests	r12316	[255]
Adrian Buehlmann tests: unify test-journal-exists	r12205
		$ if test -f foo/.hg/store/journal; then echo 'journal exists :-('; fi
Adrian Buehlmann test-journal-exists: use #if	r16959	#endif
Adrian Buehlmann tests: unify test-journal-exists	r12205