##// END OF EJS Templates
changelog: never inline changelog...
changelog: never inline changelog The test suite mostly use small repositories, that implies that most changelog in the tests are inlined. As a result, non-inlined changelog are quite poorly tested. Since non-inline changelog are most common case for serious repositories, this lack of testing is a significant problem that results in high profile issue like the one recently fixed by 66417f55ea33 and 849745d7da89. Inlining the changelog does not bring much to the table, the number of total file saved is negligible, and the changelog will be read by most operation anyway. So this changeset is make it so we never inline the changelog, and de-inline the one that are still inlined whenever we touch them. By doing that, we remove the "dual code path" situation for writing new entry to the changelog and move to a "single code path" situation. Having a single code path simplify the code and make sure it is covered by test (if test cover that situation obviously) This impact all tests that care about the number of file and the exchange size, but there is nothing too complicated in them just a lot of churn. The churn is made "worse" by the fact rust will use the persistent nodemap on any changelog now. Which is overall a win as it means testing the persistent nodemap more and having less special cases. In short, having inline changelog is mostly useless and an endless source of pain. We get rid of it.

File last commit:

r52074:dcaa2df1 default
r52074:dcaa2df1 default
Show More
test-relink.t
110 lines | 2.7 KiB | text/troff | Tads3Lexer
Matt Mackall
tests: replace exit 80 with #require
r22046 #require hardlink
Mads Kiilerich
tests: introduce hghave hardlinks...
r16971
Nicolas Dumazet
tests: unify test-relink
r12115 $ echo "[extensions]" >> $HGRCPATH
$ echo "relink=" >> $HGRCPATH
$ fix_path() {
> tr '\\' /
> }
$ cat > arelinked.py <<EOF
Augie Fackler
tests: update test-relink to pass our import checker
r33990 > import os
> import sys
Matt Harbison
py3: byteify extension in test-relink.t
r40343 > from mercurial import (
> pycompat,
> util,
> )
Nicolas Dumazet
tests: unify test-relink
r12115 > path1, path2 = sys.argv[1:3]
Matt Harbison
py3: byteify extension in test-relink.t
r40343 > if util.samefile(pycompat.fsencode(path1), pycompat.fsencode(path2)):
Augie Fackler
tests: update test-relink to pass our import checker
r33990 > print('%s == %s' % (path1, path2))
Nicolas Dumazet
tests: unify test-relink
r12115 > else:
Augie Fackler
tests: update test-relink to pass our import checker
r33990 > print('%s != %s' % (path1, path2))
Nicolas Dumazet
tests: unify test-relink
r12115 > EOF
create source repository
$ hg init repo
$ cd repo
$ echo a > a
$ echo b > b
$ hg ci -Am addfile
adding a
adding b
Thomas Arendsen Hein
tests: make tests work if directory contains special characters...
r16350 $ cat "$TESTDIR/binfile.bin" >> a
$ cat "$TESTDIR/binfile.bin" >> b
Nicolas Dumazet
tests: unify test-relink
r12115 $ hg ci -Am changefiles
Martin Geisler
relink: format reclaimed byte count nicely
r13656 make another commit to create files larger than 1 KB to test
formatting of final byte count
Thomas Arendsen Hein
tests: make tests work if directory contains special characters...
r16350 $ cat "$TESTDIR/binfile.bin" >> a
$ cat "$TESTDIR/binfile.bin" >> b
Martin Geisler
relink: format reclaimed byte count nicely
r13656 $ hg ci -m anotherchange
Martin Geisler
relink: avoid trying to lock the same repo twice
r13657 don't sit forever trying to double-lock the source repo
$ hg relink .
Matt Harbison
tests: remove (glob) annotations that were only for '\' matches...
r35394 relinking $TESTTMP/repo/.hg/store to $TESTTMP/repo/.hg/store
Martin Geisler
relink: avoid trying to lock the same repo twice
r13657 there is nothing to relink
Martin Geisler
merge with stable
r13659
Nicolas Dumazet
tests: unify test-relink
r12115 Test files are read in binary mode
Matt Harbison
tests: quote PYTHON usage...
r39743 $ "$PYTHON" -c "open('.hg/store/data/dummy.i', 'wb').write(b'a\r\nb\n')"
Nicolas Dumazet
tests: unify test-relink
r12115 $ cd ..
clone and pull to break links
$ hg clone --pull -r0 repo clone
adding changesets
adding manifests
adding file changes
added 1 changesets with 2 changes to 2 files
Denis Laxalde
transaction-summary: show the range of new revisions upon pull/unbundle (BC)...
r34662 new changesets 008c0c271c47
Nicolas Dumazet
tests: unify test-relink
r12115 updating to branch default
2 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ cd clone
$ hg pull -q
$ echo b >> b
$ hg ci -m changeb
created new head
Matt Harbison
tests: quote PYTHON usage...
r39743 $ "$PYTHON" -c "open('.hg/store/data/dummy.i', 'wb').write(b'a\nb\r\n')"
Nicolas Dumazet
tests: unify test-relink
r12115
relink
Gregory Szorc
tests: conditionalize tests based on presence of revlogs for files...
r37356 #if no-reposimplestore
Pierre-Yves David
progress: get the extremely verbose output out of default debug...
r25125 $ hg relink --debug --config progress.debug=true | fix_path
Mads Kiilerich
tests: remove redundant globs...
r12640 relinking $TESTTMP/repo/.hg/store to $TESTTMP/clone/.hg/store
Nicolas Dumazet
tests: unify test-relink
r12115 tip has 2 files, estimated total number of files: 3
changelog: never inline changelog...
r52074 collecting: 00changelog.d 1/3 files (33.33%)
collecting: 00changelog.i 2/3 files (66.67%)
collecting: 00manifest.i 3/3 files (100.00%)
collecting: a.i 4/3 files (133.33%)
collecting: b.i 5/3 files (166.67%)
collecting: dummy.i 6/3 files (200.00%)
collected 6 candidate storage files
not linkable: 00changelog.d
Nicolas Dumazet
tests: unify test-relink
r12115 not linkable: 00changelog.i
not linkable: 00manifest.i
changelog: never inline changelog...
r52074 pruning: data/a.i 4/6 files (66.67%)
Nicolas Dumazet
tests: unify test-relink
r12115 not linkable: data/b.i
changelog: never inline changelog...
r52074 pruning: data/dummy.i 6/6 files (100.00%)
Nicolas Dumazet
tests: unify test-relink
r12115 pruned down to 2 probably relinkable files
timeless
progress: dropping superfluous space from units
r12744 relinking: data/a.i 1/2 files (50.00%)
Nicolas Dumazet
tests: unify test-relink
r12115 not linkable: data/dummy.i
Siddharth Agarwal
revlog: store fulltext when compressed delta is bigger than it...
r23285 relinked 1 files (1.36 KB reclaimed)
Nicolas Dumazet
tests: unify test-relink
r12115 $ cd ..
check hardlinks
Matt Harbison
tests: quote PYTHON usage...
r39743 $ "$PYTHON" arelinked.py repo/.hg/store/data/a.i clone/.hg/store/data/a.i
Nicolas Dumazet
tests: unify test-relink
r12115 repo/.hg/store/data/a.i == clone/.hg/store/data/a.i
Matt Harbison
tests: quote PYTHON usage...
r39743 $ "$PYTHON" arelinked.py repo/.hg/store/data/b.i clone/.hg/store/data/b.i
Nicolas Dumazet
tests: unify test-relink
r12115 repo/.hg/store/data/b.i != clone/.hg/store/data/b.i
Gregory Szorc
tests: conditionalize tests based on presence of revlogs for files...
r37356 #endif