##// END OF EJS Templates
upstream » mercurial-mirror
RSS

Clone from https://www.mercurial-scm.org/repo/hg-all

hgwebdir: avoid systematic full garbage collection...
hgwebdir: avoid systematic full garbage collection Forcing a systematic full garbage collection upon each request can serioulsy harm performance. This is reported as https://bz.mercurial-scm.org/show_bug.cgi?id=6075 With this change we're performing the full collection according to a new setting, `experimental.web.full-garbage-collection-rate`. The default value is 1, which doesn't change the behavior and will allow us to test on real use cases. If the value is 0, no full garbage collection occurs. Regardless of the value of the setting, a partial garbage collection still occurs upon each request (not attempting to collect objects from the oldest generation). This should be enough to take care of reference cycles that have been created by the last request (assessment of this requires changing the setting, not to be 1). In my experience chasing memory leaks in Mercurial servers, the full collection never reclaimed any memory, but this is with Python 3 and biased towards small repositories. On the other hand, as explained in the Python developer docs [1], frequent full collections are very harmful in terms of performance if lots of objects survive the collection, and hence stay in the oldest generation. Note that `gc.collect()` is indeed trying to collect the oldest generation [2]. This happens usually in two cases: - unwanted lingering objects (i.e., an actual memory leak that the GC cannot do anything about). Sadly, we have lots of those these days. - desireable long-term objects, typically in caches (not inner caches carried by repositories, which should be collected with them). This is a subject of interest for the Heptapod project. In short, the flat rate that this change still permits is probably a bad idea in most cases, and the default value can be tweaked later on (or even be set to 0) according to experiments in the wild. The test is inspired from test-hgwebdir-paths.py [1] https://devguide.python.org/garbage_collector/#collecting-the-oldest-generation [2] https://docs.python.org/3/library/gc.html#gc.collect Differential Revision: https://phab.mercurial-scm.org/D11204
Pulkit Goyal - - Load All Authors

File last commit:

r48196:ebdef628 default
r48581:de2e04fe default
Show More
Cargo.toml
22 lines | 427 B | application/toml | TOMLLexer
/ rust / rhg / Cargo.toml
History | Source | Raw |Copy content |Copy permalink
Antoine Cezar
rhg: add rhg crate...
 r45503 [package]
name = "rhg"
version = "0.1.0"
Raphaël Gomès
rhg: use `format_bytes!` for error messages...
 r46598 authors = [
"Antoine Cezar <antoine.cezar@octobus.net>",
"Raphaël Gomès <raphael.gomes@octobus.net>",
]
Antoine Cezar
rhg: add rhg crate...
 r45503 edition = "2018"
[dependencies]
Antoine Cezar
rhg: add RootCommand using hg-core FindRoot operation to prepare `hg root`...
 r45592 hg-core = { path = "../hg-core"}
Simon Sapin
rhg: Add support for the blackbox extension...
 r47343 chrono = "0.4.19"
Antoine Cezar
rhg: add a limited `rhg root` subcommand...
 r45593 clap = "2.33.1"
Simon Sapin
rust: replace trivial `impl From …` with `#[derive(derive_more::From)]`...
 r47164 derive_more = "0.99"
Pulkit Goyal
rhg: read [paths] for `--repository` value...
 r48196 home = "0.5.3"
Simon Sapin
rhg: Fall back to Python on --repository with an URL...
 r47463 lazy_static = "1.4.0"
Antoine Cezar
rhg: Add debug timing...
 r46101 log = "0.4.11"
micro-timer = "0.3.1"
Simon Sapin
rhg: Fall back to Python on --repository with an URL...
 r47463 regex = "1.3.9"
Antoine Cezar
rhg: Add debug timing...
 r46101 env_logger = "0.7.1"
Simon Sapin
rhg: Fall back to Python if unsupported extensions are enabled...
 r47467 format-bytes = "0.2.1"
Simon Sapin
rhg: Add support for the blackbox extension...
 r47343 users = "0.11.0"