upstream/mercurial-mirror Files · mercurial/compat.h

statichttprepo: fix `httprangereader.read()` for py3...

statichttprepo: fix `httprangereader.read()` for py3 It looks like there were a bunch of problems, not all of them py3 related: 1) The signature of BinaryIO.read() is -1, not None 2) The `end` variable can't be bytes and interpolate into str with "%s" 3) The `end` variable can't be an int and interpolate into str with "%s" 4) The result slicing could be out of bounds if more is requested than returned I guess if somebody would have called `read(-1)` (either directly or because a wrapper defaults to that), it wouldn't have been handled correctly. The fact that it is a valid value meaning to read everything requires some additional changes later in the method around when it slices the byte string that was read, but that seems to have already been broken.

David Demelier - - Load All Authors

File last commit:

r49095:d8690805 default


                r52792:e26a0856

default

Download file

             compat.h
        
                    58 lines
            
             | 1.0 KiB
            
                | text/x-c
            
             |
                CLexer
            
             / mercurial / compat.h
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        David Demelier
    
hg: remove reserved identifiers...

              r49095
            
      #ifndef HG_COMPAT_H

      #define HG_COMPAT_H

        Maciej Fijalkowski
    
internals: move the bitmanipulation routines into its own file...

              r29444
            
      #ifdef _WIN32

      #ifdef _MSC_VER

        Matt Harbison
    
cext: fix warnings when building for py3 on Windows...

              r39646
            
      #if _MSC_VER < 1900

        Maciej Fijalkowski
    
internals: move the bitmanipulation routines into its own file...

              r29444
            
      /* msvc 6.0 has problems */

      #define inline __inline

        Maciej Fijalkowski
    
compat: provide a declaration of ssize_t, for MS windows

              r29521
            
      #if defined(_WIN64)

      typedef __int64 ssize_t;

        Yuya Nishihara
    
encoding: add function to test if a str consists of ASCII characters...

              r33927
            
      typedef unsigned __int64 uintptr_t;

        Maciej Fijalkowski
    
compat: provide a declaration of ssize_t, for MS windows

              r29521
            
      #else

        Yuya Nishihara
    
compat: define ssize_t as int on 32bit Windows, silences C4142 warning...

              r29549
            
      typedef int ssize_t;

        Yuya Nishihara
    
encoding: add function to test if a str consists of ASCII characters...

              r33927
            
      typedef unsigned int uintptr_t;

        Maciej Fijalkowski
    
compat: provide a declaration of ssize_t, for MS windows

              r29521
            
      #endif

        Maciej Fijalkowski
    
internals: move the bitmanipulation routines into its own file...

              r29444
            
      typedef signed char int8_t;

      typedef short int16_t;

      typedef long int32_t;

      typedef __int64 int64_t;

      typedef unsigned char uint8_t;

      typedef unsigned short uint16_t;

      typedef unsigned long uint32_t;

      typedef unsigned __int64 uint64_t;

      #else

        Matt Harbison
    
cext: fix warnings when building for py3 on Windows...

              r39646
            
      /* VC++ 14 */

      #include <stdint.h>

      #if defined(_WIN64)

      typedef __int64 ssize_t;

      #else

      typedef int ssize_t;

      #endif

      #endif /* _MSC_VER < 1900 */

      #else

      /* not msvc */

        Maciej Fijalkowski
    
internals: move the bitmanipulation routines into its own file...

              r29444
            
      #include <stdint.h>

      #endif

      #else

      /* not windows */

      #include <sys/types.h>

      #if defined __BEOS__ && !defined __HAIKU__

      #include <ByteOrder.h>

      #else

      #include <arpa/inet.h>

      #endif

      #include <inttypes.h>

      #endif

      #if defined __hpux || defined __SUNPRO_C || defined _AIX

      #define inline

      #endif

      #ifdef __linux

      #define inline __inline

      #endif

      #endif

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

David Demelier hg: remove reserved identifiers...	r49095	#ifndef HG_COMPAT_H
		#define HG_COMPAT_H
Maciej Fijalkowski internals: move the bitmanipulation routines into its own file...	r29444
		#ifdef _WIN32
		#ifdef _MSC_VER
Matt Harbison cext: fix warnings when building for py3 on Windows...	r39646	#if _MSC_VER < 1900
Maciej Fijalkowski internals: move the bitmanipulation routines into its own file...	r29444	/* msvc 6.0 has problems */
		#define inline __inline
Maciej Fijalkowski compat: provide a declaration of ssize_t, for MS windows	r29521	#if defined(_WIN64)
		typedef __int64 ssize_t;
Yuya Nishihara encoding: add function to test if a str consists of ASCII characters...	r33927	typedef unsigned __int64 uintptr_t;
Maciej Fijalkowski compat: provide a declaration of ssize_t, for MS windows	r29521	#else
Yuya Nishihara compat: define ssize_t as int on 32bit Windows, silences C4142 warning...	r29549	typedef int ssize_t;
Yuya Nishihara encoding: add function to test if a str consists of ASCII characters...	r33927	typedef unsigned int uintptr_t;
Maciej Fijalkowski compat: provide a declaration of ssize_t, for MS windows	r29521	#endif
Maciej Fijalkowski internals: move the bitmanipulation routines into its own file...	r29444	typedef signed char int8_t;
		typedef short int16_t;
		typedef long int32_t;
		typedef __int64 int64_t;
		typedef unsigned char uint8_t;
		typedef unsigned short uint16_t;
		typedef unsigned long uint32_t;
		typedef unsigned __int64 uint64_t;
		#else
Matt Harbison cext: fix warnings when building for py3 on Windows...	r39646	/* VC++ 14 */
		#include <stdint.h>

		#if defined(_WIN64)
		typedef __int64 ssize_t;
		#else
		typedef int ssize_t;
		#endif
		#endif /* _MSC_VER < 1900 */

		#else
		/* not msvc */
Maciej Fijalkowski internals: move the bitmanipulation routines into its own file...	r29444	#include <stdint.h>
		#endif
		#else
		/* not windows */
		#include <sys/types.h>
		#if defined __BEOS__ && !defined __HAIKU__
		#include <ByteOrder.h>
		#else
		#include <arpa/inet.h>
		#endif
		#include <inttypes.h>
		#endif

		#if defined __hpux \|\| defined __SUNPRO_C \|\| defined _AIX
		#define inline
		#endif

		#ifdef __linux
		#define inline __inline
		#endif

		#endif