##// END OF EJS Templates
statichttprepo: fix `httprangereader.read()` for py3...
statichttprepo: fix `httprangereader.read()` for py3 It looks like there were a bunch of problems, not all of them py3 related: 1) The signature of BinaryIO.read() is -1, not None 2) The `end` variable can't be bytes and interpolate into str with "%s" 3) The `end` variable can't be an int and interpolate into str with "%s" 4) The result slicing could be out of bounds if more is requested than returned I guess if somebody would have called `read(-1)` (either directly or because a wrapper defaults to that), it wouldn't have been handled correctly. The fact that it is a valid value meaning to read everything requires some additional changes later in the method around when it slices the byte string that was read, but that seems to have already been broken.

File last commit:

r52755:607e94e0 default
r52792:e26a0856 default
Show More
__init__.py
55 lines | 1.5 KiB | text/x-python | PythonLexer
Matt Harbison
format: add many "missing" comma...
r52755 from __future__ import annotations
testing: add a utility function to wait for file create...
r47746 import os
import time
# work around check-code complains
#
# This is a simple log level module doing simple test related work, we can't
# import more things, and we do not need it.
environ = getattr(os, 'environ')
Raphaël Gomès
testing: introduce util function to synchronize concurrent commands on files...
r51109 def wait_on_cfg(ui, cfg, timeout=10):
"""synchronize on the `cfg` config path
Use this to synchronize commands during race tests.
"""
full_config = b'sync.' + cfg
wait_config = full_config + b'-timeout'
sync_path = ui.config(b'devel', full_config)
if sync_path is not None:
timeout = ui.config(b'devel', wait_config)
ready_path = sync_path + b'.waiting'
write_file(ready_path)
wait_file(sync_path, timeout=timeout)
testing: add a utility function to wait for file create...
r47746 def _timeout_factor():
"""return the current modification to timeout"""
testing: fix _timeout_factor...
r48287 default = int(environ.get('HGTEST_TIMEOUT_DEFAULT', 360))
testing: add a utility function to wait for file create...
r47746 current = int(environ.get('HGTEST_TIMEOUT', default))
testing: fix _timeout_factor...
r48287 if current == 0:
return 1
testing: add a utility function to wait for file create...
r47746 return current / float(default)
def wait_file(path, timeout=10):
timeout *= _timeout_factor()
start = time.time()
while not os.path.exists(path):
Cédric Krier
testing: do not stop waiting if timeout is 0 (issue6541)...
r48457 if timeout and time.time() - start > timeout:
testing: add a utility function to wait for file create...
r47746 raise RuntimeError(b"timed out waiting for file: %s" % path)
time.sleep(0.01)
testing: add a `write_file` function...
r47747
def write_file(path, content=b''):
testing: make sure write_file is "atomic"...
r48604 if content:
write_path = b'%s.tmp' % path
else:
write_path = path
with open(write_path, 'wb') as f:
testing: add a `write_file` function...
r47747 f.write(content)
testing: make sure write_file is "atomic"...
r48604 if path != write_path:
os.rename(write_path, path)