upstream/mercurial-mirror Files · contrib/chg/util.h

rust-cpython: mark all PyLeaked methods as unsafe...

rust-cpython: mark all PyLeaked methods as unsafe Unfortunately, these methods can be abused to obtain the inner 'static reference. The simplest (pseudo-code) example is: let leaked: PyLeaked<&'static _> = shared.leak_immutable(); let static_ref: &'static _ = &*leaked.try_borrow(py)?; // PyLeakedRef::deref() tries to bound the lifetime to itself, but // the underlying data is a &'static reference, so the returned // reference can be &'static. This problem can be easily fixed by coercing the lifetime, but there are many other ways to achieve that, and there wouldn't be a generic solution: let leaked: PyLeaked<&'static [_]> = shared.leak_immutable(); let leaked_iter: PyLeaked<slice::Iter<'static, _>> = unsafe { leaked.map(|v| v.iter()) }; let static_slice: &'static [_] = leaked_iter.try_borrow(py)?.as_slice(); So basically I failed to design the safe borrowing interface. Maybe we'll instead have to add much more restricted interface on top of the unsafe PyLeaked methods? For instance, Iterator::next() could be implemented if its Item type is not &'a (where 'a may be cheated.) Anyway, this seems not an easy issue, so it's probably better to leave the current interface as unsafe, and get broader comments while upstreaming this feature.

Augie Fackler - - Load All Authors

File last commit:

r35977:9724f549 default


                r44689:e960c30d

default

Download file

             util.h
        
                    35 lines
            
             | 855 B
            
                | text/x-c
            
             |
                CLexer
            
             / contrib / chg / util.h
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Yuya Nishihara
    
chg: import frontend sources...

              r28060
            
      /*

       * Utility functions

       *

       * Copyright (c) 2011 Yuya Nishihara <yuya@tcha.org>

       *

       * This software may be used and distributed according to the terms of the

       * GNU General Public License version 2 or any later version.

       */

      #ifndef UTIL_H_

      #define UTIL_H_

      #ifdef __GNUC__

      #define PRINTF_FORMAT_ __attribute__((format(printf, 1, 2)))

        Yuya Nishihara
    
chg: silence warning of unused parameter 'sig'

              r29440
            
      #define UNUSED_ __attribute__((unused))

        Jun Wu
    
chg: define PRINTF_FORMAT_ for non gnu C compiler...

              r28604
            
      #else

      #define PRINTF_FORMAT_

        Yuya Nishihara
    
chg: silence warning of unused parameter 'sig'

              r29440
            
      #define UNUSED_

        Yuya Nishihara
    
chg: import frontend sources...

              r28060
            
      #endif

      void abortmsg(const char *fmt, ...) PRINTF_FORMAT_;

        Jun Wu
    
chg: add util function abortmsgerrno to print error with errno...

              r28788
            
      void abortmsgerrno(const char *fmt, ...) PRINTF_FORMAT_;

        Yuya Nishihara
    
chg: import frontend sources...

              r28060
            
        Jun Wu
    
chg: use color in debug/error messages conditionally...

              r28787
            
      void enablecolor(void);

        Yuya Nishihara
    
chg: import frontend sources...

              r28060
            
      void enabledebugmsg(void);

      void debugmsg(const char *fmt, ...) PRINTF_FORMAT_;

        Jun Wu
    
chg: add fchdirx as a utility function...

              r28854
            
      void fchdirx(int dirfd);

        Jun Wu
    
chg: extract the logic of setting FD_CLOEXEC to a utility function...

              r28855
            
      void fsetcloexec(int fd);

        Jun Wu
    
chg: add utility functions mallocx, reallocx...

              r28165
            
      void *mallocx(size_t size);

      void *reallocx(void *ptr, size_t size);

        Yuya Nishihara
    
chg: import frontend sources...

              r28060
            
      int runshellcmd(const char *cmd, const char *envp[], const char *cwd);

        Augie Fackler
    
chg: enable clang-format on all .c and .h files...

              r35977
            
      #endif /* UTIL_H_ */

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Yuya Nishihara chg: import frontend sources...	r28060	/*
		* Utility functions
		*
		* Copyright (c) 2011 Yuya Nishihara <yuya@tcha.org>
		*
		* This software may be used and distributed according to the terms of the
		* GNU General Public License version 2 or any later version.
		*/

		#ifndef UTIL_H_
		#define UTIL_H_

		#ifdef __GNUC__
		#define PRINTF_FORMAT_ __attribute__((format(printf, 1, 2)))
Yuya Nishihara chg: silence warning of unused parameter 'sig'	r29440	#define UNUSED_ __attribute__((unused))
Jun Wu chg: define PRINTF_FORMAT_ for non gnu C compiler...	r28604	#else
		#define PRINTF_FORMAT_
Yuya Nishihara chg: silence warning of unused parameter 'sig'	r29440	#define UNUSED_
Yuya Nishihara chg: import frontend sources...	r28060	#endif

		void abortmsg(const char *fmt, ...) PRINTF_FORMAT_;
Jun Wu chg: add util function abortmsgerrno to print error with errno...	r28788	void abortmsgerrno(const char *fmt, ...) PRINTF_FORMAT_;
Yuya Nishihara chg: import frontend sources...	r28060
Jun Wu chg: use color in debug/error messages conditionally...	r28787	void enablecolor(void);
Yuya Nishihara chg: import frontend sources...	r28060	void enabledebugmsg(void);
		void debugmsg(const char *fmt, ...) PRINTF_FORMAT_;

Jun Wu chg: add fchdirx as a utility function...	r28854	void fchdirx(int dirfd);
Jun Wu chg: extract the logic of setting FD_CLOEXEC to a utility function...	r28855	void fsetcloexec(int fd);
Jun Wu chg: add utility functions mallocx, reallocx...	r28165	void *mallocx(size_t size);
		void reallocx(void ptr, size_t size);

Yuya Nishihara chg: import frontend sources...	r28060	int runshellcmd(const char cmd, const char envp[], const char *cwd);

Augie Fackler chg: enable clang-format on all .c and .h files...	r35977	#endif /* UTIL_H_ */