upstream/mercurial-mirror Files · contrib/packaging/packagelib.sh

rust-cpython: mark all PyLeaked methods as unsafe...

rust-cpython: mark all PyLeaked methods as unsafe Unfortunately, these methods can be abused to obtain the inner 'static reference. The simplest (pseudo-code) example is: let leaked: PyLeaked<&'static _> = shared.leak_immutable(); let static_ref: &'static _ = &*leaked.try_borrow(py)?; // PyLeakedRef::deref() tries to bound the lifetime to itself, but // the underlying data is a &'static reference, so the returned // reference can be &'static. This problem can be easily fixed by coercing the lifetime, but there are many other ways to achieve that, and there wouldn't be a generic solution: let leaked: PyLeaked<&'static [_]> = shared.leak_immutable(); let leaked_iter: PyLeaked<slice::Iter<'static, _>> = unsafe { leaked.map(|v| v.iter()) }; let static_slice: &'static [_] = leaked_iter.try_borrow(py)?.as_slice(); So basically I failed to design the safe borrowing interface. Maybe we'll instead have to add much more restricted interface on top of the unsafe PyLeaked methods? For instance, Iterator::next() could be implemented if its Item type is not &'a (where 'a may be cheated.) Anyway, this seems not an easy issue, so it's probably better to leave the current interface as unsafe, and get broader comments while upstreaming this feature.

Mathias De Mare - - Load All Authors

File last commit:

r41759:8f0e8b17 stable


                r44689:e960c30d

default

Download file

             packagelib.sh
        
                    38 lines
            
             | 1.1 KiB
            
                | application/x-sh
            
             |
                BashLexer
            
             / contrib / packaging / packagelib.sh
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Gregory Szorc
    
packaging: move packagelib.sh into contrib/packaging/...

              r38025
            
      # Extract version number into 4 parts, some of which may be empty:

      #

      # version: the numeric part of the most recent tag. Will always look like 1.3.

      #

      # type: if an rc build, "rc", otherwise empty

      #

      # distance: the distance from the nearest tag, or empty if built from a tag

      #

      # node: the node|short hg was built from, or empty if built from a tag

      gethgversion() {

          export HGRCPATH=

          export HGPLAIN=

          make cleanbutpackages

          make local PURE=--pure

          HG="$PWD/hg"

          "$HG" version > /dev/null || { echo 'abort: hg version failed!'; exit 1 ; }

          hgversion=`LANGUAGE=C "$HG" version | sed -ne 's/.*(version \(.*\))$/\1/p'`

          if echo $hgversion | grep + > /dev/null 2>&1 ; then

              tmp=`echo $hgversion | cut -d+ -f 2`

              hgversion=`echo $hgversion | cut -d+ -f 1`

              distance=`echo $tmp | cut -d- -f 1`

              node=`echo $tmp | cut -d- -f 2`

          else

              distance=''

              node=''

          fi

        Mathias De Mare
    
packaging: modify rc detection to work with X.Yrc instead of X.Y-rc...

              r41759
            
          if echo $hgversion | grep -E -- '[0-9]\.[0-9](\.[0-9])?rc' > /dev/null 2>&1; then

              version=`echo $hgversion | cut -d'r' -f1`

              type="rc`echo $hgversion | cut -d'c' -f2-`"

        Gregory Szorc
    
packaging: move packagelib.sh into contrib/packaging/...

              r38025
            
          else

              version=$hgversion

              type=''

          fi

      }

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Gregory Szorc packaging: move packagelib.sh into contrib/packaging/...	r38025	# Extract version number into 4 parts, some of which may be empty:
		#
		# version: the numeric part of the most recent tag. Will always look like 1.3.
		#
		# type: if an rc build, "rc", otherwise empty
		#
		# distance: the distance from the nearest tag, or empty if built from a tag
		#
		# node: the node\|short hg was built from, or empty if built from a tag
		gethgversion() {
		export HGRCPATH=
		export HGPLAIN=

		make cleanbutpackages
		make local PURE=--pure
		HG="$PWD/hg"

		"$HG" version > /dev/null \|\| { echo 'abort: hg version failed!'; exit 1 ; }

		hgversion=`LANGUAGE=C "$HG" version \| sed -ne 's/.(version \(.\))$/\1/p'`

		if echo $hgversion \| grep + > /dev/null 2>&1 ; then
		tmp=`echo $hgversion \| cut -d+ -f 2`
		hgversion=`echo $hgversion \| cut -d+ -f 1`
		distance=`echo $tmp \| cut -d- -f 1`
		node=`echo $tmp \| cut -d- -f 2`
		else
		distance=''
		node=''
		fi
Mathias De Mare packaging: modify rc detection to work with X.Yrc instead of X.Y-rc...	r41759	if echo $hgversion \| grep -E -- '[0-9]\.[0-9](\.[0-9])?rc' > /dev/null 2>&1; then
		version=`echo $hgversion \| cut -d'r' -f1`
		type="rc`echo $hgversion \| cut -d'c' -f2-`"
Gregory Szorc packaging: move packagelib.sh into contrib/packaging/...	r38025	else
		version=$hgversion
		type=''
		fi
		}