##// END OF EJS Templates
upstream » mercurial-mirror
RSS

Clone from https://www.mercurial-scm.org/repo/hg-all

rust-cpython: mark all PyLeaked methods as unsafe...
rust-cpython: mark all PyLeaked methods as unsafe Unfortunately, these methods can be abused to obtain the inner 'static reference. The simplest (pseudo-code) example is: let leaked: PyLeaked<&'static _> = shared.leak_immutable(); let static_ref: &'static _ = &*leaked.try_borrow(py)?; // PyLeakedRef::deref() tries to bound the lifetime to itself, but // the underlying data is a &'static reference, so the returned // reference can be &'static. This problem can be easily fixed by coercing the lifetime, but there are many other ways to achieve that, and there wouldn't be a generic solution: let leaked: PyLeaked<&'static [_]> = shared.leak_immutable(); let leaked_iter: PyLeaked<slice::Iter<'static, _>> = unsafe { leaked.map(|v| v.iter()) }; let static_slice: &'static [_] = leaked_iter.try_borrow(py)?.as_slice(); So basically I failed to design the safe borrowing interface. Maybe we'll instead have to add much more restricted interface on top of the unsafe PyLeaked methods? For instance, Iterator::next() could be implemented if its Item type is not &'a (where 'a may be cheated.) Anyway, this seems not an easy issue, so it's probably better to leave the current interface as unsafe, and get broader comments while upstreaming this feature.
Augie Fackler - - Load All Authors

File last commit:

r43346:2372284d default
r44689:e960c30d default
Show More
python-hook-examples.py
27 lines | 633 B | text/x-python | PythonLexer
/ contrib / python-hook-examples.py
History | Source | Raw |Copy content |Copy permalink
Alexander Solovyov
diffstat hook example
 r7917 '''
Benoit Boissinot
Change wording in example hook
 r7918 Examples of useful python hooks for Mercurial.
Alexander Solovyov
diffstat hook example
 r7917 '''
Pulkit Goyal
contrib: python-hook-examples use absolute_import
 r28562 from __future__ import absolute_import
from mercurial import (
patch,
util,
)
Alexander Solovyov
diffstat hook example
 r7917
Augie Fackler
formatting: blacken the codebase...
 r43346
Alexander Solovyov
diffstat hook example
 r7917 def diffstat(ui, repo, **kwargs):
Benoit Boissinot
Change wording in example hook
 r7918 '''Example usage:
Alexander Solovyov
diffstat hook example
 r7917
[hooks]
commit.diffstat = python:/path/to/this/file.py:diffstat
changegroup.diffstat = python:/path/to/this/file.py:diffstat
'''
if kwargs.get('parent2'):
return
node = kwargs['node']
Matt Mackall
misc: replace .parents()[0] with p1()
 r13878 first = repo[node].p1().node()
Alexander Solovyov
diffstat hook example
 r7917 if 'url' in kwargs:
Martin von Zweigbergk
repo: don't look up context for tip node if it's not needed...
 r39931 last = repo.changelog.tip()
Alexander Solovyov
diffstat hook example
 r7917 else:
last = node
diff = patch.diff(repo, first, last)
ui.write(patch.diffstat(util.iterlines(diff)))