##// END OF EJS Templates
typing: make the localrepo classes known to pytype...
typing: make the localrepo classes known to pytype 9d4ad05bc91c and 1b17309cdaab both mentioned making `bundlerepository` and `unionrepository` subclass `localrepository` during the type checking phase, but that didn't apply to pytype in practice. See bcaa5d408657 and friends for how the zope interfaces confuse pytype, and end up converting the classes they decorate into `Any`. This commit is slightly more complex though, because `localrepository` has mixin classes applied to it when it is instantiated. Specifically, `RevlogFileStorage` is added, which adds `def file(f)` (which isn't defined on `localrepository`). Therefore a list of `localrepository` superclasses is provided during type checking to account for the mixins. Without this, the `bundlerepository` class gets flagged when it attempts to call its superclass implementation of `file()`. Note that pytype doesn't understand these mixin superclasses (it marks the superclass of `localrepository` as `Any`, because they are zope interfaces it doesn't understand), but that's enough to get it to not flag `bundlerepository`. PyCharm also stops flagging it as a missing function, though it seems like it is able to handle the zope interfaces.

File last commit:

r52757:1c5810ce default
r52788:ee7e106b default
Show More
typelib.py
50 lines | 1.3 KiB | text/x-python | PythonLexer
Matt Harbison
pytype: stop excluding mercurial/ui.py...
r50688 # typelib.py - type hint aliases and support
#
# Copyright 2022 Matt Harbison <matt_harbison@yahoo.com>
#
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version.
Matt Harbison
typing: add `from __future__ import annotations` to remaining source files...
r52757 from __future__ import annotations
Matt Harbison
pytype: stop excluding mercurial/ui.py...
r50688 import typing
Matt Harbison
typing: add trivial type hints to `mercurial.scmutil`...
r52625 from typing import (
Callable,
)
Matt Harbison
pytype: stop excluding mercurial/ui.py...
r50688 # Note: this is slightly different from pycompat.TYPE_CHECKING, as using
# pycompat causes the BinaryIO_Proxy type to be resolved to ``object`` when
# used as the base class during a pytype run.
TYPE_CHECKING = typing.TYPE_CHECKING
# The BinaryIO class provides empty methods, which at runtime means that
# ``__getattr__`` on the proxy classes won't get called for the methods that
# should delegate to the internal object. So to avoid runtime changes because
# of the required typing inheritance, just use BinaryIO when typechecking, and
# ``object`` otherwise.
if TYPE_CHECKING:
from typing import (
BinaryIO,
Matt Harbison
typing: add type hints to `mercurial.dirstatemap`...
r52609 Union,
)
from . import (
node,
posix,
windows,
Matt Harbison
pytype: stop excluding mercurial/ui.py...
r50688 )
BinaryIO_Proxy = BinaryIO
Matt Harbison
typing: add type hints to `mercurial.dirstatemap`...
r52609 CacheStat = Union[posix.cachestat, windows.cachestat]
NodeConstants = node.sha1nodeconstants
Matt Harbison
pytype: stop excluding mercurial/ui.py...
r50688 else:
Matt Harbison
typing: add type hints to `mercurial.dirstatemap`...
r52609 from typing import Any
Matt Harbison
pytype: stop excluding mercurial/ui.py...
r50688 BinaryIO_Proxy = object
Matt Harbison
typing: add type hints to `mercurial.dirstatemap`...
r52609 CacheStat = Any
NodeConstants = Any
Matt Harbison
typing: add trivial type hints to `mercurial.scmutil`...
r52625
# scmutil.getuipathfn() related callback.
UiPathFn = Callable[[bytes], bytes]