##// END OF EJS Templates
hooks: introduce a `:run-with-plain` option for hooks...
hooks: introduce a `:run-with-plain` option for hooks This option control if HGPLAIN should be set or not for the hooks. This is the first step to give user some control of the HGPLAIN setting for they hooks. Some hooks (eg: consistency checking) deserve to be run with HGPLAIN, some other (eg: user set visual helper) might need to respect the user config and setting. So both usage are valid and we need to restore the ability to run -without- HGPLAIN that got lost in Mercurial 5.7. This does not offer a way to restore the pre-5.7 behavior yet (respect whatever HGPLAIN setting from the shell), this will be dealt with in the next changeset. The option name is a bit verbose because implementing this highlighs the need for another option: `:run-if-plain`. That would make it possible for some hooks to be easily disabled if HG PLAIN is set. However such option would be a new feature, not something introduced to mitigate a behavior change introduced in 5.7, so the `:run-if-plain` option belong to the default branch and is not part of this series. Differential Revision: https://phab.mercurial-scm.org/D9981

File last commit:

r45240:27fe8cc1 default
r47221:f22f6637 default
Show More
attachio.rs
68 lines | 2.4 KiB | application/rls-services+xml | RustLexer
Yuya Nishihara
rust-chg: add future that handles "attachio" request...
r40008 // Copyright 2018 Yuya Nishihara <yuya@tcha.org>
//
// This software may be used and distributed according to the terms of the
// GNU General Public License version 2 or any later version.
//! Functions to send client-side fds over the command server channel.
use std::io;
use std::os::unix::io::AsRawFd;
use tokio_hglib::codec::ChannelMessage;
Yuya Nishihara
rust-chg: reimplement attach_io operation as async function...
r45232 use tokio_hglib::{Connection, Protocol};
Yuya Nishihara
rust-chg: add future that handles "attachio" request...
r40008
Yuya Nishihara
rust-chg: use "crate::" to import local modules...
r45180 use crate::message;
use crate::procutil;
Yuya Nishihara
rust-chg: add future that handles "attachio" request...
r40008
Yuya Nishihara
rust-chg: reimplement attach_io operation as async function...
r45232 /// Sends client-side fds over the command server channel.
Yuya Nishihara
rust-chg: add future that handles "attachio" request...
r40008 ///
/// This works as follows:
/// 1. Client sends "attachio" request.
/// 2. Server sends back 1-byte input request.
/// 3. Client sends fds with 1-byte dummy payload in response.
/// 4. Server returns the number of the fds received.
///
Yuya Nishihara
rust-chg: have attach_io() simply take reference of AsRawFd object...
r45233 /// The client-side fds may be dropped once duplicated to the server.
Yuya Nishihara
rust-chg: reimplement attach_io operation as async function...
r45232 pub async fn attach_io(
proto: &mut Protocol<impl Connection + AsRawFd>,
Yuya Nishihara
rust-chg: have attach_io() simply take reference of AsRawFd object...
r45233 stdin: &impl AsRawFd,
stdout: &impl AsRawFd,
stderr: &impl AsRawFd,
Yuya Nishihara
rust-chg: reimplement attach_io operation as async function...
r45232 ) -> io::Result<()> {
Yuya Nishihara
rust-chg: clean up excessive indents...
r45240 proto.send_command("attachio").await?;
loop {
match proto.fetch_response().await? {
ChannelMessage::Data(b'r', data) => {
let fd_cnt = message::parse_result_code(data)?;
if fd_cnt == 3 {
return Ok(());
} else {
Gregory Szorc
rust: run rustfmt...
r44270 return Err(io::Error::new(
io::ErrorKind::InvalidData,
Yuya Nishihara
rust-chg: clean up excessive indents...
r45240 "unexpected attachio result",
Gregory Szorc
rust: run rustfmt...
r44270 ));
Yuya Nishihara
rust-chg: add future that handles "attachio" request...
r40008 }
}
Yuya Nishihara
rust-chg: clean up excessive indents...
r45240 ChannelMessage::Data(..) => {
// just ignore data sent to uninteresting (optional) channel
}
ChannelMessage::InputRequest(1) => {
// this may fail with EWOULDBLOCK in theory, but the
// payload is quite small, and the send buffer should
// be empty so the operation will complete immediately
let sock_fd = proto.as_raw_fd();
let ifd = stdin.as_raw_fd();
let ofd = stdout.as_raw_fd();
let efd = stderr.as_raw_fd();
procutil::send_raw_fds(sock_fd, &[ifd, ofd, efd])?;
}
ChannelMessage::InputRequest(..)
| ChannelMessage::LineRequest(..)
| ChannelMessage::SystemRequest(..) => {
return Err(io::Error::new(
io::ErrorKind::InvalidData,
"unsupported request while attaching io",
));
}
Yuya Nishihara
rust-chg: add future that handles "attachio" request...
r40008 }
}
}