upstream/mercurial-mirror Files · rust/hg-core/src/utils/files.rs

rust-filepatterns: add comment about Windows path handling...

rust-filepatterns: add comment about Windows path handling As I replied to the Phabricator message, this is wrong. And I even suspect it wouldn't compile because of multiple type mismatches. I think, in Rust where type system is rock solid, we can live with UTF-8 strings except for the bottom storage layer and the top UI/command layer. We'll still have to get around undecodable characters not to be lost, but I think it's okay to drop such filenames from match result if they don't match in UTF-8 world, not in Latin-1 world.

Yuya Nishihara - - Load All Authors

File last commit:

r42684:f305f1d7 default


                r42684:f305f1d7

default

Download file

             files.rs
        
                    19 lines
            
             | 509 B
            
                | application/rls-services+xml
            
             |
                RustLexer
            
             / rust / hg-core / src / utils / files.rs
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Raphaël Gomès
    
rust-filepatterns: use bytes instead of String...

              r42630
            
      use std::path::Path;

      pub fn get_path_from_bytes(bytes: &[u8]) -> &Path {

          let os_str;

          #[cfg(unix)]

          {

              use std::os::unix::ffi::OsStrExt;

              os_str = std::ffi::OsStr::from_bytes(bytes);

          }

          #[cfg(windows)]

          {

        Yuya Nishihara
    
rust-filepatterns: add comment about Windows path handling...

              r42684
            
              // TODO: convert from Windows MBCS (ANSI encoding) to WTF8.

              // Perhaps, the return type would have to be Result<PathBuf>.

        Raphaël Gomès
    
rust-filepatterns: use bytes instead of String...

              r42630
            
              use std::os::windows::ffi::OsStrExt;

              os_str = std::ffi::OsString::from_wide(bytes);

          }

          Path::new(os_str)

      }

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Raphaël Gomès rust-filepatterns: use bytes instead of String...	r42630	use std::path::Path;

		pub fn get_path_from_bytes(bytes: &[u8]) -> &Path {
		let os_str;
		#[cfg(unix)]
		{
		use std::os::unix::ffi::OsStrExt;
		os_str = std::ffi::OsStr::from_bytes(bytes);
		}
		#[cfg(windows)]
		{
Yuya Nishihara rust-filepatterns: add comment about Windows path handling...	r42684	// TODO: convert from Windows MBCS (ANSI encoding) to WTF8.
		// Perhaps, the return type would have to be Result<PathBuf>.
Raphaël Gomès rust-filepatterns: use bytes instead of String...	r42630	use std::os::windows::ffi::OsStrExt;
		os_str = std::ffi::OsString::from_wide(bytes);
		}

		Path::new(os_str)
		}