##// END OF EJS Templates
changegroup: don't try to build changelog chunks if not required...
changegroup: don't try to build changelog chunks if not required When we extend a narrow clone without ellipsis, we don't download changelog information because that's already present with the client. However we still try to build that chunk stream. Building that chunk stream involves calling a lookup function and store.emitrevisions() API. The lookup function is called len(cl) number of times. On large repositories, where len(cl) is in millions, calling that lookup function is not a good idea. Also it's not required to use the store.emitrevisons() API because we already have nodes present which we can use. This patch short-circuits state building logic if we are processing a non-ellipsis case and changelog is not required. This saves up ~20 seconds on our internal repo for a single extend call. Differential Revision: https://phab.mercurial-scm.org/D5733

File last commit:

r40672:8c6329fa default
r41491:fa7d61f9 default
Show More
rewriteutil.py
53 lines | 1.6 KiB | text/x-python | PythonLexer
Pulkit Goyal
rewriteutil: add utility function to check if we can create new unstable cset...
r35242 # rewriteutil.py - utility functions for rewriting changesets
#
# Copyright 2017 Octobus <contact@octobus.net>
#
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version.
from __future__ import absolute_import
Pulkit Goyal
rewriteutil: add a precheck function to check if revs can be rewritten...
r35243 from .i18n import _
Pulkit Goyal
rewriteutil: add utility function to check if we can create new unstable cset...
r35242 from . import (
Pulkit Goyal
rewriteutil: add a precheck function to check if revs can be rewritten...
r35243 error,
node,
Pulkit Goyal
rewriteutil: add utility function to check if we can create new unstable cset...
r35242 obsolete,
revset,
)
Pulkit Goyal
rewriteutil: add a precheck function to check if revs can be rewritten...
r35243 def precheck(repo, revs, action='rewrite'):
"""check if revs can be rewritten
action is used to control the error message.
Make sure this function is called after taking the lock.
"""
if node.nullrev in revs:
msg = _("cannot %s null changeset") % (action)
hint = _("no changeset checked out")
raise error.Abort(msg, hint=hint)
if len(repo[None].parents()) > 1:
raise error.Abort(_("cannot %s while merging") % action)
av6
rewriteutil: move publicrevs closer to where it's used
r40672 publicrevs = repo.revs('%ld and public()', revs)
Pulkit Goyal
rewriteutil: add a precheck function to check if revs can be rewritten...
r35243 if publicrevs:
msg = _("cannot %s public changesets") % (action)
hint = _("see 'hg help phases' for details")
raise error.Abort(msg, hint=hint)
newunstable = disallowednewunstable(repo, revs)
if newunstable:
raise error.Abort(_("cannot %s changeset with children") % action)
Pulkit Goyal
rewriteutil: add utility function to check if we can create new unstable cset...
r35242 def disallowednewunstable(repo, revs):
"""Checks whether editing the revs will create new unstable changesets and
are we allowed to create them.
To allow new unstable changesets, set the config:
`experimental.evolution.allowunstable=True`
"""
allowunstable = obsolete.isenabled(repo, obsolete.allowunstableopt)
if allowunstable:
return revset.baseset()
return repo.revs("(%ld::) - %ld", revs, revs)